[Minor Bug] Foreign Language Voice on Stickers converted to English VAs

[ioquirk]

Having Japanese or (most likely) any other language voice will be changed to English VAs when using stickers, but other dialogue seems unaffected. Nothing too grand though.

Using SharpPluginLoader 0.0.5, the loader itself seem to be causing the bug.

[Fexty12573]

Lol. You're actually not the first person to report this but I honestly have no idea what causes this to happen. I'll look into it when I get some time.

[Pizzabelly]

I gave this a look. It seems it could be related to adding a reference to each object during GetResourceHook(). With this patch the correct language voice lines are used for stickers. I don't know what the implications of not adding a ref here are though.

diff --git a/SharpPluginLoader.Core/ResourceManager.cs b/SharpPluginLoader.Core/ResourceManager.cs
index e2e3aa4..f47a02b 100644
--- a/SharpPluginLoader.Core/ResourceManager.cs
+++ b/SharpPluginLoader.Core/ResourceManager.cs
@@ -53,7 +53,7 @@ public static class ResourceManager
     private static nint GetResourceHook(nint resourceMgr, nint dti, string path, LoadFlags flags)
     {
         var resource = _getResourceHook.Original(resourceMgr, dti, path, flags);
-        var resObj = resource != 0 ? new Resource(resource) : null;
+        var resObj = resource != 0 ? new Resource(resource, true) : null;
         var dtiObj = new MtDti(dti);
 
         foreach (var plugin in PluginManager.Instance.GetPlugins(p => p.OnResourceLoad))

[Fexty12573]

Thanks for the fix. Making this change means that plugins that make use of the OnResourceLoad event need to make sure to explicitly add a reference (and remove it again) when they want to store the resource object beyond the scope of the function, to avoid it getting deallocated.

It ends up happening because the GC might take a while to clean up those objects, delaying their deallocation, at which point the game might have already selected them to be the resource to use. I'll incorporate this fix (or some variation of it) into the loader in the next few days.