feat(client): support reading the base url from an env variable (#186)

Author: stainless-bot

README.md

@@ -320,6 +320,7 @@ import httpx
 from finch import Finch
 
 client = Finch(
+    # Or use the `FINCH_BASE_URL` env var
     base_url="http://my.test.server.example.com:8083",
     http_client=httpx.Client(
         proxies="http://my.test.proxy.example.com",

src/finch/_client.py

@@ -112,6 +112,8 @@ def __init__(
             webhook_secret = os.environ.get("FINCH_WEBHOOK_SECRET")
         self.webhook_secret = webhook_secret
 
+        if base_url is None:
+            base_url = os.environ.get("FINCH_BASE_URL")
         if base_url is None:
             base_url = f"https://api.tryfinch.com"
 
@@ -414,6 +416,8 @@ def __init__(
             webhook_secret = os.environ.get("FINCH_WEBHOOK_SECRET")
         self.webhook_secret = webhook_secret
 
+        if base_url is None:
+            base_url = os.environ.get("FINCH_BASE_URL")
         if base_url is None:
             base_url = f"https://api.tryfinch.com"
 

tests/test_client.py

@@ -26,6 +26,8 @@
     make_request_options,
 )
 
+from .utils import update_env
+
 base_url = os.environ.get("TEST_API_BASE_URL", "http://127.0.0.1:4010")
 access_token = "My Access Token"
 
@@ -418,6 +420,11 @@ class Model2(BaseModel):
         assert isinstance(response, Model1)
         assert response.foo == 1
 
+    def test_base_url_env(self) -> None:
+        with update_env(FINCH_BASE_URL="http://localhost:5000/from/env"):
+            client = Finch(access_token=access_token, _strict_response_validation=True)
+            assert client.base_url == "http://localhost:5000/from/env/"
+
     @pytest.mark.parametrize(
         "client",
         [
@@ -1061,6 +1068,11 @@ class Model2(BaseModel):
         assert isinstance(response, Model1)
         assert response.foo == 1
 
+    def test_base_url_env(self) -> None:
+        with update_env(FINCH_BASE_URL="http://localhost:5000/from/env"):
+            client = AsyncFinch(access_token=access_token, _strict_response_validation=True)
+            assert client.base_url == "http://localhost:5000/from/env/"
+
     @pytest.mark.parametrize(
         "client",
         [

tests/utils.py

@@ -1,7 +1,9 @@
 from __future__ import annotations
 
+import os
 import traceback
-from typing import Any, TypeVar, cast
+import contextlib
+from typing import Any, TypeVar, Iterator, cast
 from datetime import date, datetime
 from typing_extensions import Literal, get_args, get_origin, assert_type
 
@@ -103,3 +105,16 @@ def _assert_list_type(type_: type[object], value: object) -> None:
     inner_type = get_args(type_)[0]
     for entry in value:
         assert_type(inner_type, entry)  # type: ignore
+
+
+@contextlib.contextmanager
+def update_env(**new_env: str) -> Iterator[None]:
+    old = os.environ.copy()
+
+    try:
+        os.environ.update(new_env)
+
+        yield None
+    finally:
+        os.environ.clear()
+        os.environ.update(old)