Skip to content

Commit 0986884

Browse files
authored
Merge pull request #4 from FlipNoteTeam/feat/update-profile
Feat: 이미지 변경 로직 간소화
2 parents bf53649 + cf90bc4 commit 0986884

2 files changed

Lines changed: 26 additions & 17 deletions

File tree

src/main/java/flipnote/user/user/application/UserService.java

Lines changed: 25 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
import org.springframework.stereotype.Service;
44
import org.springframework.transaction.annotation.Transactional;
55

6+
import flipnote.image.grpc.v1.ActivateImageRequest;
7+
import flipnote.image.grpc.v1.ActivateImageResponse;
68
import flipnote.image.grpc.v1.ChangeImageRequest;
79
import flipnote.image.grpc.v1.ChangeImageResponse;
8-
import flipnote.image.grpc.v1.GetUrlByReferenceRequest;
9-
import flipnote.image.grpc.v1.GetUrlByReferenceResponse;
1010
import flipnote.image.grpc.v1.ImageCommandServiceGrpc;
1111
import flipnote.image.grpc.v1.Type;
1212
import flipnote.user.auth.infrastructure.jwt.JwtProvider;
@@ -50,26 +50,35 @@ public UserUpdateResponse updateProfile(Long userId, UpdateProfileRequest reques
5050
User user = findActiveUser(userId);
5151

5252
String profileImageUrl = null;
53-
Long imageRefId = null;
5453
if (request.getImageRefId() != null) {
55-
try {
56-
ChangeImageResponse changeImageResponse = imageCommandServiceStub.changeImage(
57-
ChangeImageRequest.newBuilder()
58-
.setReferenceType(Type.USER)
59-
.setReferenceId(userId)
60-
.setImageRefId(request.getImageRefId())
61-
.build());
54+
try {
55+
if (User.DEFAULT_PROFILE_IMAGE_URL.equals(user.getProfileImageUrl())) {
56+
ActivateImageResponse activateImageResponse = imageCommandServiceStub.activateImage(
57+
ActivateImageRequest.newBuilder()
58+
.setReferenceType(Type.USER)
59+
.setReferenceId(userId)
60+
.setImageRefId(request.getImageRefId())
61+
.build());
6262

63-
profileImageUrl = changeImageResponse.getUrl();
64-
imageRefId = changeImageResponse.getImageRefId();
65-
} catch (Exception ex) {
63+
profileImageUrl = activateImageResponse.getUrl();
64+
} else {
65+
ChangeImageResponse changeImageResponse = imageCommandServiceStub.changeImage(
66+
ChangeImageRequest.newBuilder()
67+
.setReferenceType(Type.USER)
68+
.setReferenceId(userId)
69+
.setImageRefId(request.getImageRefId())
70+
.build());
71+
72+
profileImageUrl = changeImageResponse.getUrl();
73+
}
74+
} catch (Exception ex) {
6675
log.error("updateProfile", ex);
67-
throw new BizException(ImageErrorCode.IMAGE_SERVICE_ERROR);
68-
}
76+
throw new BizException(ImageErrorCode.IMAGE_SERVICE_ERROR);
77+
}
6978
}
7079

7180
user.updateProfile(request.getNickname(), request.getPhone(), request.getSmsAgree(), profileImageUrl);
72-
return UserUpdateResponse.from(user, imageRefId);
81+
return UserUpdateResponse.from(user, request.getImageRefId());
7382
}
7483

7584
@Transactional

src/main/java/flipnote/user/user/domain/User.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
@NoArgsConstructor(access = AccessLevel.PROTECTED)
1616
public class User extends BaseEntity {
1717

18-
private static final String DEFAULT_PROFILE_IMAGE_URL =
18+
public static final String DEFAULT_PROFILE_IMAGE_URL =
1919
"https://flipnote-bucket.s3.ap-northeast-2.amazonaws.com/image/default/user.png";
2020

2121
@Id

0 commit comments

Comments
 (0)