Skip to content

No signature re-verification before settlement #16

Description

@a6b8

Classification

  • Security hardening

Problem

settleTransaction() (line 542-611) does not re-verify the signature before the sendTransaction() call. It trusts that validatePaymentSignatureRequestPayload() ran previously.

Affected Files

  • src/v2/exact/evm/ServerExact.mjs lines 542-611

Expected vs Actual

  • Expected: Signature is re-verified immediately before funds transfer
  • Actual: Settlement blindly trusts prior validation

Recommendation

Add signature check directly in settleTransaction() before sendTransaction(). Defense-in-depth principle.

Severity

MEDIUM

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingsecuritySecurity vulnerability or hardening

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions