From c665bffbdc216031b81debb920286e480db73549 Mon Sep 17 00:00:00 2001 From: Arnaud Moncel Date: Mon, 26 Jan 2026 14:45:12 +0100 Subject: [PATCH 1/7] feat(rpc agent): add mark collection as rpc option on add datasource --- .../lib/forest_admin_rpc_agent/agent.rb | 15 ++++++++++ .../datasource_customizer.rb | 28 +++++++++++++++++++ 2 files changed, 43 insertions(+) create mode 100644 packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/datasource_customizer.rb diff --git a/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb b/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb index a99eccced..4362304b1 100644 --- a/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb +++ b/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb @@ -12,6 +12,21 @@ def setup(options) @rpc_collections = [] @cached_schema = nil @cached_schema_hash = nil + @customizer = ForestAdminRpcAgent::DatasourceCustomizer.new + end + + def add_datasource(datasource, options = {}) + mark_collections_as_rpc = nil + + if options[:mark_collections_as_rpc] + mark_collections_as_rpc = ->(buildedDatasource) { + mark_collections_as_rpc(*buildedDatasource.collections.keys) + } + end + + @customizer.add_datasource(datasource, options, mark_collections_as_rpc) + + self end def send_schema(force: false) diff --git a/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/datasource_customizer.rb b/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/datasource_customizer.rb new file mode 100644 index 000000000..b5e69d9b9 --- /dev/null +++ b/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/datasource_customizer.rb @@ -0,0 +1,28 @@ +module ForestAdminRpcAgent + class DatasourceCustomizer < ForestAdminDatasourceCustomizer::DatasourceCustomizer + def add_datasource(datasource, options, mark_collections_as_rpc) + puts mark_collections_as_rpc + @stack.queue_customization(lambda { + if options[:include] || options[:exclude] + publication_decorator = Decorators::Publication::PublicationDatasourceDecorator.new(datasource) + publication_decorator.keep_collections_matching(options[:include], options[:exclude]) + datasource = publication_decorator + end + + if options[:rename] + rename_collection_decorator = Decorators::RenameCollection::RenameCollectionDatasourceDecorator.new( + datasource + ) + rename_collection_decorator.rename_collections(options[:rename]) + datasource = rename_collection_decorator + end + + mark_collections_as_rpc.call(datasource) if mark_collections_as_rpc + + @composite_datasource.add_data_source(datasource) + }) + + self + end + end +end From 1ee294e4f566c0b0bd6ac8c054b42c48c41309c5 Mon Sep 17 00:00:00 2001 From: Arnaud Moncel Date: Mon, 26 Jan 2026 14:54:43 +0100 Subject: [PATCH 2/7] fix: lint --- .../lib/forest_admin_rpc_agent/agent.rb | 4 ++-- .../lib/forest_admin_rpc_agent/datasource_customizer.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb b/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb index 4362304b1..0dea3314c 100644 --- a/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb +++ b/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb @@ -19,8 +19,8 @@ def add_datasource(datasource, options = {}) mark_collections_as_rpc = nil if options[:mark_collections_as_rpc] - mark_collections_as_rpc = ->(buildedDatasource) { - mark_collections_as_rpc(*buildedDatasource.collections.keys) + mark_collections_as_rpc = lambda { |builded_datasource| + mark_collections_as_rpc(*builded_datasource.collections.keys) } end diff --git a/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/datasource_customizer.rb b/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/datasource_customizer.rb index b5e69d9b9..219eb5af9 100644 --- a/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/datasource_customizer.rb +++ b/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/datasource_customizer.rb @@ -17,7 +17,7 @@ def add_datasource(datasource, options, mark_collections_as_rpc) datasource = rename_collection_decorator end - mark_collections_as_rpc.call(datasource) if mark_collections_as_rpc + mark_collections_as_rpc&.call(datasource) @composite_datasource.add_data_source(datasource) }) From ba44bd56e2d5118165486c1cd4e75d113911e139 Mon Sep 17 00:00:00 2001 From: Arnaud Moncel Date: Mon, 26 Jan 2026 15:00:52 +0100 Subject: [PATCH 3/7] fix: lint --- .rubocop.yml | 577 +++++++++++++++++++++++++-------------------------- 1 file changed, 288 insertions(+), 289 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 1be7b1900..1bc6c5ae0 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -6,57 +6,57 @@ AllCops: TargetRubyVersion: 3.0 NewCops: enable Exclude: - - 'packages/forest_admin_datasource_active_record/spec/dummy/**/*' - - 'packages/forest_admin_datasource_mongoid/spec/dummy/**/*' - - 'packages/forest_admin_agent/lib/forest_admin_agent/serializer/forest_serializer.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/serializer/forest_serializer_override.rb' - - 'packages/forest_admin_rpc_agent/bin/**/*' - - 'node_modules/semantic-release-rubygem/**/*' - - 'packages/_examples/**/*' + - "packages/forest_admin_datasource_active_record/spec/dummy/**/*" + - "packages/forest_admin_datasource_mongoid/spec/dummy/**/*" + - "packages/forest_admin_agent/lib/forest_admin_agent/serializer/forest_serializer.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/serializer/forest_serializer_override.rb" + - "packages/forest_admin_rpc_agent/bin/**/*" + - "node_modules/semantic-release-rubygem/**/*" + - "packages/_examples/**/*" Gemspec/OrderedDependencies: Exclude: - - 'packages/forest_admin_agent/forest_admin_agent.gemspec' - - 'packages/forest_admin_rails/forest_admin_rails.gemspec' - - 'packages/forest_admin_datasource_toolkit/forest_admin_datasource_toolkit.gemspec' - - 'packages/forest_admin_datasource_mongoid/forest_admin_datasource_mongoid.gemspec' - - 'packages/forest_admin_datasource_rpc/forest_admin_datasource_rpc.gemspec' - - 'packages/forest_admin_rpc_agent/forest_admin_rpc_agent.gemspec' - - 'packages/forest_admin_test_toolkit/forest_admin_test_toolkit.gemspec' - - 'packages/forest_admin_datasource_customizer/forest_admin_datasource_customizer.gemspec' - - 'packages/forest_admin_datasource_active_record/forest_admin_datasource_active_record.gemspec' + - "packages/forest_admin_agent/forest_admin_agent.gemspec" + - "packages/forest_admin_rails/forest_admin_rails.gemspec" + - "packages/forest_admin_datasource_toolkit/forest_admin_datasource_toolkit.gemspec" + - "packages/forest_admin_datasource_mongoid/forest_admin_datasource_mongoid.gemspec" + - "packages/forest_admin_datasource_rpc/forest_admin_datasource_rpc.gemspec" + - "packages/forest_admin_rpc_agent/forest_admin_rpc_agent.gemspec" + - "packages/forest_admin_test_toolkit/forest_admin_test_toolkit.gemspec" + - "packages/forest_admin_datasource_customizer/forest_admin_datasource_customizer.gemspec" + - "packages/forest_admin_datasource_active_record/forest_admin_datasource_active_record.gemspec" Gemspec/RequireMFA: Exclude: - - 'agent_ruby.gemspec' - - 'packages/forest_admin_agent/forest_admin_agent.gemspec' - - 'packages/forest_admin_rails/forest_admin_rails.gemspec' - - 'packages/forest_admin_datasource_toolkit/forest_admin_datasource_toolkit.gemspec' - - 'packages/forest_admin_datasource_mongoid/forest_admin_datasource_mongoid.gemspec' - - 'packages/forest_admin_datasource_rpc/forest_admin_datasource_rpc.gemspec' - - 'packages/forest_admin_rpc_agent/forest_admin_rpc_agent.gemspec' - - 'packages/forest_admin_test_toolkit/forest_admin_test_toolkit.gemspec' - - 'packages/forest_admin_datasource_customizer/forest_admin_datasource_customizer.gemspec' - - 'packages/forest_admin_datasource_active_record/forest_admin_datasource_active_record.gemspec' + - "agent_ruby.gemspec" + - "packages/forest_admin_agent/forest_admin_agent.gemspec" + - "packages/forest_admin_rails/forest_admin_rails.gemspec" + - "packages/forest_admin_datasource_toolkit/forest_admin_datasource_toolkit.gemspec" + - "packages/forest_admin_datasource_mongoid/forest_admin_datasource_mongoid.gemspec" + - "packages/forest_admin_datasource_rpc/forest_admin_datasource_rpc.gemspec" + - "packages/forest_admin_rpc_agent/forest_admin_rpc_agent.gemspec" + - "packages/forest_admin_test_toolkit/forest_admin_test_toolkit.gemspec" + - "packages/forest_admin_datasource_customizer/forest_admin_datasource_customizer.gemspec" + - "packages/forest_admin_datasource_active_record/forest_admin_datasource_active_record.gemspec" # Offense count: 1 # This cop supports unsafe autocorrection (--autocorrect-all). Lint/PercentStringArray: Exclude: - - 'packages/forest_admin_agent/forest_admin_agent.gemspec' - - 'packages/forest_admin_rails/forest_admin_rails.gemspec' - - 'packages/forest_admin_datasource_toolkit/forest_admin_datasource_toolkit.gemspec' - - 'packages/forest_admin_datasource_mongoid/forest_admin_datasource_mongoid.gemspec' - - 'packages/forest_admin_datasource_rpc/forest_admin_datasource_rpc.gemspec' - - 'packages/forest_admin_rpc_agent/forest_admin_rpc_agent.gemspec' - - 'packages/forest_admin_datasource_customizer/forest_admin_datasource_customizer.gemspec' - - 'packages/forest_admin_datasource_active_record/forest_admin_datasource_active_record.gemspec' + - "packages/forest_admin_agent/forest_admin_agent.gemspec" + - "packages/forest_admin_rails/forest_admin_rails.gemspec" + - "packages/forest_admin_datasource_toolkit/forest_admin_datasource_toolkit.gemspec" + - "packages/forest_admin_datasource_mongoid/forest_admin_datasource_mongoid.gemspec" + - "packages/forest_admin_datasource_rpc/forest_admin_datasource_rpc.gemspec" + - "packages/forest_admin_rpc_agent/forest_admin_rpc_agent.gemspec" + - "packages/forest_admin_datasource_customizer/forest_admin_datasource_customizer.gemspec" + - "packages/forest_admin_datasource_active_record/forest_admin_datasource_active_record.gemspec" # Offense count: 1 # Configuration parameters: AllowComments. Lint/EmptyFile: Exclude: - - 'packages/forest_admin_rails/app/models/forest_admin_rails/application_record.rb' + - "packages/forest_admin_rails/app/models/forest_admin_rails/application_record.rb" Metrics/AbcSize: Enabled: false @@ -69,14 +69,14 @@ Metrics/PerceivedComplexity: Style/BlockComments: Exclude: - - 'packages/forest_admin_agent/spec/spec_helper.rb' - - 'packages/forest_admin_rails/spec/spec_helper.rb' - - 'packages/forest_admin_datasource_toolkit/spec/spec_helper.rb' - - 'packages/forest_admin_datasource_mongoid/spec/spec_helper.rb' - - 'packages/forest_admin_datasource_rpc/spec/spec_helper.rb' - - 'packages/forest_admin_rpc_agent/spec/spec_helper.rb' - - 'packages/forest_admin_datasource_customizer/spec/spec_helper.rb' - - 'packages/forest_admin_datasource_active_record/spec/spec_helper.rb' + - "packages/forest_admin_agent/spec/spec_helper.rb" + - "packages/forest_admin_rails/spec/spec_helper.rb" + - "packages/forest_admin_datasource_toolkit/spec/spec_helper.rb" + - "packages/forest_admin_datasource_mongoid/spec/spec_helper.rb" + - "packages/forest_admin_datasource_rpc/spec/spec_helper.rb" + - "packages/forest_admin_rpc_agent/spec/spec_helper.rb" + - "packages/forest_admin_datasource_customizer/spec/spec_helper.rb" + - "packages/forest_admin_datasource_active_record/spec/spec_helper.rb" # Offense count: 3 # Configuration parameters: AllowedConstants. @@ -96,17 +96,17 @@ Style/FrozenStringLiteralComment: # SupportedStyles: literals, strict Style/MutableConstant: Exclude: - - 'lib/agent_ruby/version.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/version.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/schema_emitter.rb' - - 'packages/forest_admin_rails/lib/forest_admin_rails/version.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/version.rb' - - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/version.rb' - - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/version.rb' - - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/version.rb' - - 'packages/forest_admin_test_toolkit/lib/forest_admin_test_toolkit/version.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/version.rb' - - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/version.rb' + - "lib/agent_ruby/version.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/version.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/schema_emitter.rb" + - "packages/forest_admin_rails/lib/forest_admin_rails/version.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/version.rb" + - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/version.rb" + - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/version.rb" + - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/version.rb" + - "packages/forest_admin_test_toolkit/lib/forest_admin_test_toolkit/version.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/version.rb" + - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/version.rb" # Offense count: 38 # This cop supports safe autocorrection (--autocorrect). @@ -114,79 +114,79 @@ Style/MutableConstant: # SupportedStyles: single_quotes, double_quotes Style/StringLiterals: Exclude: - - 'agent_ruby.gemspec' - - 'Gemfile' - - 'Rakefile' - - 'bin/console' - - 'lib/agent_ruby.rb' - - 'lib/agent_ruby/version.rb' - - 'packages/forest_admin_agent/forest_admin_agent.gemspec' - - 'packages/forest_admin_agent/Gemfile' - - 'packages/forest_admin_agent/Rakefile' - - 'packages/forest_admin_agent/bin/console' - - 'packages/forest_admin_agent/lib/forest_admin_agent.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/version.rb' - - 'packages/forest_admin_agent/spec/forest_admin_agent_spec.rb' - - 'packages/forest_admin_agent/spec/spec_helper.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/schema_emitter.rb' - - 'packages/forest_admin_rails/forest_admin_rails.gemspec' - - 'packages/forest_admin_rails/Gemfile' - - 'packages/forest_admin_rails/Rakefile' - - 'packages/forest_admin_rails/bin/console' - - 'packages/forest_admin_rails/bin/rails' - - 'packages/forest_admin_rails/lib/forest_admin_rails.rb' - - 'packages/forest_admin_rails/lib/forest_admin_rails/version.rb' - - 'packages/forest_admin_rails/spec/rails_helper.rb' - - 'packages/forest_admin_rails/spec/spec_helper.rb' - - 'packages/forest_admin_datasource_toolkit/forest_admin_datasource_toolkit.gemspec' - - 'packages/forest_admin_datasource_toolkit/Gemfile' - - 'packages/forest_admin_datasource_toolkit/Rakefile' - - 'packages/forest_admin_datasource_toolkit/bin/console' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/version.rb' - - 'packages/forest_admin_datasource_toolkit/spec/spec_helper.rb' - - 'packages/forest_admin_datasource_mongoid/forest_admin_datasource_mongoid.gemspec' - - 'packages/forest_admin_datasource_mongoid/Gemfile' - - 'packages/forest_admin_datasource_mongoid/Rakefile' - - 'packages/forest_admin_datasource_mongoid/bin/console' - - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid.rb' - - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/version.rb' - - 'packages/forest_admin_datasource_mongoid/spec/spec_helper.rb' - - 'packages/forest_admin_datasource_rpc/forest_admin_datasource_rpc.gemspec' - - 'packages/forest_admin_datasource_rpc/Gemfile' - - 'packages/forest_admin_datasource_rpc/Rakefile' - - 'packages/forest_admin_datasource_rpc/bin/console' - - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc.rb' - - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/version.rb' - - 'packages/forest_admin_datasource_rpc/spec/spec_helper.rb' - - 'packages/forest_admin_rpc_agent/forest_admin_rpc_agent.gemspec' - - 'packages/forest_admin_rpc_agent/Gemfile' - - 'packages/forest_admin_rpc_agent/Rakefile' - - 'packages/forest_admin_rpc_agent/bin/console' - - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent.rb' - - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/version.rb' - - 'packages/forest_admin_rpc_agent/spec/spec_helper.rb' - - 'packages/forest_admin_test_toolkit/forest_admin_test_toolkit.gemspec' - - 'packages/forest_admin_test_toolkit/Gemfile' - - 'packages/forest_admin_test_toolkit/Rakefile' - - 'packages/forest_admin_test_toolkit/bin/console' - - 'packages/forest_admin_test_toolkit/lib/forest_admin_test_toolkit.rb' - - 'packages/forest_admin_test_toolkit/lib/forest_admin_test_toolkit/version.rb' - - 'packages/forest_admin_test_toolkit/spec/spec_helper.rb' - - 'packages/forest_admin_datasource_customizer/forest_admin_datasource_customizer.gemspec' - - 'packages/forest_admin_datasource_customizer/Gemfile' - - 'packages/forest_admin_datasource_customizer/Rakefile' - - 'packages/forest_admin_datasource_customizer/bin/console' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/version.rb' - - 'packages/forest_admin_datasource_customizer/spec/spec_helper.rb' - - 'packages/forest_admin_datasource_active_record/forest_admin_datasource_active_record.gemspec' - - 'packages/forest_admin_datasource_active_record/Gemfile' - - 'packages/forest_admin_datasource_active_record/Rakefile' - - 'packages/forest_admin_datasource_active_record/bin/console' - - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record.rb' - - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/version.rb' - - 'packages/forest_admin_datasource_active_record/spec/spec_helper.rb' + - "agent_ruby.gemspec" + - "Gemfile" + - "Rakefile" + - "bin/console" + - "lib/agent_ruby.rb" + - "lib/agent_ruby/version.rb" + - "packages/forest_admin_agent/forest_admin_agent.gemspec" + - "packages/forest_admin_agent/Gemfile" + - "packages/forest_admin_agent/Rakefile" + - "packages/forest_admin_agent/bin/console" + - "packages/forest_admin_agent/lib/forest_admin_agent.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/version.rb" + - "packages/forest_admin_agent/spec/forest_admin_agent_spec.rb" + - "packages/forest_admin_agent/spec/spec_helper.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/schema_emitter.rb" + - "packages/forest_admin_rails/forest_admin_rails.gemspec" + - "packages/forest_admin_rails/Gemfile" + - "packages/forest_admin_rails/Rakefile" + - "packages/forest_admin_rails/bin/console" + - "packages/forest_admin_rails/bin/rails" + - "packages/forest_admin_rails/lib/forest_admin_rails.rb" + - "packages/forest_admin_rails/lib/forest_admin_rails/version.rb" + - "packages/forest_admin_rails/spec/rails_helper.rb" + - "packages/forest_admin_rails/spec/spec_helper.rb" + - "packages/forest_admin_datasource_toolkit/forest_admin_datasource_toolkit.gemspec" + - "packages/forest_admin_datasource_toolkit/Gemfile" + - "packages/forest_admin_datasource_toolkit/Rakefile" + - "packages/forest_admin_datasource_toolkit/bin/console" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/version.rb" + - "packages/forest_admin_datasource_toolkit/spec/spec_helper.rb" + - "packages/forest_admin_datasource_mongoid/forest_admin_datasource_mongoid.gemspec" + - "packages/forest_admin_datasource_mongoid/Gemfile" + - "packages/forest_admin_datasource_mongoid/Rakefile" + - "packages/forest_admin_datasource_mongoid/bin/console" + - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid.rb" + - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/version.rb" + - "packages/forest_admin_datasource_mongoid/spec/spec_helper.rb" + - "packages/forest_admin_datasource_rpc/forest_admin_datasource_rpc.gemspec" + - "packages/forest_admin_datasource_rpc/Gemfile" + - "packages/forest_admin_datasource_rpc/Rakefile" + - "packages/forest_admin_datasource_rpc/bin/console" + - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc.rb" + - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/version.rb" + - "packages/forest_admin_datasource_rpc/spec/spec_helper.rb" + - "packages/forest_admin_rpc_agent/forest_admin_rpc_agent.gemspec" + - "packages/forest_admin_rpc_agent/Gemfile" + - "packages/forest_admin_rpc_agent/Rakefile" + - "packages/forest_admin_rpc_agent/bin/console" + - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent.rb" + - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/version.rb" + - "packages/forest_admin_rpc_agent/spec/spec_helper.rb" + - "packages/forest_admin_test_toolkit/forest_admin_test_toolkit.gemspec" + - "packages/forest_admin_test_toolkit/Gemfile" + - "packages/forest_admin_test_toolkit/Rakefile" + - "packages/forest_admin_test_toolkit/bin/console" + - "packages/forest_admin_test_toolkit/lib/forest_admin_test_toolkit.rb" + - "packages/forest_admin_test_toolkit/lib/forest_admin_test_toolkit/version.rb" + - "packages/forest_admin_test_toolkit/spec/spec_helper.rb" + - "packages/forest_admin_datasource_customizer/forest_admin_datasource_customizer.gemspec" + - "packages/forest_admin_datasource_customizer/Gemfile" + - "packages/forest_admin_datasource_customizer/Rakefile" + - "packages/forest_admin_datasource_customizer/bin/console" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/version.rb" + - "packages/forest_admin_datasource_customizer/spec/spec_helper.rb" + - "packages/forest_admin_datasource_active_record/forest_admin_datasource_active_record.gemspec" + - "packages/forest_admin_datasource_active_record/Gemfile" + - "packages/forest_admin_datasource_active_record/Rakefile" + - "packages/forest_admin_datasource_active_record/bin/console" + - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record.rb" + - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/version.rb" + - "packages/forest_admin_datasource_active_record/spec/spec_helper.rb" # Offense count: 1 # This cop supports safe autocorrection (--autocorrect). @@ -198,7 +198,7 @@ Style/WordArray: Style/SymbolArray: Exclude: - - 'packages/forest_admin_agent/spec/lib/forest_admin_agent/utils/schema/generator_field_many_to_many_spec.rb' + - "packages/forest_admin_agent/spec/lib/forest_admin_agent/utils/schema/generator_field_many_to_many_spec.rb" Style/StringLiteralsInInterpolation: Enabled: true @@ -206,232 +206,231 @@ Style/StringLiteralsInInterpolation: Style/RedundantConstantBase: Exclude: - - 'packages/forest_admin_rails/spec/rails_helper.rb' + - "packages/forest_admin_rails/spec/rails_helper.rb" Style/HashEachMethods: Exclude: - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/condition_tree_factory.rb' + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/condition_tree_factory.rb" Lint/NestedMethodDefinition: Exclude: - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb' + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb" Performance/CollectionLiteralInLoop: Exclude: - - 'packages/forest_admin_agent/lib/forest_admin_agent/utils/condition_tree_parser.rb' + - "packages/forest_admin_agent/lib/forest_admin_agent/utils/condition_tree_parser.rb" Naming/PredicatePrefix: Exclude: - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/collection.rb' + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/collection.rb" Metrics/ParameterLists: Exclude: - - 'packages/forest_admin_agent/lib/forest_admin_agent/routes/query_handler.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/services/smart_action_checker.rb' - - 'packages/forest_admin_agent/spec/lib/forest_admin_agent/routes/resources/related/list_related_spec.rb' - - 'packages/forest_admin_agent/spec/lib/forest_admin_agent/routes/resources/related/count_related_spec.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/context/action_context.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/action_collection_decorator.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/dynamic_field.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/hook/context/after/hook_after_aggregate_context.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/dsl/builders/form_builder.rb' - - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/datasource.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/schema/relations/many_to_many_schema.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/schema/column_schema.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/caller.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/utils/collection.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/action_field.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/actions/action_field.rb' + - "packages/forest_admin_agent/lib/forest_admin_agent/routes/query_handler.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/services/smart_action_checker.rb" + - "packages/forest_admin_agent/spec/lib/forest_admin_agent/routes/resources/related/list_related_spec.rb" + - "packages/forest_admin_agent/spec/lib/forest_admin_agent/routes/resources/related/count_related_spec.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/context/action_context.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/action_collection_decorator.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/dynamic_field.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/hook/context/after/hook_after_aggregate_context.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/dsl/builders/form_builder.rb" + - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/datasource.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/schema/relations/many_to_many_schema.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/schema/column_schema.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/caller.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/utils/collection.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/action_field.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/actions/action_field.rb" Metrics/ModuleLength: - CountAsOne: [ 'array', 'hash', 'method_call' ] + CountAsOne: ["array", "hash", "method_call"] Exclude: - - 'packages/forest_admin_agent/spec/**/*' - - 'packages/forest_admin_datasource_active_record/spec/**/*' - - 'packages/forest_admin_datasource_toolkit/spec/**/*' - - 'packages/forest_admin_datasource_rpc/spec/**/*' - - 'packages/forest_admin_datasource_mongoid/spec/**/*' - - 'packages/forest_admin_datasource_customizer/spec/**/*' - - 'packages/forest_admin_rails/spec/**/*' - - 'packages/forest_admin_rpc_agent/spec/**/*' - - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/helpers.rb' + - "packages/forest_admin_agent/spec/**/*" + - "packages/forest_admin_datasource_active_record/spec/**/*" + - "packages/forest_admin_datasource_toolkit/spec/**/*" + - "packages/forest_admin_datasource_rpc/spec/**/*" + - "packages/forest_admin_datasource_mongoid/spec/**/*" + - "packages/forest_admin_datasource_customizer/spec/**/*" + - "packages/forest_admin_rails/spec/**/*" + - "packages/forest_admin_rpc_agent/spec/**/*" + - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/helpers.rb" Metrics/MethodLength: - CountAsOne: ['array', 'hash', 'method_call'] + CountAsOne: ["array", "hash", "method_call"] Max: 20 Exclude: - - 'packages/forest_admin_agent/lib/forest_admin_agent/auth/oauth2/forest_provider.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/builder/agent_factory.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/http/error_translator.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/routes/charts/charts.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/serializer/json_api_serializer.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/services/smart_action_checker.rb' - - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/parser/validation.rb' - - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/collection.rb' - - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/utils/query.rb' - - 'packages/forest_admin_datasource_active_record/spec/dummy/**/*' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/computed/utils/flattener.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/decorators_stack.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/publication/publication_collection_decorator.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/search/search_collection_decorator.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/write/write_replace/write_replace_collection_decorator.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/plugins/import_field.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/collection.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/condition_tree_factory.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/nodes/condition_tree_leaf.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/condition_tree_equivalent.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/validations/field_validator.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/actions/action_field_factory.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/base_action.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/rename_field/rename_field_collection_decorator.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/action_collection_decorator.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/form_factory.rb' - - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/collection.rb' - - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/query.rb' - - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/schema/fields_generator.rb' - - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/schema/mongoid_schema.rb' - - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/pipeline/filter_generator.rb' - - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/pipeline/lookup_generator.rb' - - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/collection.rb' - - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc.rb' - - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/sse_client.rb' - - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb' - - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/sse.rb' - - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/http/router.rb' - + - "packages/forest_admin_agent/lib/forest_admin_agent/auth/oauth2/forest_provider.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/builder/agent_factory.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/http/error_translator.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/routes/charts/charts.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/serializer/json_api_serializer.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/services/smart_action_checker.rb" + - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/parser/validation.rb" + - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/collection.rb" + - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/utils/query.rb" + - "packages/forest_admin_datasource_active_record/spec/dummy/**/*" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/computed/utils/flattener.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/decorators_stack.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/publication/publication_collection_decorator.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/search/search_collection_decorator.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/write/write_replace/write_replace_collection_decorator.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/plugins/import_field.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/collection.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/condition_tree_factory.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/nodes/condition_tree_leaf.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/condition_tree_equivalent.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/validations/field_validator.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/actions/action_field_factory.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/base_action.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/rename_field/rename_field_collection_decorator.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/action_collection_decorator.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/form_factory.rb" + - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/collection.rb" + - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/query.rb" + - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/schema/fields_generator.rb" + - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/schema/mongoid_schema.rb" + - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/pipeline/filter_generator.rb" + - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/pipeline/lookup_generator.rb" + - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/collection.rb" + - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc.rb" + - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/sse_client.rb" + - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb" + - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/sse.rb" + - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/http/router.rb" Metrics/BlockLength: Exclude: - - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/collection.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/base_action.rb' - - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/collection.rb' - - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/sse.rb' - - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/http/router.rb' + - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/collection.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/base_action.rb" + - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/collection.rb" + - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/sse.rb" + - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/http/router.rb" Metrics/ClassLength: Exclude: - - 'packages/forest_admin_agent/lib/forest_admin_agent/builder/agent_factory.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/generator_field.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/routes/charts/charts.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/routes/action/actions.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/routes/resources/related/dissociate_related.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/routes/resources/related/update_related.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/services/permissions.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/services/smart_action_checker.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/frontend_validation_utils.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/utils/query_string_parser.rb' - - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/utils/query.rb' - - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/collection.rb' - - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/datasource.rb' - - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/utils/query_aggregate.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/collection_customizer.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/binary/binary_collection_decorator.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/search/search_collection_decorator.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/relation/relation_collection_decorator.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/rename_collection/rename_collection_decorator.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/rename_field/rename_field_collection_decorator.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/utils/collection.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/aggregation.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/nodes/condition_tree_leaf.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/transforms/comparisons.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/validations/rules.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/generator_action_field_widget.rb' - - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/collection.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/generator_action.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/action_collection_decorator.rb' - - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/collection.rb' - - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/query.rb' - - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/schema/mongoid_schema.rb' - - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/pipeline/filter_generator.rb' - - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/collection.rb' - - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/rpc_client.rb' - - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb' - - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_pool.rb' - - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/sse_client.rb' - - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/sse.rb' + - "packages/forest_admin_agent/lib/forest_admin_agent/builder/agent_factory.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/generator_field.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/routes/charts/charts.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/routes/action/actions.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/routes/resources/related/dissociate_related.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/routes/resources/related/update_related.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/services/permissions.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/services/smart_action_checker.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/frontend_validation_utils.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/utils/query_string_parser.rb" + - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/utils/query.rb" + - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/collection.rb" + - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/datasource.rb" + - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/utils/query_aggregate.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/collection_customizer.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/binary/binary_collection_decorator.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/search/search_collection_decorator.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/relation/relation_collection_decorator.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/rename_collection/rename_collection_decorator.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/rename_field/rename_field_collection_decorator.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/utils/collection.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/aggregation.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/nodes/condition_tree_leaf.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/transforms/comparisons.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/validations/rules.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/generator_action_field_widget.rb" + - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/collection.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/generator_action.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/action_collection_decorator.rb" + - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/collection.rb" + - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/query.rb" + - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/schema/mongoid_schema.rb" + - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/pipeline/filter_generator.rb" + - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/collection.rb" + - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/rpc_client.rb" + - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb" + - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_pool.rb" + - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/sse_client.rb" + - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb" + - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/sse.rb" Style/OpenStructUse: Exclude: - - 'packages/forest_admin_agent/lib/forest_admin_agent/routes/resources/**/*.rb' + - "packages/forest_admin_agent/lib/forest_admin_agent/routes/resources/**/*.rb" RSpec/ExampleLength: - CountAsOne: [ 'array', 'hash', 'method_call' ] + CountAsOne: ["array", "hash", "method_call"] Max: 20 - RSpec/MultipleExpectations: Max: 15 Layout/LineLength: Max: 120 Exclude: - - 'packages/forest_admin_agent/spec/**/*' - - 'packages/forest_admin_datasource_active_record/spec/**/*' - - 'packages/forest_admin_datasource_toolkit/spec/**/*' - - 'packages/forest_admin_datasource_rpc/spec/**/*' - - 'packages/forest_admin_datasource_mongoid/spec/**/*' - - 'packages/forest_admin_datasource_customizer/spec/**/*' - - 'packages/forest_admin_rails/spec/**/*' - - 'packages/forest_admin_agent/lib/forest_admin_agent/http/forest_admin_api_requester.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/routes/resources/list.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/services/permissions.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/services/smart_action_checker.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/form_layout_element.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/override/context/create_override_customization_context.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/override/context/update_override_customization_context.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/override/context/delete_override_customization_context.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/publication/publication_datasource_decorator.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/relation/relation_collection_decorator.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/sort/sort_collection_decorator.rb' - - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/datasource.rb' - - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/schema/mongoid_schema.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/condition_tree_factory.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/utils/collection.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/validations/field_validator.rb' - - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/base_route.rb' - - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/sse.rb' + - "packages/forest_admin_agent/spec/**/*" + - "packages/forest_admin_datasource_active_record/spec/**/*" + - "packages/forest_admin_datasource_toolkit/spec/**/*" + - "packages/forest_admin_datasource_rpc/spec/**/*" + - "packages/forest_admin_datasource_mongoid/spec/**/*" + - "packages/forest_admin_datasource_customizer/spec/**/*" + - "packages/forest_admin_rails/spec/**/*" + - "packages/forest_admin_agent/lib/forest_admin_agent/http/forest_admin_api_requester.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/routes/resources/list.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/services/permissions.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/services/smart_action_checker.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/form_layout_element.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/override/context/create_override_customization_context.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/override/context/update_override_customization_context.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/override/context/delete_override_customization_context.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/publication/publication_datasource_decorator.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/relation/relation_collection_decorator.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/sort/sort_collection_decorator.rb" + - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/datasource.rb" + - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/schema/mongoid_schema.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/condition_tree_factory.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/utils/collection.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/validations/field_validator.rb" + - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/base_route.rb" + - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/sse.rb" RSpec/MultipleMemoizedHelpers: Max: 15 Security/Eval: Exclude: - - 'packages/forest_admin_agent/lib/forest_admin_agent/http/error_handling.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/services/logger_service.rb' - - 'packages/forest_admin_agent/lib/forest_admin_agent/http/error_translator.rb' + - "packages/forest_admin_agent/lib/forest_admin_agent/http/error_handling.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/services/logger_service.rb" + - "packages/forest_admin_agent/lib/forest_admin_agent/http/error_translator.rb" Lint/DuplicateBranch: Exclude: - - 'packages/forest_admin_agent/lib/forest_admin_agent/http/error_translator.rb' - - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/utils/error_handler.rb' + - "packages/forest_admin_agent/lib/forest_admin_agent/http/error_translator.rb" + - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/utils/error_handler.rb" Style/PercentLiteralDelimiters: Exclude: - - 'packages/forest_admin_rails/lib/generators/forest_admin_rails/install_generator.rb' + - "packages/forest_admin_rails/lib/generators/forest_admin_rails/install_generator.rb" Lint/InterpolationCheck: Exclude: - - 'packages/forest_admin_rails/lib/generators/forest_admin_rails/install_generator.rb' + - "packages/forest_admin_rails/lib/generators/forest_admin_rails/install_generator.rb" Lint/UnusedMethodArgument: Exclude: - - 'packages/forest_admin_rails/config/initializers/forest_admin_error_subscriber.rb' + - "packages/forest_admin_rails/config/initializers/forest_admin_error_subscriber.rb" Style/RedundantParentheses: Enabled: false Style/ClassVars: Enabled: - - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/middleware/authentication.rb' + - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/middleware/authentication.rb" Naming/PredicateMethod: Exclude: - - 'packages/forest_admin_agent/lib/forest_admin_agent/utils/query_string_parser.rb' - - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/empty/empty_collection_decorator.rb' - - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/nodes/condition_tree_leaf.rb' - - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/options_parser.rb' + - "packages/forest_admin_agent/lib/forest_admin_agent/utils/query_string_parser.rb" + - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/empty/empty_collection_decorator.rb" + - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/nodes/condition_tree_leaf.rb" + - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/options_parser.rb" From fb5f79597971b016e91dbcee5862326e4ca6eafe Mon Sep 17 00:00:00 2001 From: Arnaud Moncel Date: Mon, 26 Jan 2026 15:31:55 +0100 Subject: [PATCH 4/7] fix: review --- .rubocop.yml | 578 +++++++++--------- .../lib/forest_admin_rpc_agent/agent.rb | 6 +- .../datasource_customizer.rb | 1 - 3 files changed, 293 insertions(+), 292 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 1bc6c5ae0..41ea6784f 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -6,57 +6,57 @@ AllCops: TargetRubyVersion: 3.0 NewCops: enable Exclude: - - "packages/forest_admin_datasource_active_record/spec/dummy/**/*" - - "packages/forest_admin_datasource_mongoid/spec/dummy/**/*" - - "packages/forest_admin_agent/lib/forest_admin_agent/serializer/forest_serializer.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/serializer/forest_serializer_override.rb" - - "packages/forest_admin_rpc_agent/bin/**/*" - - "node_modules/semantic-release-rubygem/**/*" - - "packages/_examples/**/*" + - 'packages/forest_admin_datasource_active_record/spec/dummy/**/*' + - 'packages/forest_admin_datasource_mongoid/spec/dummy/**/*' + - 'packages/forest_admin_agent/lib/forest_admin_agent/serializer/forest_serializer.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/serializer/forest_serializer_override.rb' + - 'packages/forest_admin_rpc_agent/bin/**/*' + - 'node_modules/semantic-release-rubygem/**/*' + - 'packages/_examples/**/*' Gemspec/OrderedDependencies: Exclude: - - "packages/forest_admin_agent/forest_admin_agent.gemspec" - - "packages/forest_admin_rails/forest_admin_rails.gemspec" - - "packages/forest_admin_datasource_toolkit/forest_admin_datasource_toolkit.gemspec" - - "packages/forest_admin_datasource_mongoid/forest_admin_datasource_mongoid.gemspec" - - "packages/forest_admin_datasource_rpc/forest_admin_datasource_rpc.gemspec" - - "packages/forest_admin_rpc_agent/forest_admin_rpc_agent.gemspec" - - "packages/forest_admin_test_toolkit/forest_admin_test_toolkit.gemspec" - - "packages/forest_admin_datasource_customizer/forest_admin_datasource_customizer.gemspec" - - "packages/forest_admin_datasource_active_record/forest_admin_datasource_active_record.gemspec" + - 'packages/forest_admin_agent/forest_admin_agent.gemspec' + - 'packages/forest_admin_rails/forest_admin_rails.gemspec' + - 'packages/forest_admin_datasource_toolkit/forest_admin_datasource_toolkit.gemspec' + - 'packages/forest_admin_datasource_mongoid/forest_admin_datasource_mongoid.gemspec' + - 'packages/forest_admin_datasource_rpc/forest_admin_datasource_rpc.gemspec' + - 'packages/forest_admin_rpc_agent/forest_admin_rpc_agent.gemspec' + - 'packages/forest_admin_test_toolkit/forest_admin_test_toolkit.gemspec' + - 'packages/forest_admin_datasource_customizer/forest_admin_datasource_customizer.gemspec' + - 'packages/forest_admin_datasource_active_record/forest_admin_datasource_active_record.gemspec' Gemspec/RequireMFA: Exclude: - - "agent_ruby.gemspec" - - "packages/forest_admin_agent/forest_admin_agent.gemspec" - - "packages/forest_admin_rails/forest_admin_rails.gemspec" - - "packages/forest_admin_datasource_toolkit/forest_admin_datasource_toolkit.gemspec" - - "packages/forest_admin_datasource_mongoid/forest_admin_datasource_mongoid.gemspec" - - "packages/forest_admin_datasource_rpc/forest_admin_datasource_rpc.gemspec" - - "packages/forest_admin_rpc_agent/forest_admin_rpc_agent.gemspec" - - "packages/forest_admin_test_toolkit/forest_admin_test_toolkit.gemspec" - - "packages/forest_admin_datasource_customizer/forest_admin_datasource_customizer.gemspec" - - "packages/forest_admin_datasource_active_record/forest_admin_datasource_active_record.gemspec" + - 'agent_ruby.gemspec' + - 'packages/forest_admin_agent/forest_admin_agent.gemspec' + - 'packages/forest_admin_rails/forest_admin_rails.gemspec' + - 'packages/forest_admin_datasource_toolkit/forest_admin_datasource_toolkit.gemspec' + - 'packages/forest_admin_datasource_mongoid/forest_admin_datasource_mongoid.gemspec' + - 'packages/forest_admin_datasource_rpc/forest_admin_datasource_rpc.gemspec' + - 'packages/forest_admin_rpc_agent/forest_admin_rpc_agent.gemspec' + - 'packages/forest_admin_test_toolkit/forest_admin_test_toolkit.gemspec' + - 'packages/forest_admin_datasource_customizer/forest_admin_datasource_customizer.gemspec' + - 'packages/forest_admin_datasource_active_record/forest_admin_datasource_active_record.gemspec' # Offense count: 1 # This cop supports unsafe autocorrection (--autocorrect-all). Lint/PercentStringArray: Exclude: - - "packages/forest_admin_agent/forest_admin_agent.gemspec" - - "packages/forest_admin_rails/forest_admin_rails.gemspec" - - "packages/forest_admin_datasource_toolkit/forest_admin_datasource_toolkit.gemspec" - - "packages/forest_admin_datasource_mongoid/forest_admin_datasource_mongoid.gemspec" - - "packages/forest_admin_datasource_rpc/forest_admin_datasource_rpc.gemspec" - - "packages/forest_admin_rpc_agent/forest_admin_rpc_agent.gemspec" - - "packages/forest_admin_datasource_customizer/forest_admin_datasource_customizer.gemspec" - - "packages/forest_admin_datasource_active_record/forest_admin_datasource_active_record.gemspec" + - 'packages/forest_admin_agent/forest_admin_agent.gemspec' + - 'packages/forest_admin_rails/forest_admin_rails.gemspec' + - 'packages/forest_admin_datasource_toolkit/forest_admin_datasource_toolkit.gemspec' + - 'packages/forest_admin_datasource_mongoid/forest_admin_datasource_mongoid.gemspec' + - 'packages/forest_admin_datasource_rpc/forest_admin_datasource_rpc.gemspec' + - 'packages/forest_admin_rpc_agent/forest_admin_rpc_agent.gemspec' + - 'packages/forest_admin_datasource_customizer/forest_admin_datasource_customizer.gemspec' + - 'packages/forest_admin_datasource_active_record/forest_admin_datasource_active_record.gemspec' # Offense count: 1 # Configuration parameters: AllowComments. Lint/EmptyFile: Exclude: - - "packages/forest_admin_rails/app/models/forest_admin_rails/application_record.rb" + - 'packages/forest_admin_rails/app/models/forest_admin_rails/application_record.rb' Metrics/AbcSize: Enabled: false @@ -69,14 +69,14 @@ Metrics/PerceivedComplexity: Style/BlockComments: Exclude: - - "packages/forest_admin_agent/spec/spec_helper.rb" - - "packages/forest_admin_rails/spec/spec_helper.rb" - - "packages/forest_admin_datasource_toolkit/spec/spec_helper.rb" - - "packages/forest_admin_datasource_mongoid/spec/spec_helper.rb" - - "packages/forest_admin_datasource_rpc/spec/spec_helper.rb" - - "packages/forest_admin_rpc_agent/spec/spec_helper.rb" - - "packages/forest_admin_datasource_customizer/spec/spec_helper.rb" - - "packages/forest_admin_datasource_active_record/spec/spec_helper.rb" + - 'packages/forest_admin_agent/spec/spec_helper.rb' + - 'packages/forest_admin_rails/spec/spec_helper.rb' + - 'packages/forest_admin_datasource_toolkit/spec/spec_helper.rb' + - 'packages/forest_admin_datasource_mongoid/spec/spec_helper.rb' + - 'packages/forest_admin_datasource_rpc/spec/spec_helper.rb' + - 'packages/forest_admin_rpc_agent/spec/spec_helper.rb' + - 'packages/forest_admin_datasource_customizer/spec/spec_helper.rb' + - 'packages/forest_admin_datasource_active_record/spec/spec_helper.rb' # Offense count: 3 # Configuration parameters: AllowedConstants. @@ -96,17 +96,17 @@ Style/FrozenStringLiteralComment: # SupportedStyles: literals, strict Style/MutableConstant: Exclude: - - "lib/agent_ruby/version.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/version.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/schema_emitter.rb" - - "packages/forest_admin_rails/lib/forest_admin_rails/version.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/version.rb" - - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/version.rb" - - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/version.rb" - - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/version.rb" - - "packages/forest_admin_test_toolkit/lib/forest_admin_test_toolkit/version.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/version.rb" - - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/version.rb" + - 'lib/agent_ruby/version.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/version.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/schema_emitter.rb' + - 'packages/forest_admin_rails/lib/forest_admin_rails/version.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/version.rb' + - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/version.rb' + - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/version.rb' + - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/version.rb' + - 'packages/forest_admin_test_toolkit/lib/forest_admin_test_toolkit/version.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/version.rb' + - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/version.rb' # Offense count: 38 # This cop supports safe autocorrection (--autocorrect). @@ -114,79 +114,79 @@ Style/MutableConstant: # SupportedStyles: single_quotes, double_quotes Style/StringLiterals: Exclude: - - "agent_ruby.gemspec" - - "Gemfile" - - "Rakefile" - - "bin/console" - - "lib/agent_ruby.rb" - - "lib/agent_ruby/version.rb" - - "packages/forest_admin_agent/forest_admin_agent.gemspec" - - "packages/forest_admin_agent/Gemfile" - - "packages/forest_admin_agent/Rakefile" - - "packages/forest_admin_agent/bin/console" - - "packages/forest_admin_agent/lib/forest_admin_agent.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/version.rb" - - "packages/forest_admin_agent/spec/forest_admin_agent_spec.rb" - - "packages/forest_admin_agent/spec/spec_helper.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/schema_emitter.rb" - - "packages/forest_admin_rails/forest_admin_rails.gemspec" - - "packages/forest_admin_rails/Gemfile" - - "packages/forest_admin_rails/Rakefile" - - "packages/forest_admin_rails/bin/console" - - "packages/forest_admin_rails/bin/rails" - - "packages/forest_admin_rails/lib/forest_admin_rails.rb" - - "packages/forest_admin_rails/lib/forest_admin_rails/version.rb" - - "packages/forest_admin_rails/spec/rails_helper.rb" - - "packages/forest_admin_rails/spec/spec_helper.rb" - - "packages/forest_admin_datasource_toolkit/forest_admin_datasource_toolkit.gemspec" - - "packages/forest_admin_datasource_toolkit/Gemfile" - - "packages/forest_admin_datasource_toolkit/Rakefile" - - "packages/forest_admin_datasource_toolkit/bin/console" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/version.rb" - - "packages/forest_admin_datasource_toolkit/spec/spec_helper.rb" - - "packages/forest_admin_datasource_mongoid/forest_admin_datasource_mongoid.gemspec" - - "packages/forest_admin_datasource_mongoid/Gemfile" - - "packages/forest_admin_datasource_mongoid/Rakefile" - - "packages/forest_admin_datasource_mongoid/bin/console" - - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid.rb" - - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/version.rb" - - "packages/forest_admin_datasource_mongoid/spec/spec_helper.rb" - - "packages/forest_admin_datasource_rpc/forest_admin_datasource_rpc.gemspec" - - "packages/forest_admin_datasource_rpc/Gemfile" - - "packages/forest_admin_datasource_rpc/Rakefile" - - "packages/forest_admin_datasource_rpc/bin/console" - - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc.rb" - - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/version.rb" - - "packages/forest_admin_datasource_rpc/spec/spec_helper.rb" - - "packages/forest_admin_rpc_agent/forest_admin_rpc_agent.gemspec" - - "packages/forest_admin_rpc_agent/Gemfile" - - "packages/forest_admin_rpc_agent/Rakefile" - - "packages/forest_admin_rpc_agent/bin/console" - - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent.rb" - - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/version.rb" - - "packages/forest_admin_rpc_agent/spec/spec_helper.rb" - - "packages/forest_admin_test_toolkit/forest_admin_test_toolkit.gemspec" - - "packages/forest_admin_test_toolkit/Gemfile" - - "packages/forest_admin_test_toolkit/Rakefile" - - "packages/forest_admin_test_toolkit/bin/console" - - "packages/forest_admin_test_toolkit/lib/forest_admin_test_toolkit.rb" - - "packages/forest_admin_test_toolkit/lib/forest_admin_test_toolkit/version.rb" - - "packages/forest_admin_test_toolkit/spec/spec_helper.rb" - - "packages/forest_admin_datasource_customizer/forest_admin_datasource_customizer.gemspec" - - "packages/forest_admin_datasource_customizer/Gemfile" - - "packages/forest_admin_datasource_customizer/Rakefile" - - "packages/forest_admin_datasource_customizer/bin/console" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/version.rb" - - "packages/forest_admin_datasource_customizer/spec/spec_helper.rb" - - "packages/forest_admin_datasource_active_record/forest_admin_datasource_active_record.gemspec" - - "packages/forest_admin_datasource_active_record/Gemfile" - - "packages/forest_admin_datasource_active_record/Rakefile" - - "packages/forest_admin_datasource_active_record/bin/console" - - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record.rb" - - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/version.rb" - - "packages/forest_admin_datasource_active_record/spec/spec_helper.rb" + - 'agent_ruby.gemspec' + - 'Gemfile' + - 'Rakefile' + - 'bin/console' + - 'lib/agent_ruby.rb' + - 'lib/agent_ruby/version.rb' + - 'packages/forest_admin_agent/forest_admin_agent.gemspec' + - 'packages/forest_admin_agent/Gemfile' + - 'packages/forest_admin_agent/Rakefile' + - 'packages/forest_admin_agent/bin/console' + - 'packages/forest_admin_agent/lib/forest_admin_agent.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/version.rb' + - 'packages/forest_admin_agent/spec/forest_admin_agent_spec.rb' + - 'packages/forest_admin_agent/spec/spec_helper.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/schema_emitter.rb' + - 'packages/forest_admin_rails/forest_admin_rails.gemspec' + - 'packages/forest_admin_rails/Gemfile' + - 'packages/forest_admin_rails/Rakefile' + - 'packages/forest_admin_rails/bin/console' + - 'packages/forest_admin_rails/bin/rails' + - 'packages/forest_admin_rails/lib/forest_admin_rails.rb' + - 'packages/forest_admin_rails/lib/forest_admin_rails/version.rb' + - 'packages/forest_admin_rails/spec/rails_helper.rb' + - 'packages/forest_admin_rails/spec/spec_helper.rb' + - 'packages/forest_admin_datasource_toolkit/forest_admin_datasource_toolkit.gemspec' + - 'packages/forest_admin_datasource_toolkit/Gemfile' + - 'packages/forest_admin_datasource_toolkit/Rakefile' + - 'packages/forest_admin_datasource_toolkit/bin/console' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/version.rb' + - 'packages/forest_admin_datasource_toolkit/spec/spec_helper.rb' + - 'packages/forest_admin_datasource_mongoid/forest_admin_datasource_mongoid.gemspec' + - 'packages/forest_admin_datasource_mongoid/Gemfile' + - 'packages/forest_admin_datasource_mongoid/Rakefile' + - 'packages/forest_admin_datasource_mongoid/bin/console' + - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid.rb' + - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/version.rb' + - 'packages/forest_admin_datasource_mongoid/spec/spec_helper.rb' + - 'packages/forest_admin_datasource_rpc/forest_admin_datasource_rpc.gemspec' + - 'packages/forest_admin_datasource_rpc/Gemfile' + - 'packages/forest_admin_datasource_rpc/Rakefile' + - 'packages/forest_admin_datasource_rpc/bin/console' + - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc.rb' + - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/version.rb' + - 'packages/forest_admin_datasource_rpc/spec/spec_helper.rb' + - 'packages/forest_admin_rpc_agent/forest_admin_rpc_agent.gemspec' + - 'packages/forest_admin_rpc_agent/Gemfile' + - 'packages/forest_admin_rpc_agent/Rakefile' + - 'packages/forest_admin_rpc_agent/bin/console' + - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent.rb' + - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/version.rb' + - 'packages/forest_admin_rpc_agent/spec/spec_helper.rb' + - 'packages/forest_admin_test_toolkit/forest_admin_test_toolkit.gemspec' + - 'packages/forest_admin_test_toolkit/Gemfile' + - 'packages/forest_admin_test_toolkit/Rakefile' + - 'packages/forest_admin_test_toolkit/bin/console' + - 'packages/forest_admin_test_toolkit/lib/forest_admin_test_toolkit.rb' + - 'packages/forest_admin_test_toolkit/lib/forest_admin_test_toolkit/version.rb' + - 'packages/forest_admin_test_toolkit/spec/spec_helper.rb' + - 'packages/forest_admin_datasource_customizer/forest_admin_datasource_customizer.gemspec' + - 'packages/forest_admin_datasource_customizer/Gemfile' + - 'packages/forest_admin_datasource_customizer/Rakefile' + - 'packages/forest_admin_datasource_customizer/bin/console' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/version.rb' + - 'packages/forest_admin_datasource_customizer/spec/spec_helper.rb' + - 'packages/forest_admin_datasource_active_record/forest_admin_datasource_active_record.gemspec' + - 'packages/forest_admin_datasource_active_record/Gemfile' + - 'packages/forest_admin_datasource_active_record/Rakefile' + - 'packages/forest_admin_datasource_active_record/bin/console' + - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record.rb' + - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/version.rb' + - 'packages/forest_admin_datasource_active_record/spec/spec_helper.rb' # Offense count: 1 # This cop supports safe autocorrection (--autocorrect). @@ -198,7 +198,7 @@ Style/WordArray: Style/SymbolArray: Exclude: - - "packages/forest_admin_agent/spec/lib/forest_admin_agent/utils/schema/generator_field_many_to_many_spec.rb" + - 'packages/forest_admin_agent/spec/lib/forest_admin_agent/utils/schema/generator_field_many_to_many_spec.rb' Style/StringLiteralsInInterpolation: Enabled: true @@ -206,231 +206,233 @@ Style/StringLiteralsInInterpolation: Style/RedundantConstantBase: Exclude: - - "packages/forest_admin_rails/spec/rails_helper.rb" + - 'packages/forest_admin_rails/spec/rails_helper.rb' Style/HashEachMethods: Exclude: - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/condition_tree_factory.rb" + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/condition_tree_factory.rb' Lint/NestedMethodDefinition: Exclude: - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb" + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb' Performance/CollectionLiteralInLoop: Exclude: - - "packages/forest_admin_agent/lib/forest_admin_agent/utils/condition_tree_parser.rb" + - 'packages/forest_admin_agent/lib/forest_admin_agent/utils/condition_tree_parser.rb' Naming/PredicatePrefix: Exclude: - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/collection.rb" + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/collection.rb' Metrics/ParameterLists: Exclude: - - "packages/forest_admin_agent/lib/forest_admin_agent/routes/query_handler.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/services/smart_action_checker.rb" - - "packages/forest_admin_agent/spec/lib/forest_admin_agent/routes/resources/related/list_related_spec.rb" - - "packages/forest_admin_agent/spec/lib/forest_admin_agent/routes/resources/related/count_related_spec.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/context/action_context.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/action_collection_decorator.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/dynamic_field.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/hook/context/after/hook_after_aggregate_context.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/dsl/builders/form_builder.rb" - - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/datasource.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/schema/relations/many_to_many_schema.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/schema/column_schema.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/caller.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/utils/collection.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/action_field.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/actions/action_field.rb" + - 'packages/forest_admin_agent/lib/forest_admin_agent/routes/query_handler.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/services/smart_action_checker.rb' + - 'packages/forest_admin_agent/spec/lib/forest_admin_agent/routes/resources/related/list_related_spec.rb' + - 'packages/forest_admin_agent/spec/lib/forest_admin_agent/routes/resources/related/count_related_spec.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/context/action_context.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/action_collection_decorator.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/dynamic_field.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/hook/context/after/hook_after_aggregate_context.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/dsl/builders/form_builder.rb' + - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/datasource.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/schema/relations/many_to_many_schema.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/schema/column_schema.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/caller.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/utils/collection.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/action_field.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/actions/action_field.rb' Metrics/ModuleLength: - CountAsOne: ["array", "hash", "method_call"] + CountAsOne: [ 'array', 'hash', 'method_call' ] Exclude: - - "packages/forest_admin_agent/spec/**/*" - - "packages/forest_admin_datasource_active_record/spec/**/*" - - "packages/forest_admin_datasource_toolkit/spec/**/*" - - "packages/forest_admin_datasource_rpc/spec/**/*" - - "packages/forest_admin_datasource_mongoid/spec/**/*" - - "packages/forest_admin_datasource_customizer/spec/**/*" - - "packages/forest_admin_rails/spec/**/*" - - "packages/forest_admin_rpc_agent/spec/**/*" - - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/helpers.rb" + - 'packages/forest_admin_agent/spec/**/*' + - 'packages/forest_admin_datasource_active_record/spec/**/*' + - 'packages/forest_admin_datasource_toolkit/spec/**/*' + - 'packages/forest_admin_datasource_rpc/spec/**/*' + - 'packages/forest_admin_datasource_mongoid/spec/**/*' + - 'packages/forest_admin_datasource_customizer/spec/**/*' + - 'packages/forest_admin_rails/spec/**/*' + - 'packages/forest_admin_rpc_agent/spec/**/*' + - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/helpers.rb' Metrics/MethodLength: - CountAsOne: ["array", "hash", "method_call"] + CountAsOne: ['array', 'hash', 'method_call'] Max: 20 Exclude: - - "packages/forest_admin_agent/lib/forest_admin_agent/auth/oauth2/forest_provider.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/builder/agent_factory.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/http/error_translator.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/routes/charts/charts.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/serializer/json_api_serializer.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/services/smart_action_checker.rb" - - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/parser/validation.rb" - - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/collection.rb" - - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/utils/query.rb" - - "packages/forest_admin_datasource_active_record/spec/dummy/**/*" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/computed/utils/flattener.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/decorators_stack.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/publication/publication_collection_decorator.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/search/search_collection_decorator.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/write/write_replace/write_replace_collection_decorator.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/plugins/import_field.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/collection.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/condition_tree_factory.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/nodes/condition_tree_leaf.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/condition_tree_equivalent.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/validations/field_validator.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/actions/action_field_factory.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/base_action.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/rename_field/rename_field_collection_decorator.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/action_collection_decorator.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/form_factory.rb" - - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/collection.rb" - - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/query.rb" - - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/schema/fields_generator.rb" - - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/schema/mongoid_schema.rb" - - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/pipeline/filter_generator.rb" - - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/pipeline/lookup_generator.rb" - - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/collection.rb" - - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc.rb" - - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/sse_client.rb" - - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb" - - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/sse.rb" - - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/http/router.rb" + - 'packages/forest_admin_agent/lib/forest_admin_agent/auth/oauth2/forest_provider.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/builder/agent_factory.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/http/error_translator.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/routes/charts/charts.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/serializer/json_api_serializer.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/services/smart_action_checker.rb' + - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/parser/validation.rb' + - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/collection.rb' + - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/utils/query.rb' + - 'packages/forest_admin_datasource_active_record/spec/dummy/**/*' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/computed/utils/flattener.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/decorators_stack.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/publication/publication_collection_decorator.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/search/search_collection_decorator.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/write/write_replace/write_replace_collection_decorator.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/plugins/import_field.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/collection.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/condition_tree_factory.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/nodes/condition_tree_leaf.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/condition_tree_equivalent.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/validations/field_validator.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/actions/action_field_factory.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/base_action.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/rename_field/rename_field_collection_decorator.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/action_collection_decorator.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/form_factory.rb' + - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/collection.rb' + - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/query.rb' + - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/schema/fields_generator.rb' + - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/schema/mongoid_schema.rb' + - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/pipeline/filter_generator.rb' + - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/pipeline/lookup_generator.rb' + - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/collection.rb' + - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc.rb' + - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/sse_client.rb' + - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb' + - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/sse.rb' + - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/http/router.rb' + Metrics/BlockLength: Exclude: - - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/collection.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/base_action.rb" - - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/collection.rb" - - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/sse.rb" - - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/http/router.rb" + - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/collection.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/base_action.rb' + - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/collection.rb' + - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/sse.rb' + - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/http/router.rb' Metrics/ClassLength: Exclude: - - "packages/forest_admin_agent/lib/forest_admin_agent/builder/agent_factory.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/generator_field.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/routes/charts/charts.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/routes/action/actions.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/routes/resources/related/dissociate_related.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/routes/resources/related/update_related.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/services/permissions.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/services/smart_action_checker.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/frontend_validation_utils.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/utils/query_string_parser.rb" - - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/utils/query.rb" - - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/collection.rb" - - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/datasource.rb" - - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/utils/query_aggregate.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/collection_customizer.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/binary/binary_collection_decorator.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/search/search_collection_decorator.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/relation/relation_collection_decorator.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/rename_collection/rename_collection_decorator.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/rename_field/rename_field_collection_decorator.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/utils/collection.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/aggregation.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/nodes/condition_tree_leaf.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/transforms/comparisons.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/validations/rules.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/generator_action_field_widget.rb" - - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/collection.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/generator_action.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/action_collection_decorator.rb" - - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/collection.rb" - - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/query.rb" - - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/schema/mongoid_schema.rb" - - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/pipeline/filter_generator.rb" - - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/collection.rb" - - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/rpc_client.rb" - - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb" - - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_pool.rb" - - "packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/sse_client.rb" - - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb" - - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/sse.rb" + - 'packages/forest_admin_agent/lib/forest_admin_agent/builder/agent_factory.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/generator_field.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/routes/charts/charts.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/routes/action/actions.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/routes/resources/related/dissociate_related.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/routes/resources/related/update_related.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/services/permissions.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/services/smart_action_checker.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/frontend_validation_utils.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/utils/query_string_parser.rb' + - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/utils/query.rb' + - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/collection.rb' + - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/datasource.rb' + - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/utils/query_aggregate.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/collection_customizer.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/binary/binary_collection_decorator.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/search/search_collection_decorator.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/relation/relation_collection_decorator.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/rename_collection/rename_collection_decorator.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/rename_field/rename_field_collection_decorator.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/utils/collection.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/aggregation.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/nodes/condition_tree_leaf.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/transforms/comparisons.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/validations/rules.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/generator_action_field_widget.rb' + - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/collection.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/utils/schema/generator_action.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/action_collection_decorator.rb' + - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/collection.rb' + - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/query.rb' + - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/schema/mongoid_schema.rb' + - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/pipeline/filter_generator.rb' + - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/collection.rb' + - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/rpc_client.rb' + - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_client.rb' + - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/schema_polling_pool.rb' + - 'packages/forest_admin_datasource_rpc/lib/forest_admin_datasource_rpc/Utils/sse_client.rb' + - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/sse.rb' + - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb' Style/OpenStructUse: Exclude: - - "packages/forest_admin_agent/lib/forest_admin_agent/routes/resources/**/*.rb" + - 'packages/forest_admin_agent/lib/forest_admin_agent/routes/resources/**/*.rb' RSpec/ExampleLength: - CountAsOne: ["array", "hash", "method_call"] + CountAsOne: [ 'array', 'hash', 'method_call' ] Max: 20 + RSpec/MultipleExpectations: Max: 15 Layout/LineLength: Max: 120 Exclude: - - "packages/forest_admin_agent/spec/**/*" - - "packages/forest_admin_datasource_active_record/spec/**/*" - - "packages/forest_admin_datasource_toolkit/spec/**/*" - - "packages/forest_admin_datasource_rpc/spec/**/*" - - "packages/forest_admin_datasource_mongoid/spec/**/*" - - "packages/forest_admin_datasource_customizer/spec/**/*" - - "packages/forest_admin_rails/spec/**/*" - - "packages/forest_admin_agent/lib/forest_admin_agent/http/forest_admin_api_requester.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/routes/resources/list.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/services/permissions.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/services/smart_action_checker.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/form_layout_element.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/override/context/create_override_customization_context.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/override/context/update_override_customization_context.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/override/context/delete_override_customization_context.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/publication/publication_datasource_decorator.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/relation/relation_collection_decorator.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/sort/sort_collection_decorator.rb" - - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/datasource.rb" - - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/schema/mongoid_schema.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/condition_tree_factory.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/utils/collection.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/validations/field_validator.rb" - - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/base_route.rb" - - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/sse.rb" + - 'packages/forest_admin_agent/spec/**/*' + - 'packages/forest_admin_datasource_active_record/spec/**/*' + - 'packages/forest_admin_datasource_toolkit/spec/**/*' + - 'packages/forest_admin_datasource_rpc/spec/**/*' + - 'packages/forest_admin_datasource_mongoid/spec/**/*' + - 'packages/forest_admin_datasource_customizer/spec/**/*' + - 'packages/forest_admin_rails/spec/**/*' + - 'packages/forest_admin_agent/lib/forest_admin_agent/http/forest_admin_api_requester.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/routes/resources/list.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/services/permissions.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/services/smart_action_checker.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/action/form_layout_element.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/override/context/create_override_customization_context.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/override/context/update_override_customization_context.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/override/context/delete_override_customization_context.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/publication/publication_datasource_decorator.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/relation/relation_collection_decorator.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/sort/sort_collection_decorator.rb' + - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/datasource.rb' + - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/utils/schema/mongoid_schema.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/condition_tree_factory.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/utils/collection.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/filter_factory.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/validations/field_validator.rb' + - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/base_route.rb' + - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/routes/sse.rb' RSpec/MultipleMemoizedHelpers: Max: 15 Security/Eval: Exclude: - - "packages/forest_admin_agent/lib/forest_admin_agent/http/error_handling.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/services/logger_service.rb" - - "packages/forest_admin_agent/lib/forest_admin_agent/http/error_translator.rb" + - 'packages/forest_admin_agent/lib/forest_admin_agent/http/error_handling.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/services/logger_service.rb' + - 'packages/forest_admin_agent/lib/forest_admin_agent/http/error_translator.rb' Lint/DuplicateBranch: Exclude: - - "packages/forest_admin_agent/lib/forest_admin_agent/http/error_translator.rb" - - "packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/utils/error_handler.rb" + - 'packages/forest_admin_agent/lib/forest_admin_agent/http/error_translator.rb' + - 'packages/forest_admin_datasource_active_record/lib/forest_admin_datasource_active_record/utils/error_handler.rb' Style/PercentLiteralDelimiters: Exclude: - - "packages/forest_admin_rails/lib/generators/forest_admin_rails/install_generator.rb" + - 'packages/forest_admin_rails/lib/generators/forest_admin_rails/install_generator.rb' Lint/InterpolationCheck: Exclude: - - "packages/forest_admin_rails/lib/generators/forest_admin_rails/install_generator.rb" + - 'packages/forest_admin_rails/lib/generators/forest_admin_rails/install_generator.rb' Lint/UnusedMethodArgument: Exclude: - - "packages/forest_admin_rails/config/initializers/forest_admin_error_subscriber.rb" + - 'packages/forest_admin_rails/config/initializers/forest_admin_error_subscriber.rb' Style/RedundantParentheses: Enabled: false Style/ClassVars: Enabled: - - "packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/middleware/authentication.rb" + - 'packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/middleware/authentication.rb' Naming/PredicateMethod: Exclude: - - "packages/forest_admin_agent/lib/forest_admin_agent/utils/query_string_parser.rb" - - "packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/empty/empty_collection_decorator.rb" - - "packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/nodes/condition_tree_leaf.rb" - - "packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/options_parser.rb" + - 'packages/forest_admin_agent/lib/forest_admin_agent/utils/query_string_parser.rb' + - 'packages/forest_admin_datasource_customizer/lib/forest_admin_datasource_customizer/decorators/empty/empty_collection_decorator.rb' + - 'packages/forest_admin_datasource_toolkit/lib/forest_admin_datasource_toolkit/components/query/condition_tree/nodes/condition_tree_leaf.rb' + - 'packages/forest_admin_datasource_mongoid/lib/forest_admin_datasource_mongoid/options_parser.rb' diff --git a/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb b/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb index 0dea3314c..76b72fd19 100644 --- a/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb +++ b/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb @@ -16,15 +16,15 @@ def setup(options) end def add_datasource(datasource, options = {}) - mark_collections_as_rpc = nil + mark_collections_callback = nil if options[:mark_collections_as_rpc] - mark_collections_as_rpc = lambda { |builded_datasource| + mark_collections_callback = lambda { |builded_datasource| mark_collections_as_rpc(*builded_datasource.collections.keys) } end - @customizer.add_datasource(datasource, options, mark_collections_as_rpc) + @customizer.add_datasource(datasource, options, mark_collections_callback) self end diff --git a/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/datasource_customizer.rb b/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/datasource_customizer.rb index 219eb5af9..bd124a33f 100644 --- a/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/datasource_customizer.rb +++ b/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/datasource_customizer.rb @@ -1,7 +1,6 @@ module ForestAdminRpcAgent class DatasourceCustomizer < ForestAdminDatasourceCustomizer::DatasourceCustomizer def add_datasource(datasource, options, mark_collections_as_rpc) - puts mark_collections_as_rpc @stack.queue_customization(lambda { if options[:include] || options[:exclude] publication_decorator = Decorators::Publication::PublicationDatasourceDecorator.new(datasource) From 224d01840f66a53232e2e38a8e9d3bb9f18b8a20 Mon Sep 17 00:00:00 2001 From: Arnaud Moncel Date: Mon, 26 Jan 2026 15:42:57 +0100 Subject: [PATCH 5/7] fix: review --- .../lib/forest_admin_rpc_agent/agent.rb | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb b/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb index 76b72fd19..30c5e751c 100644 --- a/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb +++ b/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb @@ -16,13 +16,9 @@ def setup(options) end def add_datasource(datasource, options = {}) - mark_collections_callback = nil - - if options[:mark_collections_as_rpc] - mark_collections_callback = lambda { |builded_datasource| - mark_collections_as_rpc(*builded_datasource.collections.keys) - } - end + mark_collections_callback = if options[:mark_collections_as_rpc] + ->(ds) { mark_collections_as_rpc(*ds.collections.keys) } + end @customizer.add_datasource(datasource, options, mark_collections_callback) From 97934b9156e882b311eaad09c7f9044fc1f25874 Mon Sep 17 00:00:00 2001 From: Arnaud Moncel Date: Mon, 26 Jan 2026 16:09:08 +0100 Subject: [PATCH 6/7] fix: review --- .../lib/forest_admin_rpc_agent/agent.rb | 10 ++++------ .../forest_admin_rpc_agent/datasource_customizer.rb | 4 ++-- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb b/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb index 30c5e751c..f3ffd6227 100644 --- a/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb +++ b/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb @@ -16,13 +16,11 @@ def setup(options) end def add_datasource(datasource, options = {}) - mark_collections_callback = if options[:mark_collections_as_rpc] - ->(ds) { mark_collections_as_rpc(*ds.collections.keys) } - end - - @customizer.add_datasource(datasource, options, mark_collections_callback) + if options[:mark_collections_as_rpc] + options[:mark_collections_callback] = ->(ds) { mark_collections_as_rpc(*ds.collections.keys) } + end - self + super(datasource, options) end def send_schema(force: false) diff --git a/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/datasource_customizer.rb b/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/datasource_customizer.rb index bd124a33f..e11f6752f 100644 --- a/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/datasource_customizer.rb +++ b/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/datasource_customizer.rb @@ -1,6 +1,6 @@ module ForestAdminRpcAgent class DatasourceCustomizer < ForestAdminDatasourceCustomizer::DatasourceCustomizer - def add_datasource(datasource, options, mark_collections_as_rpc) + def add_datasource(datasource, options) @stack.queue_customization(lambda { if options[:include] || options[:exclude] publication_decorator = Decorators::Publication::PublicationDatasourceDecorator.new(datasource) @@ -16,7 +16,7 @@ def add_datasource(datasource, options, mark_collections_as_rpc) datasource = rename_collection_decorator end - mark_collections_as_rpc&.call(datasource) + options[:mark_collections_callback]&.call(datasource) @composite_datasource.add_data_source(datasource) }) From 937fcaa72e018847ee72ac9d7b99230ececc0787 Mon Sep 17 00:00:00 2001 From: Arnaud Moncel Date: Mon, 26 Jan 2026 16:13:20 +0100 Subject: [PATCH 7/7] fix: lint --- .../forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb b/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb index f3ffd6227..99883f0ba 100644 --- a/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb +++ b/packages/forest_admin_rpc_agent/lib/forest_admin_rpc_agent/agent.rb @@ -20,7 +20,7 @@ def add_datasource(datasource, options = {}) options[:mark_collections_callback] = ->(ds) { mark_collections_as_rpc(*ds.collections.keys) } end - super(datasource, options) + super end def send_schema(force: false)