From bdb877b932d591acd24c485902b20d4c34677aac Mon Sep 17 00:00:00 2001 From: Scott Dugas Date: Mon, 20 Apr 2026 13:26:55 -0400 Subject: [PATCH] Join two unjoined futures in FDBRecordStoreRepairHeaderTest I noticed some rare flakiness in repairWithIndexes, and have not been able to reproduce, but noticed these two spots where futures were not joined which could have been the cause. --- .../provider/foundationdb/FDBRecordStoreRepairHeaderTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fdb-record-layer-core/src/test/java/com/apple/foundationdb/record/provider/foundationdb/FDBRecordStoreRepairHeaderTest.java b/fdb-record-layer-core/src/test/java/com/apple/foundationdb/record/provider/foundationdb/FDBRecordStoreRepairHeaderTest.java index 7b64786dcb..d90f954336 100644 --- a/fdb-record-layer-core/src/test/java/com/apple/foundationdb/record/provider/foundationdb/FDBRecordStoreRepairHeaderTest.java +++ b/fdb-record-layer-core/src/test/java/com/apple/foundationdb/record/provider/foundationdb/FDBRecordStoreRepairHeaderTest.java @@ -671,7 +671,7 @@ void repairWithIndexes(final DisableIndexBehavior disableIndexBehavior) { assertThat(recordStore.getAllIndexStates().values()) .contains(IndexState.READABLE); for (final Index index : toRebuild) { - recordStore.markIndexDisabled(index); + recordStore.markIndexDisabled(index).join(); } } else { assertAllIndexStates(recordStore, IndexState.DISABLED); @@ -806,7 +806,7 @@ private void validateRepaired(final FormatVersion newFormatVersion, final Record private static void disableAllIndexesAndClearLock(final FDBRecordStore recordStore) { recordStore.getAllIndexStates().forEach((index, indexState) -> recordStore.markIndexDisabled(index).join()); - recordStore.clearStoreLockStateAsync(); + recordStore.clearStoreLockStateAsync().join(); } private void validateRecords(final List> records, final FDBRecordStoreBase recordStore) {