fix: avoid nested tokio runtime panic in --reuse flag#54
Open
hossihub wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
--reuseflag inmcp-httppanics with a tokio async runtime error:This happens because
try_acquire_port_lockcreates a newtokio::runtime::Builder::new_current_thread()while already running inside the main tokio runtime (theserve_httpasync function).Fix
Replaced the manual runtime creation with
crate::runtime::run_blocking(), which safely handles both contexts:block_in_placewhen already inside a tokio runtimeOnceLockruntime when notThis is the same pattern already used throughout the codebase (orchestrator cache, graph query, web handlers, etc.).
Verification
cargo build --release— cleancargo clippy— no warnings onsrc/mcp/server.rsmcp-http --reusedetects existing server and exits cleanly (code 0), no panic