fix: avoid absolutizing graph query paths in HTTP MCP#56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file,doc,path, andfiles[]arguments to absolute paths for ALL toolsget_context,search_code,find_functionto hang on large graphs because the BE graph stores paths as project-relative values (e.g.,./platform-core/...)mcp_index,mcp_index_docs,mcp_init,detect_changes)Root Cause
When
?project=/Users/linh/doan/work/bewas in the URL, the server was resolving:./platform-core/...→/Users/linh.doan/work/be/platform-core/...Graph queries then failed to find these absolute paths and fell back to expensive scans.
Test plan
cargo test test_project_routing_only_absolutizes_filesystem_toolscargo test mcp_servermcp_hello✓mcp_status✓search_code✓find_function✓query_file✓get_context✓ (no longer hangs)mcp_index✓ (accepts project-relative path)