[Bug]: "Hide videos from channels" doesn't work for collab videos

[Winterhuman]

Guidelines

• I have encountered this bug in the latest release of FreeTube.
• I have encountered this bug in the official downloads of FreeTube.
• I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
• I have searched the documentation for information that matches the description of the bug I want to file, without success.
• This issue contains only one bug.
• I have read and agree to follow the rules.

Describe the bug

1. See a video with multiple authors (aka. collaborators) in the "Up Next" section of another video, such as this collab video: https://youtu.be/YRmrjNGWM2Q
2. Add one of the collaborators to the "Hide videos from channels" list.
3. Refresh the page, but notice that the video is still shown in "Up Next".
   • Also, the associated "Show channel" and other buttons in the three-dots menu are missing, though it could be argued this is better than showing a button for each individual channel; may need some UX tweaks to handle this case.

Expected Behavior

If one or more of the collaborators of a video are in the "Hide videos from channels" list, hide the video. It may be worth adding a toggle for whether all collaborators need to be in the list, but, that could be left out for when someone opens a feature request for it.

Issue Labels

feature stopped working, API issue

FreeTube Version

v0.23.7

Operating System Version

Arch Linux

Installation Method

Flathub

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

None

Additional Information

It was cool to see that FreeTube could handle those videos in the first place. Great work on making it robust like that!

Nightly Build

• I have encountered this bug in the latest nightly build.

[absidue]

It was cool to see that FreeTube could handle those videos in the first place. Great work on making it robust like that!

The reason it mostly works is because those videos still only belong to one channel, the one listed first (you'll notice they don't show up in the videos channel tab of the other channels in the list). If you visit the video on the YouTube mobile website it also only shows the uploader, not the extra collaborators.

[Winterhuman]

Huh, that's even stranger then. If I have the channel the video belongs to in the list, the video still shows up in "Up Next" for me

[efb4f5ff-1298-471a-8973-3d47447115dc]

If one or more of the collaborators of a video are in the "Hide videos from channels" list, hide the video

we wont be doing this but we will keep this open as the main uploader doesnt get blocked properly on these types of videos

[Shadorc]

Hide videos from channels setting works by comparing the author ID of a video with the setting list.
However, when a video is a collab, its authorId is sometimes (and probably always) undefined.
It could be an issue with youtube.js parsing, but I really doubt it. In YouTube, collabs don't have a clickable author, meaning no href, and thus no id.

A solution could be to compare against the author field, which is the visible string ("KSI and 2 more", "KSI and MrBeast"...)
There are several issues with this:

• It relies on string parsing to extract the original author, but a channel could be named "Tom and Jerry". I didn't find any example of this but, if I get the logic right, it could lead to a collab video potentially being "Tom and Jerry and Jack and Dexter". In this scenario, extracting the original author name becomes harder and would rely on a lot of assumptions.
• Hide videos from channels setting contains the name of the channel, but it is stored once and never updated. Relying on the author name would mean that it will break if the channel is renamed.

I don't have any satisfying solution regarding those issues.

[dfgshdsfh]

Ah, so that's why I can't hide this shit. Here's a screenshot example to maby help others realize this is their issue:

[Shadorc]

I've found a way to get the list of collaborators from a video, and thus find the original author.
That implies relying on youtube.js raw author payload, which seems like a hack.
Maybe youtube.js does not support this field yet and a MR should be made before trying to implement it in FreeTube.

Using search query as an example, performing local#getLocalSearchResults returns an array containing the list of collaborators.

This field is under author.endpoint.payload.panelLoadingStrategy.inlineContent.dialogViewModel.customContent.listViewModel.listItems[].listItemViewModel.title.content

This is the raw representation of what is displayed in YouTube when clicking on the author name.