[Bug]: Default Viewing Mode: Fullscreen doesnt work with pasted Links after the first one

[Zwennsn]

Guidelines

• I have encountered this bug in the latest release of FreeTube.
• I have encountered this bug in the official downloads of FreeTube. The only official downloads are from the https://freetubeapp.io website, the FreeTubeApp/FreeTube GitHub repository and the io.freetubeapp.FreeTube flatpak from Flathub.
• I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
• I have searched the documentation for information that matches the description of the bug I want to file, without success.
• This issue contains only one bug.
• I have read and agree to follow the rules.

Describe the bug

1. Open FreeTube
2. Set Settings --> Player --> Default Viewing Mode: Full Screen (Start Videos Automaticly is also enabled)
3. Paste a link to a Youtube video in the search bar
4. Hit enter
5. Full Screen will automaticly be activated
6. Exit Full Screen (with f or ESC)
7. In the search bar click on the x to clear the input
8. Paste a link to a different Youtube video in the search bar
9. Hit enter
10. It wont trigger Full Screen

This behavior also happens when deactivating Settings --> General --> OpenURLs Passed to FreeTube in a New Window and passing a second video to FreeTube with the browser extension.

Expected Behavior

I would expect FreeTube to go into Full Screen mode every time on consecutive videos opened with a direct link.
Default Viewing mode Full Screen works on consecutive videos when searching Youtube via the search bar and starting videos from search results.

Issue Labels

inconsistent behavior, usability issue

FreeTube Version

v0.24.1 Beta

Operating System Version

Fedora Workstation 44 / Gnome

Installation Method

Flathub

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Upload screenshots or videos

No response

Additional Information

I Love FreeTube. Thanks for the great work.

Nightly Build

• I have encountered this bug in the latest official nightly build, do not check this box if you are using an unofficial or custom build.

[ozrendev]

This seems to also effect Theater, Full Window, Full Screen and Picture in Picture when navigating via URL or "Up Next" videos.

When a video ends and destroyPlayer is called, it remembers the last state of the window and uses that for the next video being played. This makes sense if your Default Viewing Mode is set as Default and you want to watch a whole playlist in full screen (or other view). But with Full Screen selected, since you need to exit full screen to manually play another video, it could be assumed that all videos should be started in full screen? Although you could make that same argument for the rest of the default views.

I feel like the last video state should only be remembered if 'Default' is the selected mode and the other options are explicit overrides. But then again surely this has other consequences I haven't thought of.

[Zwennsn]

Thanks for your reply. I feel like that overwriting would be consistent and expected behavior. Consequences... Yeah ^^

I just wanted to point out, that when exiting Full screen and starting a video from search results freetube will successfully apply full screen mode (when chosen as default viewing mode). So something must be handled differently by freetube compared to just pasting the url. Because the last state of the window would also not have been full screen.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Hmm interesting @ozrendev you are correct with your analysis. Its currently behaving like its the same watch session and thats why it doesnt reset back to fullscreen. In my mind this specific case should warrant a reset to default behavior, not sure if possible though

@absidue @PikachuEXE thoughts?

[PikachuEXE]

The question seems to be
If staying inside watch page, should current state be persisted (inside the same window) on next video play (overriding the preference
For autoplay (playlist/up next) it doesn't seem to be a problem (no need to exit current mode)
For pasting an URL it's necessary to exit fullscreen/fullwindow mode (Theater/pip has no such issue?)
For me I think it's quite hard to guess what user wants (stay in current mode/use preference) when pasting a URL
Wondering if having 2 more options with (always on) (for fullwindow + fullscreen) with tooltips helps (text to be refined ofc)

[absidue]

The current behaviour is very much by design, the default viewing mode setting is intentionally designed to only apply when you first visit the watch page, if you override the default once you are on the watch page e.g. exiting fullscreen, FreeTube remembers your choice. So if you go from the watch page straight to the next watch page (in that case you technically never actually leave the watch page, instead it is the same page with a different video), regardless of how you do it (auto-play, playlist auto-play, clicking on a related video, pasting in a URL), FreeTube will remember your viewing mode.

I agree with Pika here, if we want to change the meaning of that setting, it would be better to add two new options to the dropdown that are clearly labelled as always on so it is clear to the user that those options intentionally go against the "default" word in the name of the setting and will override the users choice.