Custom Auth failed when use littleskin.cn

[HowXu]

Operating System

Windows

Version of Prism Launcher

FreesmLauncher 1.4.4

Version of Qt

Same in FreesmLauncher Relese 1.4.4

Description of bug

I attempted to use littleskin.cn as the api address for Custom login, but the backend log output was 400 and an error was reported

Steps to reproduce

Use Custom Login
Input your account
input https://littleskin.cn/api/yggdrasil as the api
Login and check the launcher log

Suspected cause

I checked the CustomAuthStep.cpp and found the post body below

QString CustomAuthStep::requestTemplate()
{
    if (m_action == AuthFlow::Action::Login) {
        return R"XXX(
{
    "username": "%1",
    "password": "%2",
    "clientToken": "%3",
    "requestUser": false
}
)XXX";
    } else {
        return R"XXX(
{
    "accessToken": "%1",
    "clientToken": "%2",
    "requestUser": false
}
)XXX";
    }
}

Unfortunately, the above-mentioned access format is incorrect for the vast majority of skin sites using yggdrasil, see Yggdrasil server api，the correct format is as below:

return R"XXX(
{
    "username": "%1",
    "password": "%2",
    "clientToken": "%3",
    "requestUser": false,
    "agent":{
		"name":"Minecraft",
		"version":1
	}
}
)XXX";

however, I forked the repo and changed the format, sure it could login in successfully, the skin didn't load correctly.
I guess this is a bug for most skin sites include littleskin, which is the biggest one in China

This issue is unique

• I have searched the issue tracker and did not find an issue describing my bug.

[so5iso4ka]

Thank you for your contribution.

the skin didn't load correctly

Do you mean the account skin in the launcher? It installs correctly in-game, at least for me.

[HowXu]

Do you mean the account skin in the launcher? It installs correctly in-game, at least for me.

I didn't check it in the game, because in the launcher the account head img didn't show correctly like login with MSA
, and after I use skin manager when I selected the account, it showed nothing.

Now I tested it in game, the head img and skin manager still didn't work.

However, all these didn't happened in ShatteredPrism.

One more thing, most of the current yggdrasil logins have a multi-role selection function. That is, after logging in to the skin station with one email, you can choose different roles. This function is available on ShatteredPrism, and I think it should also be feasible for Freesm.

[HowXu]

Hey guys. I forked the repo and add a yggdrasil login option, but I do not know the develop requests in this project. could you check the repo I forked? If it's ok or after some polishment it's ok I will send a PR. One more thing, I add a download mirror feature. It's convenient for us Chinese, but seems useless for global (.

[so5iso4ka]

The code needs polishing, but the download mirrors are a good thing. It is unclear why the YggdrasilAccount class is needed, because CustomAccount should handle Yggdrasil accounts. They work as of 4b3e531, except for accounts with multiple profiles and the skin installation dialog from the launcher.
I'll take some of the code from your repository and list you as a co-author, okay?

[HowXu]

The code needs polishing, but the download mirrors are a good thing. It is unclear why the YggdrasilAccount class is needed, because CustomAccount should handle Yggdrasil accounts. They work as of 4b3e531, except for accounts with multiple profiles and the skin installation dialog from the launcher. I'll take some of the code from your repository and list you as a co-author, okay?

That's OK, I will not send a PR then.
I am not sure if the custom account will be used in other situations, such as Minecraft Universal Login(or UniPass, in China it doesn't have a extra name, but always applied in minecraft servers). At the same time, the fileds in custom account are not accurate for the yggdrasil login process. Therefore, I have separately created a class. Fortunately, even with making few changes (in YggdrasilProfileStep.cpp), it can function properly. I didn't have much time to modify yggdrasil, so I didn't include a profile selection box.
The changes I made on the download mirror were relatively crude because the download process for prsim was written in a rather coupled manner, and the use of url.replace is clearly not the best approach.
Thanks for your reply, I'm really looking forward to the next update of the Freesm Launcher.

[so5iso4ka]

Fixed in 2.0.0