Skip to content

LDAP.SearchObjects - Too strict check for attribute name #31

Description

@RikuVirtanen

Task has too strict check when checking the attribute name: https://github.com/FrendsPlatform/Frends.LDAP/blob/bd0e5cedccf89034c58d5005edcc3e89edf72c72/Frends.LDAP.SearchObjects/Frends.LDAP.SearchObjects/SearchObjects.cs#L150C12-L150C90

If the user puts capitalized attribute name into parameters the task will skip that and handle it with default type (string). I think we should use ToLower() method with the parameter attributes.Key and with the attribute name found with LDAP query.

Example:

new Frends.LDAP.SearchObjects.Definitions.Attributes[] { new Frends.LDAP.SearchObjects.Definitions.Attributes { Key = "ObjectGUID", ReturnType = Frends.LDAP.SearchObjects.Definitions.ReturnType.Guid } }

This will result for the objectGUID returning in String type because the actual attribute is not capitalized.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions