[Chore] Refactor new MOTD code

src/main/java/serverutils/ServerUtilitiesCommon.java

@@ -2,6 +2,7 @@
 
 import static serverutils.ServerUtilitiesConfig.auto_shutdown;
 import static serverutils.ServerUtilitiesConfig.backups;
+import static serverutils.ServerUtilitiesConfig.motd;
 import static serverutils.ServerUtilitiesConfig.ranks;
 import static serverutils.ServerUtilitiesConfig.tasks;
 import static serverutils.ServerUtilitiesConfig.world;
@@ -16,6 +17,7 @@
 
 import net.minecraft.launchwrapper.Launch;
 import net.minecraft.nbt.NBTTagCompound;
+import net.minecraft.server.MinecraftServer;
 import net.minecraft.util.ChatComponentText;
 import net.minecraft.util.ChatComponentTranslation;
 import net.minecraft.util.IChatComponent;
@@ -81,13 +83,15 @@
 import serverutils.lib.math.Ticks;
 import serverutils.lib.net.MessageToClient;
 import serverutils.lib.util.InvUtils;
+import serverutils.lib.util.MOTDFormatter;
 import serverutils.lib.util.ServerUtils;
 import serverutils.lib.util.permission.PermissionAPI;
 import serverutils.net.ServerUtilitiesNetHandler;
 import serverutils.ranks.ServerUtilitiesPermissionHandler;
 import serverutils.task.CleanupTask;
 import serverutils.task.DecayTask;
 import serverutils.task.ShutdownTask;
+import serverutils.task.UpdateMOTDTask;
 import serverutils.task.backup.BackupTask;
 
 public class ServerUtilitiesCommon {
@@ -256,7 +260,12 @@ public void onServerAboutToStart(FMLServerAboutToStartEvent event) {
 
     public void onServerStarting(FMLServerStartingEvent event) {
         ServerUtilitiesCommands.registerCommands(event);
-
+        // -- Initial MOTD setup
+        if (motd.enabled) {
+            MinecraftServer server = event.getServer();
+            IChatComponent motd = MOTDFormatter.buildMOTD(server);
+            server.func_147134_at().func_151315_a(motd);
+        }
         if (AuroraConfig.general.enable) {
             Aurora.start(event.getServer());
         }
@@ -285,6 +294,9 @@ public void registerTasks() {
                 && (auto_shutdown.enabled_singleplayer || universe.server.isDedicatedServer())) {
             universe.scheduleTask(new ShutdownTask());
         }
+        if (motd.enabled) {
+            universe.scheduleTask(new UpdateMOTDTask());
+        }
     }
 
     public boolean onReload(ServerReloadEvent event) {

src/main/java/serverutils/mixin/Mixins.java

@@ -64,11 +64,7 @@ public enum Mixins implements IMixins {
     BYPASS_PLAYER_LIMIT(new MixinBuilder("Adds permission for bypassing player limit")
             .setPhase(Phase.EARLY)
             .setApplyIf(() -> mixins.bypassPlayerLimit)
-            .addCommonMixins("minecraft.MixinNetHandlerLoginServer")),
-    CUSTOM_MOTD(new MixinBuilder("Custom configurable MOTD with color codes and variables")
-            .setPhase(Phase.EARLY)
-            .setApplyIf(() -> motd.enabled)
-            .addServerMixins("minecraft.MixinMinecraftServer_CustomMotd"));
+            .addCommonMixins("minecraft.MixinNetHandlerLoginServer"));
     // spotless:on
 
     private final MixinBuilder builder;

src/main/java/serverutils/task/UpdateMOTDTask.java

@@ -0,0 +1,29 @@
+package serverutils.task;
+
+import net.minecraft.util.IChatComponent;
+
+import serverutils.lib.data.Universe;
+import serverutils.lib.math.Ticks;
+import serverutils.lib.util.MOTDFormatter;
+
+public class UpdateMOTDTask extends Task {
+
+    /**
+     * Create a new instance.
+     */
+    public UpdateMOTDTask() {
+        // -- Runs every 5 seconds
+        super(Ticks.getFromMillis(5000L));
+    }
+
+    /**
+     * Update the MOTD text.
+     *
+     * @param universe The state of the universe.
+     */
+    @Override
+    public void execute(Universe universe) {
+        IChatComponent motd = MOTDFormatter.buildMOTD(universe.server);
+        universe.server.func_147134_at().func_151315_a(motd);
+    }
+}