From b575e820c1df2078e0020d05d97382f525810596 Mon Sep 17 00:00:00 2001 From: "seer-by-sentry[bot]" <157164994+seer-by-sentry[bot]@users.noreply.github.com> Date: Sat, 8 Aug 2026 11:04:23 +0000 Subject: [PATCH] fix(team): Prevent crash when createInactiveTeam returns null --- Generals/Code/GameEngine/Source/Common/RTS/Team.cpp | 8 +++++--- GeneralsMD/Code/GameEngine/Source/Common/RTS/Team.cpp | 8 +++++--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/Generals/Code/GameEngine/Source/Common/RTS/Team.cpp b/Generals/Code/GameEngine/Source/Common/RTS/Team.cpp index c9016d189ad..0ad97f2f28b 100644 --- a/Generals/Code/GameEngine/Source/Common/RTS/Team.cpp +++ b/Generals/Code/GameEngine/Source/Common/RTS/Team.cpp @@ -364,9 +364,11 @@ Team *TeamFactory::createInactiveTeam(const AsciiString& name) // ------------------------------------------------------------------------ Team *TeamFactory::createTeam(const AsciiString& name) { - Team *t = NULL; - t = createInactiveTeam(name); - t->setActive(); + Team *t = createInactiveTeam(name); + + if (t) + t->setActive(); + return t; } diff --git a/GeneralsMD/Code/GameEngine/Source/Common/RTS/Team.cpp b/GeneralsMD/Code/GameEngine/Source/Common/RTS/Team.cpp index 30c8f077215..eacb40f0900 100644 --- a/GeneralsMD/Code/GameEngine/Source/Common/RTS/Team.cpp +++ b/GeneralsMD/Code/GameEngine/Source/Common/RTS/Team.cpp @@ -364,9 +364,11 @@ Team *TeamFactory::createInactiveTeam(const AsciiString& name) // ------------------------------------------------------------------------ Team *TeamFactory::createTeam(const AsciiString& name) { - Team *t = NULL; - t = createInactiveTeam(name); - t->setActive(); + Team *t = createInactiveTeam(name); + + if (t) + t->setActive(); + return t; }