You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(ci): point sibling-checkout at Seungpyo1007/TechAPI and drop PokeAPI mentions
CI was failing on every workflow because the sibling-data checkout pointed at
GetTechAPI/TechAPI, which does not exist — the dataset repo lives at
Seungpyo1007/TechAPI. Bulk-rename across the four workflows (test, refresh-data,
deploy-pages, coverage-report, validate-data), pyproject Data URL, the README,
and the site landing page.
Also strips the now-decided-against PokeAPI inspiration references from
README, app/dump.py docstring, app/main.py API description, refresh-data
header comment, DATA_PIPELINE / DEVELOPMENT / SPEC docs.
Copy file name to clipboardExpand all lines: docs/DATA_PIPELINE.md
+1-5Lines changed: 1 addition & 5 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -18,10 +18,6 @@ daily) refresh is plenty. That makes a pre-generated static dataset ideal:
18
18
-**Fast**: edge-cached files, no cold starts.
19
19
20
20
### How others do it
21
-
-**PokeAPI** converted its API to **static JSON files** in 2018, generated
22
-
from its database by an updater bot and hosted on cheap static hosting +
23
-
Cloudflare CDN. See [PokeAPI/api-data](https://github.com/PokeAPI/api-data),
24
-
[pokeapi.co/about](https://pokeapi.co/about).
25
21
-**Git scraping** (Simon Willison): a scheduled GitHub Actions job fetches
26
22
data, pretty-prints it, and commits it back when it changes — no server
27
23
needed. See [simonwillison.net](https://simonwillison.net/2020/Oct/9/git-scraping/).
@@ -80,7 +76,7 @@ real option but is a **strategy change**, so here are the paths:
80
76
81
77
| Option | What it means | Trade-offs |
82
78
|---|---|---|
83
-
|**A. Public (current SPEC)**|`data/` + static dump public, CC-BY-SA | Simplest; matches open-data mission & PokeAPI model; community can contribute & self-host. Anyone can copy the data. |
79
+
|**A. Public (current SPEC)**|`data/` + static dump public, CC-BY-SA | Simplest; matches open-data mission; community can contribute & self-host. Anyone can copy the data. |
84
80
|**B. Private factory → public product**| Scrapers + raw/messy data in a **private** repo; only a curated, licensed **public dump** is published | Best of both: keep collection methods/raw data private, still ship an open API. Two repos to run. |
85
81
|**C. Fully private**| Data + dump + API all private (private repo, auth-gated API) | Maximum control / proprietary value, but abandons the open-data positioning, CC-BY-SA, and community contributions. The API stays code-MIT but data is closed. |
0 commit comments