Skip to content

Commit 89839cb

Browse files
committed
ci: clarify tracked verified coverage stats
1 parent ea63b84 commit 89839cb

1 file changed

Lines changed: 8 additions & 5 deletions

File tree

.github/workflows/techapi-pr-validation-comment.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -293,8 +293,8 @@ jobs:
293293
stats_lines: list[str] = []
294294
stats_lines.append("## Data summary")
295295
stats_lines.append("")
296-
stats_lines.append("| Category | Total | Verified | Unverified | Missing verified | Verified % |")
297-
stats_lines.append("| --- | ---: | ---: | ---: | ---: | ---: |")
296+
stats_lines.append("| Category | Total | Verified | Unverified | Missing verified | Tracked | Verified % of tracked |")
297+
stats_lines.append("| --- | ---: | ---: | ---: | ---: | ---: | ---: |")
298298
299299
total_all = verified_all = unverified_all = missing_verified_all = 0
300300
by_category: dict[str, dict[str, int]] = {}
@@ -327,14 +327,14 @@ jobs:
327327
unverified_all += unverified
328328
missing_verified_all += missing_verified
329329
stats_lines.append(
330-
f"| {category} | {total} | {verified} | {unverified} | {missing_verified} | {pct} |"
330+
f"| {category} | {total} | {verified} | {unverified} | {missing_verified} | {tracked} | {pct} |"
331331
)
332332
tracked_all = verified_all + unverified_all
333333
pct_all_value = verified_all / tracked_all * 100 if tracked_all else None
334334
pct_all = f"{pct_all_value:.1f}%" if pct_all_value is not None else "n/a"
335335
stats_lines.append(
336336
f"| **all** | **{total_all}** | **{verified_all}** | **{unverified_all}** | "
337-
f"**{missing_verified_all}** | **{pct_all}** |"
337+
f"**{missing_verified_all}** | **{tracked_all}** | **{pct_all}** |"
338338
)
339339
if pct_all_value is not None and pct_all_value < LOW_VERIFIED_WARNING_PCT:
340340
low_verified_categories.append(("all", pct_all_value, verified_all, tracked_all))
@@ -349,7 +349,10 @@ jobs:
349349
stats_lines.append("")
350350
stats_lines.append("> [!WARNING]")
351351
stats_lines.append(
352-
f"> Verified coverage is below {LOW_VERIFIED_WARNING_PCT:.0f}% for {coverage_list}."
352+
f"> Tracked verified coverage is below {LOW_VERIFIED_WARNING_PCT:.0f}% for {coverage_list}."
353+
)
354+
stats_lines.append(
355+
"> Tracked coverage excludes records missing the `verified` field; see the `Missing verified` column for those records."
353356
)
354357
stats_lines.append(
355358
"> This does not fail validation. Keep imported records `verified: false` until "

0 commit comments

Comments
 (0)