Skip to content

Commit b02c74b

Browse files
committed
ci: clarify verified counts in PR validation
1 parent 1e7bac2 commit b02c74b

1 file changed

Lines changed: 19 additions & 8 deletions

File tree

.github/workflows/techapi-pr-validation-comment.yml

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -196,33 +196,44 @@ jobs:
196196
lines: list[str] = []
197197
lines.append("## Data summary")
198198
lines.append("")
199-
lines.append("| Category | Total | Verified | Unverified | Verified % |")
200-
lines.append("| --- | ---: | ---: | ---: | ---: |")
199+
lines.append("| Category | Total | Verified | Unverified | Missing verified | Verified % |")
200+
lines.append("| --- | ---: | ---: | ---: | ---: | ---: |")
201201
202-
total_all = verified_all = unverified_all = 0
202+
total_all = verified_all = unverified_all = missing_verified_all = 0
203203
by_category: dict[str, dict[str, int]] = {}
204204
for category in CATEGORIES:
205205
paths = rel_jsons(HEAD, category)
206-
verified = unverified = 0
206+
verified = unverified = missing_verified = 0
207207
for path in paths.values():
208208
value = verified_value(load_json(path))
209209
if value is True:
210210
verified += 1
211211
elif value is False:
212212
unverified += 1
213+
else:
214+
missing_verified += 1
213215
total = len(paths)
214-
pct = f"{(verified / total * 100):.1f}%" if total else "0.0%"
216+
tracked = verified + unverified
217+
pct = f"{(verified / tracked * 100):.1f}%" if tracked else "n/a"
215218
by_category[category] = {
216219
"total": total,
217220
"verified": verified,
218221
"unverified": unverified,
222+
"missing_verified": missing_verified,
219223
}
220224
total_all += total
221225
verified_all += verified
222226
unverified_all += unverified
223-
lines.append(f"| {category} | {total} | {verified} | {unverified} | {pct} |")
224-
pct_all = f"{(verified_all / total_all * 100):.1f}%" if total_all else "0.0%"
225-
lines.append(f"| **all** | **{total_all}** | **{verified_all}** | **{unverified_all}** | **{pct_all}** |")
227+
missing_verified_all += missing_verified
228+
lines.append(
229+
f"| {category} | {total} | {verified} | {unverified} | {missing_verified} | {pct} |"
230+
)
231+
tracked_all = verified_all + unverified_all
232+
pct_all = f"{(verified_all / tracked_all * 100):.1f}%" if tracked_all else "n/a"
233+
lines.append(
234+
f"| **all** | **{total_all}** | **{verified_all}** | **{unverified_all}** | "
235+
f"**{missing_verified_all}** | **{pct_all}** |"
236+
)
226237
227238
lines.append("")
228239
lines.append("## PR data delta")

0 commit comments

Comments
 (0)