Skip to content

feat: Modular v2 enhancements — 12 gaps + modernization #419

feat: Modular v2 enhancements — 12 gaps + modernization

feat: Modular v2 enhancements — 12 gaps + modernization #419

Triggered via pull request March 10, 2026 05:01
Status Failure
Total duration 1m 11s
Artifacts 1

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

23 errors
lint
issues found
lint: service_typed.go#L7
error returned from interface method should be wrapped: sig: func (github.com/GoCodeAlone/modular.Application).RegisterService(name string, service any) error (wrapcheck)
lint: secret_resolver.go#L71
error returned from interface method should be wrapped: sig: func (github.com/GoCodeAlone/modular.SecretResolver).ResolveSecret(ctx context.Context, ref string) (string, error) (wrapcheck)
lint: modules/configwatcher/configwatcher.go#L98
error returned from external package is unwrapped: sig: func (*github.com/fsnotify/fsnotify.Watcher).Close() error (wrapcheck)
lint: modules/configwatcher/configwatcher.go#L83
error returned from external package is unwrapped: sig: func (*github.com/fsnotify/fsnotify.Watcher).Add(path string) error (wrapcheck)
lint: modules/configwatcher/configwatcher.go#L77
error returned from external package is unwrapped: sig: func github.com/fsnotify/fsnotify.NewWatcher() (*github.com/fsnotify/fsnotify.Watcher, error) (wrapcheck)
lint: health_service.go#L4
File is not properly formatted (gofmt)
lint: config_field_tracking.go#L20
File is not properly formatted (gofmt)
lint: application.go#L4
File is not properly formatted (gofmt)
lint: modules/configwatcher/configwatcher.go#L63
Error return value of `w.stopWatching` is not checked (errcheck)
Test
Process completed with exit code 1.
Test
Action failed with error: No valid CTRF reports found matching the pattern 'report.ctrf.json'.
Test
Process completed with exit code 1.
Test: feeders/yaml.go#L163
(interface).Debug call has arguments but no formatting directives
Test: feeders/yaml.go#L157
(interface).Debug call has arguments but no formatting directives
Test: feeders/yaml.go#L150
(interface).Debug call has arguments but no formatting directives
Test: feeders/yaml.go#L143
(interface).Debug call has arguments but no formatting directives
Test: feeders/yaml.go#L137
(interface).Debug call has arguments but no formatting directives
Test: feeders/yaml.go#L128
(interface).Debug call has arguments but no formatting directives
Test: feeders/yaml.go#L119
(interface).Debug call has arguments but no formatting directives
Test: feeders/yaml.go#L107
(interface).Debug call has arguments but no formatting directives
Test: feeders/yaml.go#L105
(interface).Debug call has arguments but no formatting directives
Test: feeders/yaml.go#L97
(interface).Debug call has arguments but no formatting directives

Artifacts

Produced during runtime
Name Size Digest
cli-coverage Expired
13 KB
sha256:34323796582a5be665208560c53127c92f11e931858f3d65b3be81620cbf7c91