chore(review): address feedback for eventlogger queue log, chimux dynamic route comment, eventbus exporter guidance, rotation guard cleanup, shutdown drain semantics

Author: intel352

modules/chimux/module.go

@@ -860,7 +860,12 @@ func (m *ChiMuxModule) disabledRouteMiddleware() func(http.Handler) http.Handler
 			if rctx != nil && len(rctx.RoutePatterns) > 0 {
 				pattern = rctx.RoutePatterns[len(rctx.RoutePatterns)-1]
 			} else {
-				// Fallback to request path (may cause mismatch for dynamic patterns)
+				// Fallback to the raw request path. WARNING: For parameterized routes (e.g. /users/{id})
+				// chi records the pattern as /users/{id} but r.URL.Path will be the concrete value
+				// such as /users/123. This means a disabled route registered as /users/{id} will NOT
+				// match here and the route may remain active. Admin tooling disabling dynamic routes
+				// should therefore prefer invoking DisableRoute() with the original pattern captured
+				// at registration time rather than a concrete request path.
 				pattern = r.URL.Path
 			}
 			method := r.Method

modules/eventbus/memory.go

@@ -218,10 +218,7 @@ func (m *MemoryEventBus) Publish(ctx context.Context, event Event) error {
 	// (when rotation disabled) to preserve deterministic ordering and avoid per-publish RNG cost.
 	if m.config.RotateSubscriberOrder && len(allMatchingSubs) > 1 {
 		pc := atomic.AddUint64(&m.pubCounter, 1) - 1
-		ln := len(allMatchingSubs)
-		if ln <= 0 {
-			return nil
-		}
+		ln := len(allMatchingSubs) // ln >= 2 here due to enclosing condition
 		// Compute rotation starting offset. We keep start as uint64 and avoid any uint64->int cast
 		// (gosec G115) by performing a manual copy instead of slicing with an int index.
 		start64 := pc % uint64(ln)

modules/eventbus/metrics_exporters.go

@@ -21,7 +21,10 @@ package eventbus
 //   go exporter.Run(ctx)
 //   ... later cancel();
 //
-// NOTE: Prometheus and Datadog dependencies are optional; if removed, comment out related code.
+// NOTE: Prometheus and Datadog dependencies are optional. If you want to exclude one of these
+// exporters for a build, prefer Go build tags (e.g. //go:build !prometheus) with the exporter
+// implementation moved to a separate file guarded by that tag, rather than manual comment edits.
+// This file keeps both implementations active by default for convenience.
 
 import (
 	"context"

modules/eventlogger/config.go

@@ -42,8 +42,8 @@ type EventLoggerConfig struct {
 	ShutdownEmitStopped bool `yaml:"shutdownEmitStopped" default:"true" desc:"Emit logger stopped operational event on Stop"`
 
 	// ShutdownDrainTimeout specifies how long Stop() should wait for in-flight events to drain.
-	// A zero or negative duration means unlimited wait (current behavior using WaitGroup).
-	ShutdownDrainTimeout time.Duration `yaml:"shutdownDrainTimeout" default:"2s" desc:"Maximum time to wait for draining event queue on Stop"`
+	// Zero or negative duration means unlimited wait (Stop blocks until all events processed).
+	ShutdownDrainTimeout time.Duration `yaml:"shutdownDrainTimeout" default:"2s" desc:"Maximum time to wait for draining event queue on Stop. Zero or negative = unlimited wait."`
 }
 
 // OutputTargetConfig configures a specific output target for event logs.

modules/eventlogger/module.go

@@ -604,14 +604,18 @@ func (m *EventLoggerModule) OnEvent(ctx context.Context, event cloudevents.Event
 				return
 			} else {
 				// Queue is full - drop oldest event and add new one
+				var droppedEventType string
 				if len(m.eventQueue) > 0 {
-					// Shift slice to remove first element (oldest)
+					// Capture dropped event type for debugging visibility then shift slice
+					droppedEventType = m.eventQueue[0].Type()
 					copy(m.eventQueue, m.eventQueue[1:])
 					m.eventQueue[len(m.eventQueue)-1] = event
 				}
 				if m.logger != nil {
 					m.logger.Debug("Event queue full, dropped oldest event",
-						"queue_size", m.queueMaxSize, "new_event", event.Type())
+						"queue_size", m.queueMaxSize,
+						"new_event", event.Type(),
+						"dropped_event", droppedEventType)
 				}
 				queueResult = nil
 				return