chore: remove compiled UI assets, build at release time (#2)

intel352 · claude · web-flow · commit 0722b5150128 · 2026-02-24T18:39:05.000-05:00
* chore: remove compiled UI assets from git, build at release time

Compiled UI assets should not be tracked in git. This change:
- Adds .gitignore to exclude internal/ui_dist/* (keeping placeholder index.html)
- Fixes Makefile ui target to output to internal/ui_dist/ (not repo root)
- Updates release workflow to build UI from source before Go compilation
- Removes stale ui_dist copy from install target (assets are embedded)

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;

* fix: use plain HTTPS clone since workflow repo is public

No GH_TOKEN secret needed — GoCodeAlone/workflow is a public repo.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;

---------

Co-authored-by: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -22,6 +22,17 @@ jobs:
         with:
           fetch-depth: 0
 
+      - uses: actions/setup-node@v4
+        with:
+          node-version: '22'
+
+      - name: Build admin UI
+        run: |
+          git clone --depth 1 https://github.com/GoCodeAlone/workflow.git /tmp/workflow-ui-build
+          cd /tmp/workflow-ui-build/ui && npm ci && npx vite build
+          rm -rf internal/ui_dist && cp -r /tmp/workflow-ui-build/ui/dist internal/ui_dist
+          rm -rf /tmp/workflow-ui-build
+
       - uses: actions/setup-go@v5
         with:
           go-version: '1.26'
diff --git a/.gitignore b/.gitignore
@@ -0,0 +1,20 @@
+# Compiled UI assets (built via 'make ui' or CI)
+internal/ui_dist/*
+!internal/ui_dist/index.html
+
+# Build output
+bin/
+dist/
+
+# Go
+*.exe
+*.exe~
+*.dll
+*.so
+*.dylib
+
+# Node (UI build artifacts)
+node_modules/
+
+# OS
+.DS_Store
diff --git a/Makefile b/Makefile
@@ -13,7 +13,6 @@ install: build
 	mkdir -p $(DESTDIR)/$(INSTALL_DIR)
 	cp bin/$(BINARY_NAME) $(DESTDIR)/$(INSTALL_DIR)/
 	cp plugin.json $(DESTDIR)/$(INSTALL_DIR)/
-	cp -r ui_dist $(DESTDIR)/$(INSTALL_DIR)/
 
 clean:
 	rm -rf bin/
@@ -22,5 +21,5 @@ ui:
 	@echo "Building admin UI from workflow repo..."
 	cd /tmp && rm -rf workflow-ui-build && git clone --depth 1 git@github.com:GoCodeAlone/workflow.git workflow-ui-build
 	cd /tmp/workflow-ui-build/ui && npm ci && npx vite build
-	rm -rf ui_dist && cp -r /tmp/workflow-ui-build/ui/dist ui_dist
+	rm -rf internal/ui_dist && cp -r /tmp/workflow-ui-build/ui/dist internal/ui_dist
 	rm -rf /tmp/workflow-ui-build
diff --git a/internal/ui_dist/index.html b/internal/ui_dist/index.html
@@ -1,2 +1,4 @@
-<!-- Placeholder: replace with built admin UI assets -->
-<html><body>Admin UI not built. Run 'make ui' to build.</body></html>
+<!DOCTYPE html>
+<html>
+<body>Run 'make ui' to build admin UI</body>
+</html>
