Skip to content

Commit 58ada3e

Browse files
intel352claude
andcommitted
fix: register components/pure and disable broken trigger factory
Import github.com/warpstreamlabs/bento/v4/public/components/pure in the production binary so that bloblang/mapping processor types are registered at runtime (previously only imported in test files via testmain_test.go). Disable TriggerTypes() returning "bento" because the external plugin adapter's TriggerFactories() method calls CreateModule instead of a non-existent CreateTrigger RPC, causing a nil trigger registration failure that prevents step.bento from loading. Triggers can be re-enabled once the host adapter implements the CreateTrigger RPC. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 37ed192 commit 58ada3e

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

cmd/workflow-plugin-bento/main.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ package main
66
import (
77
"github.com/GoCodeAlone/workflow-plugin-bento/internal"
88
sdk "github.com/GoCodeAlone/workflow/plugin/external/sdk"
9+
10+
// Register pure Bento components (mapping/bloblang processors, generate input, etc.)
11+
// so that step.bento can execute Bloblang transforms at runtime.
12+
_ "github.com/warpstreamlabs/bento/v4/public/components/pure"
913
)
1014

1115
func main() {

internal/plugin.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,12 @@ func (p *bentoPlugin) CreateStep(typeName, name string, config map[string]any) (
6262
}
6363

6464
// TriggerTypes returns the trigger type names this plugin provides.
65+
// Note: trigger support via the external plugin gRPC bridge is not yet fully
66+
// implemented in the host adapter (CreateTrigger RPC is missing). Returning an
67+
// empty list avoids a registration failure that would prevent step.bento from
68+
// loading. Triggers can be re-enabled once the host adapter supports them.
6569
func (p *bentoPlugin) TriggerTypes() []string {
66-
return []string{"bento"}
70+
return []string{}
6771
}
6872

6973
// CreateTrigger creates a trigger instance of the given type.

0 commit comments

Comments
 (0)