From 8e383f33f9c2dfa2261797a30de04d2a80c29127 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 7 May 2026 00:33:00 +0000 Subject: [PATCH 1/3] Initial plan From 39a148496e2064ef73c1fb39629380152e8e3fc1 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 7 May 2026 00:36:53 +0000 Subject: [PATCH 2/3] fix: update stale comment in provider_conformance_test.go (issue #62 already fixed in PR #68) Agent-Logs-Url: https://github.com/GoCodeAlone/workflow-plugin-digitalocean/sessions/962a09f7-575b-460c-85b7-d4de08c75f7b Co-authored-by: intel352 <77607+intel352@users.noreply.github.com> --- internal/provider_conformance_test.go | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/internal/provider_conformance_test.go b/internal/provider_conformance_test.go index 3412a58..36de64c 100644 --- a/internal/provider_conformance_test.go +++ b/internal/provider_conformance_test.go @@ -77,16 +77,10 @@ func TestConformance(t *testing.T) { t.Fatal("CONFORMANCE_LIVE_CLOUD=1 but DIGITALOCEAN_ACCESS_TOKEN is not set") } } - // Copilot review #13 (round 4) → #15 (round 5): - // pass t.Context() through Initialize so callers that - // honor context (and any future rev of Initialize that - // does) get the test-scoped cancellation/deadline path. - // Note: today's DOProvider.Initialize implementation - // constructs its godo client with its own - // context.Background() and ignores the passed-in ctx, - // so passing t.Context() is forward-prep rather than an - // immediate behavior change. Tracked as a follow-up to - // thread the context through the godo construction so + // Pass t.Context() so test-scoped cancellation/deadline + // flows into Initialize and the godo HTTP transport. + // Fixed in workflow-plugin-digitalocean#62 / PR #68: + // Initialize now forwards ctx to oauth2.NewClient so // LiveCloud cancellation reaches the HTTP transport. if err := p.Initialize(t.Context(), map[string]any{ "token": token, From a9f1a3343c912152c96114e796eb45063cc62a85 Mon Sep 17 00:00:00 2001 From: Jon Langevin Date: Wed, 6 May 2026 21:07:42 -0400 Subject: [PATCH 3/3] docs: clarify initialize context behavior --- internal/provider_conformance_test.go | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/internal/provider_conformance_test.go b/internal/provider_conformance_test.go index 36de64c..1b3457e 100644 --- a/internal/provider_conformance_test.go +++ b/internal/provider_conformance_test.go @@ -77,11 +77,10 @@ func TestConformance(t *testing.T) { t.Fatal("CONFORMANCE_LIVE_CLOUD=1 but DIGITALOCEAN_ACCESS_TOKEN is not set") } } - // Pass t.Context() so test-scoped cancellation/deadline - // flows into Initialize and the godo HTTP transport. - // Fixed in workflow-plugin-digitalocean#62 / PR #68: - // Initialize now forwards ctx to oauth2.NewClient so - // LiveCloud cancellation reaches the HTTP transport. + // Pass t.Context() so Initialize can honor context-scoped + // oauth2 HTTPClient injection instead of falling back to + // context.Background(). Per-request cancellation is still + // controlled by the ctx passed to each later driver/API call. if err := p.Initialize(t.Context(), map[string]any{ "token": token, "region": "nyc3",