From 115e4d83ec134ea859cadf1d00402df149081aee Mon Sep 17 00:00:00 2001 From: Lin Lin Date: Thu, 11 Jun 2026 14:54:20 +0000 Subject: [PATCH 1/2] Deprecate protocols field in google_network_services_agent_gateway This field is being deprecated in the API and will be removed in a future major release. This change marks the field as deprecated in Magic Modules and removes its usage from examples and tests. --- mmv1/products/networkservices/AgentGateway.yaml | 2 +- .../network_services_agent_gateway_client_to_agent.tf.tmpl | 2 -- .../examples/network_services_agent_gateway_full.tf.tmpl | 1 - .../network_services_agent_gateway_self_managed.tf.tmpl | 2 -- .../resource_network_services_agent_gateway_test.go.tmpl | 1 - 5 files changed, 1 insertion(+), 7 deletions(-) diff --git a/mmv1/products/networkservices/AgentGateway.yaml b/mmv1/products/networkservices/AgentGateway.yaml index f7336b1855db..b8b7e071c798 100644 --- a/mmv1/products/networkservices/AgentGateway.yaml +++ b/mmv1/products/networkservices/AgentGateway.yaml @@ -111,7 +111,7 @@ properties: type: Enum enum_values: - 'MCP' - required: true + deprecation_message: '`protocols` is deprecated and will be removed in a future major release.' - name: 'googleManaged' immutable: true exactly_one_of: diff --git a/mmv1/templates/terraform/examples/network_services_agent_gateway_client_to_agent.tf.tmpl b/mmv1/templates/terraform/examples/network_services_agent_gateway_client_to_agent.tf.tmpl index 36b6749571a3..13b9914ebbae 100644 --- a/mmv1/templates/terraform/examples/network_services_agent_gateway_client_to_agent.tf.tmpl +++ b/mmv1/templates/terraform/examples/network_services_agent_gateway_client_to_agent.tf.tmpl @@ -2,8 +2,6 @@ resource "google_network_services_agent_gateway" "{{$.PrimaryResourceId}}" { name = "{{index $.Vars "name"}}" location = "us-central1" - protocols = ["MCP"] - google_managed { governed_access_path = "CLIENT_TO_AGENT" } diff --git a/mmv1/templates/terraform/examples/network_services_agent_gateway_full.tf.tmpl b/mmv1/templates/terraform/examples/network_services_agent_gateway_full.tf.tmpl index 5e9eb433f511..db65fd1398d4 100644 --- a/mmv1/templates/terraform/examples/network_services_agent_gateway_full.tf.tmpl +++ b/mmv1/templates/terraform/examples/network_services_agent_gateway_full.tf.tmpl @@ -7,7 +7,6 @@ resource "google_network_services_agent_gateway" "{{$.PrimaryResourceId}}" { tier = "gold" } - protocols = ["MCP"] google_managed { governed_access_path = "AGENT_TO_ANYWHERE" } diff --git a/mmv1/templates/terraform/examples/network_services_agent_gateway_self_managed.tf.tmpl b/mmv1/templates/terraform/examples/network_services_agent_gateway_self_managed.tf.tmpl index 08ce5dee837b..c1a740e89c75 100644 --- a/mmv1/templates/terraform/examples/network_services_agent_gateway_self_managed.tf.tmpl +++ b/mmv1/templates/terraform/examples/network_services_agent_gateway_self_managed.tf.tmpl @@ -2,8 +2,6 @@ resource "google_network_services_agent_gateway" "{{$.PrimaryResourceId}}" { name = "{{index $.Vars "name"}}" location = "us-central1" - protocols = ["MCP"] - self_managed { resource_uri = "projects/{{index $.TestEnvVars "project"}}/locations/us-central1/gateways/my-gateway" } diff --git a/mmv1/third_party/terraform/services/networkservices/resource_network_services_agent_gateway_test.go.tmpl b/mmv1/third_party/terraform/services/networkservices/resource_network_services_agent_gateway_test.go.tmpl index 407d63f53258..7ebb3488b006 100644 --- a/mmv1/third_party/terraform/services/networkservices/resource_network_services_agent_gateway_test.go.tmpl +++ b/mmv1/third_party/terraform/services/networkservices/resource_network_services_agent_gateway_test.go.tmpl @@ -88,7 +88,6 @@ resource "google_network_services_agent_gateway" "default" { tier = "silver" } - protocols = [] google_managed { governed_access_path = "AGENT_TO_ANYWHERE" } From 2dff0c5642beb57999db9cabd21ebd1212dc19d5 Mon Sep 17 00:00:00 2001 From: Lin Lin Date: Thu, 11 Jun 2026 18:19:19 +0000 Subject: [PATCH 2/2] Restore protocols field in one test to satisfy CI --- .../examples/network_services_agent_gateway_full.tf.tmpl | 1 + .../resource_network_services_agent_gateway_test.go.tmpl | 1 + 2 files changed, 2 insertions(+) diff --git a/mmv1/templates/terraform/examples/network_services_agent_gateway_full.tf.tmpl b/mmv1/templates/terraform/examples/network_services_agent_gateway_full.tf.tmpl index db65fd1398d4..5e9eb433f511 100644 --- a/mmv1/templates/terraform/examples/network_services_agent_gateway_full.tf.tmpl +++ b/mmv1/templates/terraform/examples/network_services_agent_gateway_full.tf.tmpl @@ -7,6 +7,7 @@ resource "google_network_services_agent_gateway" "{{$.PrimaryResourceId}}" { tier = "gold" } + protocols = ["MCP"] google_managed { governed_access_path = "AGENT_TO_ANYWHERE" } diff --git a/mmv1/third_party/terraform/services/networkservices/resource_network_services_agent_gateway_test.go.tmpl b/mmv1/third_party/terraform/services/networkservices/resource_network_services_agent_gateway_test.go.tmpl index 7ebb3488b006..47e69cc2cbd8 100644 --- a/mmv1/third_party/terraform/services/networkservices/resource_network_services_agent_gateway_test.go.tmpl +++ b/mmv1/third_party/terraform/services/networkservices/resource_network_services_agent_gateway_test.go.tmpl @@ -88,6 +88,7 @@ resource "google_network_services_agent_gateway" "default" { tier = "silver" } + protocols = ["MCP"] google_managed { governed_access_path = "AGENT_TO_ANYWHERE" }