From 5f88c6e821cadeec89f46a29d298647cd6032354 Mon Sep 17 00:00:00 2001 From: jeffreylwang Date: Thu, 30 Jul 2026 19:14:39 +0000 Subject: [PATCH 1/2] workbench: diff-suppress server-injected versionDescription metadata The Workbench backend surfaces a system-owned instance metadata key `versionDescription` (a human-readable image description derived from the VmImage release configs, e.g. "Debian 11, Python 3.10"). Users never set it, so without a diff-suppress entry it causes a permadiff on google_workbench_instance (same class as new-proxy-agent-enabled, #17310). Add it to WorkbenchInstanceProvidedMetadata (server-owned, always injected). --- mmv1/templates/terraform/constants/workbench_instance.go.tmpl | 1 + 1 file changed, 1 insertion(+) diff --git a/mmv1/templates/terraform/constants/workbench_instance.go.tmpl b/mmv1/templates/terraform/constants/workbench_instance.go.tmpl index 4f987ad4c94d..40966c376cbb 100644 --- a/mmv1/templates/terraform/constants/workbench_instance.go.tmpl +++ b/mmv1/templates/terraform/constants/workbench_instance.go.tmpl @@ -83,6 +83,7 @@ var WorkbenchInstanceProvidedMetadata = []string{ "enable-guest-attributes", "enable-oslogin", "proxy-registration-url", + "versionDescription", } func WorkbenchInstanceMetadataDiffSuppress(k, old, new string, d *schema.ResourceData) bool { From ce71281c1e50162aecb1c98cf2eee52dd65d33ae Mon Sep 17 00:00:00 2001 From: jeffreylwang <107579579+jeffreylwang@users.noreply.github.com> Date: Fri, 31 Jul 2026 03:50:33 +0000 Subject: [PATCH 2/2] workbench: rename metadata key to version-description (kebab-case) --- mmv1/templates/terraform/constants/workbench_instance.go.tmpl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mmv1/templates/terraform/constants/workbench_instance.go.tmpl b/mmv1/templates/terraform/constants/workbench_instance.go.tmpl index 40966c376cbb..381b6a6f9874 100644 --- a/mmv1/templates/terraform/constants/workbench_instance.go.tmpl +++ b/mmv1/templates/terraform/constants/workbench_instance.go.tmpl @@ -83,7 +83,7 @@ var WorkbenchInstanceProvidedMetadata = []string{ "enable-guest-attributes", "enable-oslogin", "proxy-registration-url", - "versionDescription", + "version-description", } func WorkbenchInstanceMetadataDiffSuppress(k, old, new string, d *schema.ResourceData) bool {