From 679968df664c636638b376277326fcdd9c505f7e Mon Sep 17 00:00:00 2001 From: Chris Olsen Date: Fri, 7 Nov 2025 11:08:33 -0700 Subject: [PATCH] fix(#3167): fix dropdown rendering in Safari --- libs/react-components/specs/dropdown.browser.spec.tsx | 2 +- libs/web-components/src/components/dropdown/Dropdown.spec.ts | 3 +-- libs/web-components/src/components/dropdown/Dropdown.svelte | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/libs/react-components/specs/dropdown.browser.spec.tsx b/libs/react-components/specs/dropdown.browser.spec.tsx index 31f6f0a6da..23483cf82e 100644 --- a/libs/react-components/specs/dropdown.browser.spec.tsx +++ b/libs/react-components/specs/dropdown.browser.spec.tsx @@ -109,7 +109,7 @@ describe("Dropdown", () => { expect(dropdown.element().getAttribute("style")).toContain("--width: 500px"); await dropdown.click(); expect(popover.element().getAttribute("open")).toBe("true"); - expect(popoverDiv.element().getAttribute("style")).toContain("width: min(500px, 100%)"); + expect(popoverDiv.element().getAttribute("style")).toContain("500px"); }) }); diff --git a/libs/web-components/src/components/dropdown/Dropdown.spec.ts b/libs/web-components/src/components/dropdown/Dropdown.spec.ts index 832996df45..9a8d725010 100644 --- a/libs/web-components/src/components/dropdown/Dropdown.spec.ts +++ b/libs/web-components/src/components/dropdown/Dropdown.spec.ts @@ -2,7 +2,6 @@ import { cleanup, fireEvent, render, waitFor } from "@testing-library/svelte"; import GoADropdown from "./Dropdown.svelte"; import GoADropdownWrapper from "./DropdownWrapper.test.svelte"; import { describe, it } from "vitest"; -import { tick } from "svelte"; import userEvent from "@testing-library/user-event"; import type { UserEvent } from "@testing-library/user-event/dist/types/setup/setup"; @@ -1185,7 +1184,7 @@ describe("GoADropdown", () => { await waitFor(() => { const popover = result.container.querySelector("goa-popover"); - expect(popover?.getAttribute("width")).toBe("min(300px, 100%)"); + expect(popover?.getAttribute("width")).toBe("300px"); }); }); diff --git a/libs/web-components/src/components/dropdown/Dropdown.svelte b/libs/web-components/src/components/dropdown/Dropdown.svelte index 3d90cfcf16..6f9acadd78 100644 --- a/libs/web-components/src/components/dropdown/Dropdown.svelte +++ b/libs/web-components/src/components/dropdown/Dropdown.svelte @@ -195,7 +195,7 @@ if (width?.includes("%") || maxwidth?.includes("%")) { _popoverMaxWidth = "100%"; // let the parent's % width constraint handle it } else { - _popoverMaxWidth = `min(${_width}, 100%)`; + _popoverMaxWidth = _width; } }