with ansible-lint --fix

Author: Gpshfrd

ansible/playbooks/deploy.yml

@@ -1,9 +1,9 @@
 ---
 - name: Deploy application
   hosts: webservers
-  become: yes
+  become: true
   vars_files:
     - ../group_vars/all.yml
 
   roles:
-    - web_app
+    - web_app

ansible/playbooks/provision.yml

@@ -1,12 +1,12 @@
 ---
 - name: Provision web servers
   hosts: webservers
-  become: yes
+  become: true
 
   roles:
     - role: common
-      tags: 
+      tags:
         - common
     - role: docker
       tags:
-         - docker
+        - docker

ansible/roles/common/defaults/main.yml

@@ -5,4 +5,4 @@ common_packages:
   - git
   - vim
   - htop
-timezone: "Europe/Moscow"
+timezone: "Europe/Moscow"

ansible/roles/common/tasks/main.yml

@@ -3,7 +3,7 @@
   block:
     - name: Update apt cache
       apt:
-        update_cache: yes
+        update_cache: true
         cache_valid_time: 3600
 
     - name: Install common packages
@@ -12,8 +12,8 @@
         state: present
   rescue:
     - name: "Rescue: Fix apt cache issues"
-      ansible.builtin.apt: 
-          update_cache: yes
+      ansible.builtin.apt:
+        update_cache: true
       become: true
       tags:
         - packages
@@ -45,4 +45,4 @@
   timezone:
     name: "{{ timezone }}"
   tags:
-    - common
+    - common

ansible/roles/docker/defaults/main.yml

@@ -4,4 +4,4 @@ docker_packages:
   - docker-ce-cli
   - containerd.io
 docker_user: ubuntu
-docker_version: ""
+docker_version: ""

ansible/roles/docker/handlers/main.yml

@@ -1,5 +1,5 @@
 ---
-- name: restart docker
-  service:
+- name: Restart docker
+  ansible.builtin.service:
     name: docker
-    state: restarted
+    state: restarted

ansible/roles/docker/tasks/main.yml

@@ -6,48 +6,48 @@
     - docker
   block:
     - name: Add Docker GPG key
-      apt_key:
+      ansible.builtin.apt_key:
         url: https://download.docker.com/linux/ubuntu/gpg
         state: present
 
     - name: Add Docker repository
-      apt_repository:
+      ansible.builtin.apt_repository:
         repo: "deb [arch=amd64] https://download.docker.com/linux/ubuntu {{ ansible_distribution_release }} stable"
         state: present
 
     - name: Install Docker packages
-      apt:
+      ansible.builtin.apt:
         name:
           - docker-ce
           - docker-ce-cli
           - containerd.io
         state: present
-        update_cache: yes
+        update_cache: true
   rescue:
     - name: "Rescue: Retry apt update after GPG key failure"
-      command: apt-get update --fix-missing
+      ansible.builtin.command: apt-get update --fix-missing
       become: true
   always:
     - name: "Always: Ensure Docker service is enabled and started"
-      service:
+      ansible.builtin.service:
         name: docker
         state: started
-        enabled: yes
+        enabled: true
 
 - name: Docker configuration block
+  become: true
+  tags:
+    - docker_config
+    - docker
   block:
     - name: Add user to docker group
-      user:
+      ansible.builtin.user:
         name: "{{ docker_user }}"
         groups: docker
-        append: yes
+        append: true
 
     - name: Install python3-docker
-      pip:
+      ansible.builtin.pip:
         name: docker
         state: present
       notify: restart docker
-  become: true
-  tags:
-    - docker_config
-    - docker

ansible/roles/web_app/defaults/main.yml

@@ -7,8 +7,7 @@ compose_project_dir: "/opt/devops-info-python"
 docker_image_tag: latest
 restart_policy: unless-stopped
 env_vars: {}
-
-web_app_wipe: false  # Default: do not wipe
+web_app_wipe: false # Default: do not wipe
 # Set to true to remove application completely
 # Wipe only:    ansible-playbook deploy.yml -e "web_app_wipe=true" --tags web_app_wipe
-# Clean install: ansible-playbook deploy.yml -e "web_app_wipe=true"
+# Clean install: ansible-playbook deploy.yml -e "web_app_wipe=true"

ansible/roles/web_app/handlers/main.yml

@@ -1,12 +1,11 @@
 ---
-- name: restart application container
+- name: Restart application container
   community.docker.docker_container:
     name: "{{ app_container_name }}"
     image: "{{ docker_image }}:{{ docker_image_tag }}"
     state: started
     restart_policy: "{{ restart_policy }}"
     published_ports:
       - "{{ app_port }}:{{ app_port }}"
-    env:
-      "{{ env_vars }}"
-    recreate: yes
+    env: "{{ env_vars }}"
+    recreate: true

ansible/roles/web_app/meta/main.yml

@@ -1,3 +1,3 @@
 ---
 dependencies:
-    - role: docker
+  - role: docker