From 4196a0cbf3520dccfe2a1f51bb2924fb5c0d9d38 Mon Sep 17 00:00:00 2001 From: Gregoire Date: Thu, 16 Jul 2026 15:54:41 +0200 Subject: [PATCH] fix(github): require dd-toolkit's real CI check name Confirmed 'test-and-build' (the job id) from an actual completed run of dd-toolkit's ci.yml, rather than guessing the workflow's display name ('CI') the way forge-ui's required_status_checks was once wrong. Signed-off-by: Gregoire --- terraform/github/locals.tf | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/terraform/github/locals.tf b/terraform/github/locals.tf index ed7d1a4..9f807b1 100644 --- a/terraform/github/locals.tf +++ b/terraform/github/locals.tf @@ -298,12 +298,11 @@ locals { branch_protection = { enabled = true # "Commitlint" matches the check name used successfully across every - # other repo in this file. This repo's own ci.yml ("test-and-build") - # check isn't listed yet — add it once the real check name is - # confirmed from an actual PR run (see forge-ui above: a guessed - # placeholder ("CI") never matched any check and had to be corrected - # after the fact — better to add it once verified than guess wrong). - required_status_checks = ["Commitlint"] + # other repo in this file. "test-and-build" confirmed from a real + # run of dd-toolkit's own ci.yml (job id, not the workflow's display + # name "CI" -- see forge-ui above for why a guessed display name + # doesn't match). + required_status_checks = ["Commitlint", "test-and-build"] require_pr_reviews = false }