From b7321220c5bcdca6edf9e0ae620546fa3025f0dd Mon Sep 17 00:00:00 2001 From: Aaron Lee Date: Fri, 17 Jul 2026 14:26:37 -0400 Subject: [PATCH 1/3] fix: remove unprocessed payroll status badge Co-Authored-By: Claude Sonnet 4.6 --- .../PayrollList/PayrollStatusShowcase.stories.tsx | 11 ----------- .../PayrollStatusBadges/payrollStatusConfig.ts | 11 +---------- .../usePayrollStatusBadges.test.ts | 14 +++----------- src/i18n/en/Payroll.Common.json | 1 - src/i18n/types.d.ts | 2 -- 5 files changed, 4 insertions(+), 35 deletions(-) diff --git a/src/components/Payroll/PayrollList/PayrollStatusShowcase.stories.tsx b/src/components/Payroll/PayrollList/PayrollStatusShowcase.stories.tsx index 02fdca90f..6d9436142 100644 --- a/src/components/Payroll/PayrollList/PayrollStatusShowcase.stories.tsx +++ b/src/components/Payroll/PayrollList/PayrollStatusShowcase.stories.tsx @@ -159,14 +159,6 @@ export const AllStatusesShowcase = () => { }, // Priority 4: Fallback Statuses - { - ...createBasePayroll('unprocessed'), - payPeriod: { - ...createBasePayroll('unprocessed').payPeriod, - startDate: '2025-11-12', - endDate: '2025-11-26', - }, - }, { ...createBasePayroll('pending'), processed: true, @@ -399,9 +391,6 @@ export const Priority4_FallbackStatuses = () => { const yesterday = new Date(now - 24 * 60 * 60 * 1000) const payrolls: (Payroll & { payrollType: 'Regular' })[] = [ - { - ...createBasePayroll('unprocessed'), - }, { ...createBasePayroll('pending'), processed: true, diff --git a/src/components/Payroll/PayrollStatusBadges/payrollStatusConfig.ts b/src/components/Payroll/PayrollStatusBadges/payrollStatusConfig.ts index 4862bc35a..dec863323 100644 --- a/src/components/Payroll/PayrollStatusBadges/payrollStatusConfig.ts +++ b/src/components/Payroll/PayrollStatusBadges/payrollStatusConfig.ts @@ -5,7 +5,6 @@ import { normalizeToDate, getHoursUntil, getDaysUntil } from '@/helpers/dateForm /** @internal */ export type PayrollStatusTranslationKey = | 'processed' - | 'unprocessed' | 'calculating' | 'readyToSubmit' | 'processing' @@ -254,7 +253,7 @@ export const STATUS_CONFIG: StatusConfig[] = [ const daysDiff = getDaysUntil(payroll.payrollDeadline) if (hoursDiff === null || daysDiff === null) return false - return hoursDiff > 0 && hoursDiff >= 24 && Math.ceil(daysDiff) <= 30 + return hoursDiff > 0 && hoursDiff >= 24 && Math.ceil(daysDiff) <= 14 }, }, { @@ -280,12 +279,4 @@ export const STATUS_CONFIG: StatusConfig[] = [ }, condition: payroll => !!payroll.processed, }, - { - name: 'unprocessed', - badge: { - variant: 'info', - translationKey: 'unprocessed', - }, - condition: payroll => !payroll.processed && !payroll.processingRequest?.status, - }, ] diff --git a/src/components/Payroll/PayrollStatusBadges/usePayrollStatusBadges.test.ts b/src/components/Payroll/PayrollStatusBadges/usePayrollStatusBadges.test.ts index dbc52dc3b..1e3191f99 100644 --- a/src/components/Payroll/PayrollStatusBadges/usePayrollStatusBadges.test.ts +++ b/src/components/Payroll/PayrollStatusBadges/usePayrollStatusBadges.test.ts @@ -113,7 +113,7 @@ describe('usePayrollStatusBadges', () => { const wireInRequest = { status: 'awaiting_funds', paymentUuid: 'payroll-1' } const result = getPayrollStatusBadges(payroll, wireInRequest) - expect(result.badges[0]!.variant).toBe('info') + expect(result.badges).toHaveLength(0) }) }) @@ -172,14 +172,6 @@ describe('usePayrollStatusBadges', () => { }) describe('fallback statuses', () => { - it('returns Unprocessed for unprocessed payrolls without deadline', () => { - const payroll = { processed: false } - const result = getPayrollStatusBadges(payroll) - - expect(result.badges[0]!.variant).toBe('info') - expect(result.badges[0]!.translationKey).toBe('unprocessed') - }) - it('returns Complete for processed payrolls with past check date', () => { const pastDate = new Date(Date.now() - 24 * 60 * 60 * 1000).toISOString() const payroll = { processed: true, checkDate: pastDate } @@ -241,7 +233,7 @@ describe('usePayrollStatusBadges', () => { } const result = getPayrollStatusBadges(payroll) - expect(result.badges[0]!.variant).toBe('info') + expect(result.badges).toHaveLength(0) }) it('handles wire request with undefined status', () => { @@ -270,7 +262,7 @@ describe('usePayrollStatusBadges', () => { } const result = getPayrollStatusBadges(payroll) - expect(result.badges[0]!.variant).toBe('info') + expect(result.badges).toHaveLength(0) }) it('handles Date objects for checkDate', () => { diff --git a/src/i18n/en/Payroll.Common.json b/src/i18n/en/Payroll.Common.json index 46616c89d..5d123bfa7 100644 --- a/src/i18n/en/Payroll.Common.json +++ b/src/i18n/en/Payroll.Common.json @@ -1,7 +1,6 @@ { "status": { "processed": "Processed", - "unprocessed": "Unprocessed", "calculating": "Calculating...", "readyToSubmit": "Ready to submit", "processing": "Processing", diff --git a/src/i18n/types.d.ts b/src/i18n/types.d.ts index 08208504b..d6e5199c4 100644 --- a/src/i18n/types.d.ts +++ b/src/i18n/types.d.ts @@ -5605,8 +5605,6 @@ export namespace Translations { status: { /** @defaultValue `"Processed"` */ processed: string - /** @defaultValue `"Unprocessed"` */ - unprocessed: string /** @defaultValue `"Calculating..."` */ calculating: string /** @defaultValue `"Ready to submit"` */ From 29229dd6e7df4b9868e5751eed760b3b35939496 Mon Sep 17 00:00:00 2001 From: Aaron Lee Date: Fri, 17 Jul 2026 14:29:57 -0400 Subject: [PATCH 2/3] test: update dueInDays test description for 14-day window Co-Authored-By: Claude Sonnet 4.6 --- .../Payroll/PayrollStatusBadges/usePayrollStatusBadges.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/Payroll/PayrollStatusBadges/usePayrollStatusBadges.test.ts b/src/components/Payroll/PayrollStatusBadges/usePayrollStatusBadges.test.ts index 1e3191f99..45a46de00 100644 --- a/src/components/Payroll/PayrollStatusBadges/usePayrollStatusBadges.test.ts +++ b/src/components/Payroll/PayrollStatusBadges/usePayrollStatusBadges.test.ts @@ -254,7 +254,7 @@ describe('usePayrollStatusBadges', () => { expect(result.badges[0]!.variant).toBe('info') }) - it('handles deadline beyond 30 days', () => { + it('handles deadline beyond 14 days', () => { const futureTime = new Date(Date.now() + 45 * 24 * 60 * 60 * 1000) const payroll = { processed: false, From 01636a0aabfea728fdddaa60ced22633288e6c8a Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Fri, 17 Jul 2026 18:34:36 +0000 Subject: [PATCH 3/3] chore: update derived files --- docs/reference/Translations/index.md | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/reference/Translations/index.md b/docs/reference/Translations/index.md index 8c39f7d54..2e93611a7 100644 --- a/docs/reference/Translations/index.md +++ b/docs/reference/Translations/index.md @@ -3867,7 +3867,6 @@ Translation keys for the `Payroll.Common` i18n namespace. | `status.processing` | | `status.readyToSubmit` | | `status.submitted` | -| `status.unprocessed` | | `status.waitingForWireIn` | ***