Skip to content

Bug: RendererManager.removeControls() is misnamed actually removes a renderer #809

@GaneshPatil7517

Description

@GaneshPatil7517

In renderer-manager.ts:164-170, the method removeControls(renderer) splices from this.renderers rather than removing controls. This is a copy-paste naming error that makes the API confusing and may cause callers to miss the actual renderer removal method.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions