Skip to content

fix(replication): clean up blobs accepted during failed decode #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kriszyp wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

fix(replication): clean up blobs accepted during failed decode #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion replication/replicationConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1547,6 +1547,7 @@ export function replicateOverWS(ws: WebSocket, options: any, authorization: Prom
}
const id = auditRecord.recordId;
event = undefined; // reset before each decode attempt
let receivedBlobs: any[] | undefined;
try {
decodeBlobsWithWrites(
() => {
Expand All @@ -1565,7 +1566,11 @@ export function replicateOverWS(ws: WebSocket, options: any, authorization: Prom
};
},
auditStore?.rootStore,
(blob) => receiveBlobs(blob, id)
(blob) => {
const localBlob = receiveBlobs(blob, id);
(receivedBlobs ??= []).push(localBlob);
return localBlob;
}
);
} catch (error) {
logger.error?.(
Expand All @@ -1578,6 +1583,11 @@ export function replicateOverWS(ws: WebSocket, options: any, authorization: Prom
error
);
}
if (!event && receivedBlobs) {
// decode failed mid-message; the blobs that were already accepted will never be referenced. Give in-flight reads
// a window to complete, then unlink the files. (mirrors the pattern at the relocate path above.)
setTimeout(() => receivedBlobs.forEach(deleteBlob), 60000).unref();
}
replicationSharedStatus[RECEIVED_VERSION_POSITION] = Math.max(
// ensure monotonicity
auditRecord.version,
Expand Down
Loading