Fix flaky integration tests in shards 2 and 4#209
Merged
Conversation
Shard 2 (cloneNode): waitForAvailableStatus doesn't guarantee data has finished copying to the clone. Add a retry loop for the search_by_id verification so the test polls until the record appears rather than failing immediately on a race. Shard 4 (replicationLoad): the Replication Load Testing suite hit its 120 s timeout on shared CI runners — the suite includes node startup, cluster formation, 5000 upserts, app deploy with restart, a 35 s sleep, and 5000 blob requests. Raise the timeout to 300 s. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Reviewed; no blockers found. |
The inner suite has its own 60 s timeout. Its before() deploys an app with restart=true and waits a hard-coded 35 s, leaving insufficient time for the 5000-request blob test. Raise to 180 s. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
DavidCockerill
approved these changes
May 21, 2026
Contributor
Patch cherry-pick: mergedCherry-picked onto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitForAvailableStatusreports the node ready to serve but "Available" doesn't guarantee the data copy has finished.search_by_idnow retries up to 20× (×500 ms) until the record appears.'test timed out after 120000ms'). The suite runs 3-node startup + cluster formation + 10-DB creation + 10 s delay + 5000 upserts + app deploy/restart + 35 s sleep + 5000 blob requests. Raised timeout from 120 s to 300 s. The pre-existing 35 s hard-coded sleep is worth replacing with a health poll in a follow-up.Cross-model review (Gemini): no blockers. Reference failure: https://github.com/HarperFast/harper-pro/actions/runs/26229493925
Generated by Claude (claude-sonnet-4-6)