fix: hand-roll authorize promise wrapper to avoid DEP0174#749
Merged
Conversation
`util.promisify(auth.authorize)` triggered DEP0174 because some branches of `authorize` return the promise from the inner `authentication(...).then(...)` chain, which Node now treats as a likely misuse. Replace with a small manual callback->promise wrapper that preserves existing semantics. Fully converting `authorize` to async would be invasive due to its fastify middleware shape. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Reviewed; no blockers found. |
kriszyp
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
util.promisify(auth.authorize)with a small manual callback→promise wrapper to silence the Node.jsDEP0174deprecation warning.Why
auth.authorizeis a Node-style callback function ((req, res, next)), but some of its branches return the promise from an innerauthentication(...).then(...)chain. Node now flags this combination as a likely misuse ofutil.promisify. The wrapper is semantically identical to whatutil.promisifywas doing — it just doesn't perform the deprecation check.The goal of this PR is to reduce warnings.
Where to look
pAuthorizewrapper replacing theutil.promisifycall. Behavior should be unchanged for both consumers (authHandlerandauthAndEnsureUserOnRequest).authorizeitself to async; a TODO-style comment is added noting this can be removed once that happens.🤖 Generated with Claude Code