From 621d8b8607c5c1f76a90508a4b615b97c4acd3db Mon Sep 17 00:00:00 2001 From: Nathan Heskew Date: Thu, 21 May 2026 09:03:51 -0700 Subject: [PATCH] Bump both reviewer pins to ai-review-prompts@533f841 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Adopts ai-review-prompts#42 — two production-PR-driven fixes from oauth#89's first real run: 1. log-review-to-ai-review-log.sh now counts findings from the standardized "N blockers found." line both reviewers' prompts emit, with header-counting as the fallback. The prior `^### [0-9]\.` regex missed Claude's evolved inline-comment + terse-recap pattern; result on oauth#89 was the Claude log issue titled "no blockers" while 2 inline blockers were posted. The new regex tolerates optional markdown wrapping (`**2 blockers found.**` / `_1 blocker found._`). 2. Gemini's continuity preamble is now mandatory when the prior-findings reference is non-empty. Round 2 on oauth#89 showed Gemini correctly BEHAVING with continuity (dropping the resolved findings, adding a new one) but not NARRATING it — the updated comment read like an unrelated fresh review. Tightened prompt requires the top-level summary line to append a brief continuity note ("Reviewed; no blockers found. Prior K resolved by ." or "N blockers found. Prior K resolved by ; new findings below.") so updates are legible at a glance on the PR. _claude-review.yml is byte-identical between ea19009 and 533f841; bumping in lockstep stays a no-op for Claude behavior but keeps both callers on the same shared upgrade motion. Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/claude-review.yml | 4 ++-- .github/workflows/gemini-review.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/claude-review.yml b/.github/workflows/claude-review.yml index 186f5ec..43f66b9 100644 --- a/.github/workflows/claude-review.yml +++ b/.github/workflows/claude-review.yml @@ -26,7 +26,7 @@ concurrency: jobs: review: - uses: HarperFast/ai-review-prompts/.github/workflows/_claude-review.yml@ea190091328bcee674c4739ccc97dda177ecf0c5 # main 2026-05-20 (post #41 — Gemini calibration promoted; both reviewers back in lockstep on the same ai-review-prompts SHA, no _claude-review.yml changes vs the prior pin) + uses: HarperFast/ai-review-prompts/.github/workflows/_claude-review.yml@533f841137114315b0b4d02dabf367e376d9922e # main 2026-05-21 (post #42 — log-script counts from "N blockers found" line + tolerates markdown wrapping, fixing Claude-recap titles undercounting; _claude-review.yml itself unchanged) # Caller-side permissions, scoped at the calling-job level (NOT # workflow-level — that placement caps the reusable's per-job # grants below what they need and breaks the workflow at startup; @@ -51,7 +51,7 @@ jobs: # introspect their own ref (`github.workflow_ref` resolves to the # CALLER's ref in `workflow_call` context), and `uses: …@` # is parsed literally so we can't interpolate a variable. - ai-review-prompts-ref: ea190091328bcee674c4739ccc97dda177ecf0c5 + ai-review-prompts-ref: 533f841137114315b0b4d02dabf367e376d9922e review-layers: | universal harper/common diff --git a/.github/workflows/gemini-review.yml b/.github/workflows/gemini-review.yml index b13d5b4..0f0d67f 100644 --- a/.github/workflows/gemini-review.yml +++ b/.github/workflows/gemini-review.yml @@ -34,7 +34,7 @@ concurrency: jobs: review: - uses: HarperFast/ai-review-prompts/.github/workflows/_gemini-review.yml@ea190091328bcee674c4739ccc97dda177ecf0c5 # main 2026-05-20 (post #41 — Gemini calibration from oauth#87 promoted; single-shot supersedes the MCP rewrite, prior-body continuity, marker-check robustness) + uses: HarperFast/ai-review-prompts/.github/workflows/_gemini-review.yml@533f841137114315b0b4d02dabf367e376d9922e # main 2026-05-21 (post #42 — continuity preamble now mandatory when prior findings exist so Gemini updates narrate the round, plus log-script count-line fix) # Caller-side permissions, scoped at the calling-job level (NOT # workflow-level — that placement caps the reusable's per-job # grants below what they need and breaks the workflow at startup; @@ -56,7 +56,7 @@ jobs: # in this repo for why the duplication is unavoidable # (reusable workflows can't introspect their own ref in # workflow_call context). - ai-review-prompts-ref: ea190091328bcee674c4739ccc97dda177ecf0c5 + ai-review-prompts-ref: 533f841137114315b0b4d02dabf367e376d9922e review-layers: | universal harper/common