Skip to content

Commit 1da1c8c

Browse files
committed
jacs-mcp/src/jacs_tools.rs:4173-4201: the test test_tools_list_matches_compiled_features asserted that core tool names were "always present" without feature gates, but the nightly CI runs it with
--no-default-features --features mcp which excludes core-tools. The fix wraps each tool family's assertions with the matching #[cfg(feature = "...")] guard. Both --features mcp a
1 parent 731b448 commit 1da1c8c

1 file changed

Lines changed: 54 additions & 28 deletions

File tree

jacs-mcp/src/jacs_tools.rs

Lines changed: 54 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -4170,35 +4170,61 @@ mod tests {
41704170
"tools() count should match total_tool_count()"
41714171
);
41724172

4173-
// Core tools are always present (core-tools is in default features)
4174-
assert!(names.contains(&"jacs_sign_state"));
4175-
assert!(names.contains(&"jacs_verify_state"));
4176-
assert!(names.contains(&"jacs_load_state"));
4177-
assert!(names.contains(&"jacs_update_state"));
4178-
assert!(names.contains(&"jacs_list_state"));
4179-
assert!(names.contains(&"jacs_adopt_state"));
4180-
assert!(names.contains(&"jacs_create_agent"));
4181-
assert!(names.contains(&"jacs_reencrypt_key"));
4182-
assert!(names.contains(&"jacs_audit"));
4183-
assert!(names.contains(&"jacs_audit_log"));
4184-
assert!(names.contains(&"jacs_audit_query"));
4185-
assert!(names.contains(&"jacs_audit_export"));
4173+
// Core tool families — present when their feature flag is enabled
4174+
// (all included via core-tools in default features)
4175+
#[cfg(feature = "state-tools")]
4176+
{
4177+
assert!(names.contains(&"jacs_sign_state"));
4178+
assert!(names.contains(&"jacs_verify_state"));
4179+
assert!(names.contains(&"jacs_load_state"));
4180+
assert!(names.contains(&"jacs_update_state"));
4181+
assert!(names.contains(&"jacs_list_state"));
4182+
assert!(names.contains(&"jacs_adopt_state"));
4183+
}
4184+
4185+
#[cfg(feature = "document-tools")]
4186+
{
4187+
assert!(names.contains(&"jacs_create_agent"));
4188+
assert!(names.contains(&"jacs_sign_document"));
4189+
assert!(names.contains(&"jacs_verify_document"));
4190+
}
4191+
4192+
#[cfg(feature = "key-tools")]
4193+
{
4194+
assert!(names.contains(&"jacs_reencrypt_key"));
4195+
assert!(names.contains(&"jacs_export_agent_card"));
4196+
assert!(names.contains(&"jacs_generate_well_known"));
4197+
assert!(names.contains(&"jacs_export_agent"));
4198+
}
4199+
4200+
#[cfg(feature = "audit-tools")]
4201+
{
4202+
assert!(names.contains(&"jacs_audit"));
4203+
assert!(names.contains(&"jacs_audit_log"));
4204+
assert!(names.contains(&"jacs_audit_query"));
4205+
assert!(names.contains(&"jacs_audit_export"));
4206+
}
4207+
4208+
#[cfg(feature = "search-tools")]
41864209
assert!(names.contains(&"jacs_search"));
4187-
assert!(names.contains(&"jacs_sign_document"));
4188-
assert!(names.contains(&"jacs_verify_document"));
4189-
assert!(names.contains(&"jacs_export_agent_card"));
4190-
assert!(names.contains(&"jacs_generate_well_known"));
4191-
assert!(names.contains(&"jacs_export_agent"));
4192-
assert!(names.contains(&"jacs_trust_agent"));
4193-
assert!(names.contains(&"jacs_untrust_agent"));
4194-
assert!(names.contains(&"jacs_list_trusted_agents"));
4195-
assert!(names.contains(&"jacs_is_trusted"));
4196-
assert!(names.contains(&"jacs_get_trusted_agent"));
4197-
assert!(names.contains(&"jacs_memory_save"));
4198-
assert!(names.contains(&"jacs_memory_recall"));
4199-
assert!(names.contains(&"jacs_memory_list"));
4200-
assert!(names.contains(&"jacs_memory_forget"));
4201-
assert!(names.contains(&"jacs_memory_update"));
4210+
4211+
#[cfg(feature = "trust-tools")]
4212+
{
4213+
assert!(names.contains(&"jacs_trust_agent"));
4214+
assert!(names.contains(&"jacs_untrust_agent"));
4215+
assert!(names.contains(&"jacs_list_trusted_agents"));
4216+
assert!(names.contains(&"jacs_is_trusted"));
4217+
assert!(names.contains(&"jacs_get_trusted_agent"));
4218+
}
4219+
4220+
#[cfg(feature = "memory-tools")]
4221+
{
4222+
assert!(names.contains(&"jacs_memory_save"));
4223+
assert!(names.contains(&"jacs_memory_recall"));
4224+
assert!(names.contains(&"jacs_memory_list"));
4225+
assert!(names.contains(&"jacs_memory_forget"));
4226+
assert!(names.contains(&"jacs_memory_update"));
4227+
}
42024228

42034229
// Advanced tools conditionally present based on feature flags
42044230
#[cfg(feature = "messaging-tools")]

0 commit comments

Comments
 (0)