Drafted applications cannot be sent

[bmispelon]

Describe the bug

A clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

1. Create a fund/round/... (I use the Concept+Proposal type but I don't think it makes a difference here)
2. Navigate to the application form
3. Fill in required field
4. Press "Save draft"
5. In the next screen, press "continue editing"
6. Press "Preview and submit"

Expected behavior

You'd expect to be taken to the preview page, with an option to submit the application. Instead the draft is just saved (as if you'd clicked "saved draft" again).

Priority

• High (keeping you from completing day-to-day tasks)

Once in a draft state, applications cannot be submitted.

Affected roles

• Applicants

Workaround

As a temporary workaround, I've found that adding an invisible submit button to the form prevents the bug.
I've done that by adding a new line above

hypha/hypha/apply/funds/templates/funds/applicationsubmission_form.html

Line 35 in b747fec

{% trans "Save draft" as save_draft %}

:

<button type="submit" style="display:none"></button>

Desktop (please complete the following information):

• OS: Linux
• Browser Firefox
• Version 136.0.2

Additional context

I believe this is caused by this line:

hypha/hypha/static_src/javascript/application-form.js

Line 54 in b747fec

button.setAttribute("disabled", "disabled");

By making the submit button disabled, its name/value is not included in the POST data and the view therefore doesn't know that the "preview and send" button has been sent.

[frjo]

I can not replicate this in my local dev instance on main branch.

What version of Hypha are you using?

What fields have you added to the application form in question? You can try to narrow it down and see if it is a specific field that gives you issues.

We recently fixed a bug concerning required file fields in application forms, see #4457

[bmispelon]

We're running a forked version of Hypha where the last mainline commit is 8967ebe. We've done very minimal changes to the code however, so I would expect this bug to be present in standard Hypha.

Our application form has a lot of fields, I will try to set up a more minimal test case.

[wes-otf]

I'm wondering if #4510 fixed this? Curious what you all see when you get caught up @bmispelon

[frjo]

Please reopen if this is still an issue.