When `SUBMISSION_PREVIEW_REQUIRED` is enabled, selecting `Preview and submit` doesn't preview the application

[wes-otf]

When SUBMISSION_PREVIEW_REQUIRED is enabled, selecting Preview and submit will cause the application to immediately submit rather than displaying a preview to the user first

[frjo]

I can confirm this bug.

[frjo]

This code check if it's a preview or not. It works when users click the optional "Preview" button but fails when users click the mandatory "Preview and submit". The request.POST contains "preview" in the first case but not in the other when I test.

hypha/hypha/apply/funds/models/applications.py

Lines 506 to 507 in 0606ebd

	if request.method == "POST":
	preview = "preview" in request.POST

hypha/hypha/apply/funds/models/applications.py

Lines 674 to 675 in 0606ebd

	if request.method == "POST":
	preview = "preview" in request.POST

The buttons are created here:

hypha/hypha/apply/funds/templates/funds/application_base.html

Lines 69 to 80 in 0606ebd

	<div class="form__group">
	{# If a preview is required for this application, don't allow submitting yet (via name="preview"). At the moment, this functionality only works if a user is logged in. #}
	{% if require_preview and request.user.is_authenticated %}
	<button class="button button--submit button--primary" type="submit" name="preview" disabled>{% trans "Preview and submit" %}</button>
	{% else %}
	<button class="button button--submit button--primary" type="submit" disabled>{% trans "Submit for review" %}</button>
	{% endif %}
	<button class="button button--submit button--white" type="submit" name="draft" value="Save draft" formnovalidate>{% trans "Save draft" %}</button>
	{% if not require_preview and request.user.is_authenticated %}
	<button class="button button--submit button--white" type="submit" name="preview">{% trans "Preview" %}</button>
	{% endif %}
	</div>

Looks like it should work?!

[wes-otf]

Yeah this is really weird? I'll go deeper into this a little later this afternoon/tomorrow morning but at an initial glance it seems like all should work

[theskumar]

Very weird, I'm consistently missing the preview key from the submitted form data, while the draft is present when the "Save Draft" is clicked.

Couple of things I tried so far:

• Add name and value to button; the value was missing.
• Update the button to input.
• I had a hinge this has something to with button getting disabled, but that didn't help.
• Switched to having just a single submit button.

I'll keep trying to find why the browser is not sending the preview as a data point. I believe if the browser sends the data, Django will do the right thing.

[frjo]

Do we have a e.preventDefault() acting on the button somewhere?

[theskumar]

will check

[theskumar]

If the button strategy doesn't work, there are other workarounds I'm thinking:

• Use a dedicated view//url for preview, instead of overriding the submit endpoint
• htmx route with stateless preview, right now it has the side-effect of save as draft and then preview.

[theskumar]

I had a hinge this has something to with button getting disabled, but that didn't help.

This was the issue and got introduced when we tried to disable the button after clicking on submit. This is fixed in #4510