Enabling reports results in `'NoneType' object has no attribute 'end_date'` exception

[wes-otf]

Was just walking through the reporting feature on the test site, and when I enabled it by setting the frequency, a 'NoneType' object has no attribute 'end_date' error was thrown making the project page inaccessible as the error is always triggered on loading.

[wes-otf]

Looks like this only happens when the initial status isn't the default, I keep seeing it when setting to Invoicing and Reporting. Specifically this line is causing the issue:

hypha/hypha/apply/projects/reports/models.py

Lines 332 to 333 in d61b8a1

	if not self.project.start_date:
	return None

because the start_date property is based off when the contract is signed, which doesn't happen when skipping steps.

hypha/hypha/apply/projects/models/project.py

Lines 368 to 375 in d61b8a1

	def start_date(self):
	# Assume project starts when OTF are happy with the first signed contract
	first_approved_contract = (
	self.contracts.approved().order_by("approved_at").first()
	)
	if not first_approved_contract:
	return None
	return first_approved_contract.approved_at.date()

@frjo do you think we should use proposed_start instead if no contract exists?

[wes-otf]

I'll also confirm with OTF and make sure it's still accurate a project starts after contract signature

[wes-otf]

or maybe I'll just toss start_date all together and just use proposed_start if staff can set the field

[frjo]

@wes-otf Using proposed_start when there is no contract makes perfect sense to me.

I think it is good to decouple things like contract and reports as mush as possible. That makes Hypha more flexible. For others as well as for a future OTF.

[theskumar]

IMHO, explicit start date for the project make sense, it can default to some predefined rule like today or contract_sign etc.

I think a fix can be made on top of this PR: #4495

[wes-otf]

yeah that makes sense, I did confirm with staff that projects officially start for OTF after the contract is signed so maybe we hide start date for them until that happens? then once it does we could set proposed_start and if it was created in state after we could assume today and let them manually set it

[wes-otf]

Closed by #4495