The recent change to tag the image built in build.sh using the supplied release input parameter or by default the latest (e.g. currently 2.0.1.0) is problematic when using dockershell.sh without supplying the corresponding non-mandatory --es-version input parameter.
What happens currently when it is not supplied:
./dockershell.sh ...
...
docker: invalid reference format.
See 'docker run --help'.
Which is due to the use of: docker run ... eventstore_demo:${ES_VERSION} bash -c "$entryPoint" ... where ES_VERSION is set only if supplied by means of the --es-version input parameter.
We should make it mandatory or select an appropriate default when not set.
The recent change to tag the image built in
build.shusing the supplied release input parameter or by default the latest (e.g. currently2.0.1.0) is problematic when usingdockershell.shwithout supplying the corresponding non-mandatory--es-versioninput parameter.What happens currently when it is not supplied:
Which is due to the use of:
docker run ... eventstore_demo:${ES_VERSION} bash -c "$entryPoint"... whereES_VERSIONis set only if supplied by means of the--es-versioninput parameter.We should make it mandatory or select an appropriate default when not set.