Redundant test dependencies in package.xml of motion_capture_tracking

[Plumezz]

Hello, after building and testing this project with branch develop, I found something unexpected.

I noticed the package.xml files in the package motion_capture_tracking contains the following content which means a format check.

  <test_depend>ament_lint_auto</test_depend>
  <test_depend>ament_lint_common</test_depend>

But the test section in CMakeLists.txt is commented out resulting in no testing programs to run actually.

So I think if we want the ament_lint tools to do a format check, maybe need add the testing section in the CMakeLists.txt.

If we do not need the ament_lint_tools, the test_depend might be a redundant dependency that could be removed to reduce the burden of project maintenance.

I would appreciate it if you could tell me how do you think of this?

Thanks!

[whoenig]

Your assessment is correct. I believe the linter is commented out, because back when I tried there was no way to disable it for the external submodules this code heavily relies on (i.e., the SDKs provided by the various motion capture vendors). The proper fix would be to find a way to enable the linter, but only for the code we have control over. PRs welcome.