Merge pull request #461 from IQSS/460-include-name-in-guestbook-responses-api

ekraffmiller · web-flow · commit 86e2619f80b4 · 2026-07-08T05:32:38.000-04:00
Guestbook Response DTO Change Username to Name
diff --git a/src/guestbooks/domain/models/GuestbookResponse.ts b/src/guestbooks/domain/models/GuestbookResponse.ts
@@ -7,7 +7,7 @@ export interface GuestbookResponse {
   fileName?: string
   fileId?: number
   filePid?: string
-  userName: string
+  name: string
   email?: string
   institution?: string
   position?: string
diff --git a/test/unit/guestbooks/GetGuestbookResponsesByGuestbookId.test.ts b/test/unit/guestbooks/GetGuestbookResponsesByGuestbookId.test.ts
@@ -20,7 +20,7 @@ describe('GetGuestbookResponsesByGuestbookId', () => {
       type: EventType.DOWNLOAD,
       fileName: 'dp_statistics_for_grade_grouped_by_student_id.html',
       fileId: 3,
-      userName: 'Guest',
+      name: 'Guest',
       email: 'guest@example.edu',
       customQuestions: [
         {
diff --git a/test/unit/guestbooks/GuestbooksRepository.test.ts b/test/unit/guestbooks/GuestbooksRepository.test.ts
@@ -64,7 +64,7 @@ describe('GuestbooksRepository', () => {
           type: EventType.DOWNLOAD,
           fileName: 'dp_statistics_for_grade_grouped_by_student_id.html',
           fileId: 3,
-          userName: 'Guest',
+          name: 'Guest',
           email: 'guest@example.edu'
         }
       ]

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ describe('GetGuestbookResponsesByGuestbookId', () => {`
`20`	`20`	`type: EventType.DOWNLOAD,`
`21`	`21`	`fileName: 'dp_statistics_for_grade_grouped_by_student_id.html',`
`22`	`22`	`fileId: 3,`
`23`		`- userName: 'Guest',`
	`23`	`+ name: 'Guest',`
`24`	`24`	`email: 'guest@example.edu',`
`25`	`25`	`customQuestions: [`
`26`	`26`	`{`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ describe('GuestbooksRepository', () => {`
`64`	`64`	`type: EventType.DOWNLOAD,`
`65`	`65`	`fileName: 'dp_statistics_for_grade_grouped_by_student_id.html',`
`66`	`66`	`fileId: 3,`
`67`		`- userName: 'Guest',`
	`67`	`+ name: 'Guest',`
`68`	`68`	`email: 'guest@example.edu'`
`69`	`69`	`}`
`70`	`70`	`]`