Skip to content

CONTRIBUTING.md

Latest commit

 

History

History
15 lines (14 loc) · 2.96 KB

CONTRIBUTING.md

File metadata and controls

15 lines (14 loc) · 2.96 KB

Contributing rules

  • Use Conventional Commits: type(scope): subject
  • Types: feat, fix, refactor, perf, docs, style, chore, build, ci, revert
  • Subject: imperative, present tense, no period, keep it short
  • One commit = one logical change (split big work into smaller commits)
  • Prefix private class variables with an underscore (e.g. _cache, _token, _state) to clearly mark internal usage and avoid accidental external access.
  • In Angular templates, if the same expression (signal read, computed, or method call) is used more than once, assign it with @let and reuse the variable instead of calling it repeatedly. Use inline expression only when it appears once.
  • Use Bootstrap via BEM + component scss; keep templates readable (avoid long class strings). Prefer small, reusable BEM classes and put styling in scss; use Bootstrap utility classes only when they’re short and clearly improve readability.
  • Avoid hover effects that change layout (border/size/padding). Prefer non-layout effects (background tint, shadow) and always add matching :focus-visible styles.
  • Keep spacing and colors consistent (use Bootstrap spacing utilities and scale together with existing design tokens; avoid ad-hoc pixel values unless absolutely necessary).
  • Document only public functions and variables with short, clear comments directly above their declarations (purpose + expected behavior).
  • Angular forms: use the signals-based forms API only. Import from @angular/forms/signals (e.g. import { form, submit } from '@angular/forms/signals';) and avoid non-signal forms patterns in new code.
  • Angular v20+ signal-first APIs: use function-based APIs instead of decorators wherever possible: input() (not @Input()), output() (not @Output()), viewChild()/viewChildren() (not @ViewChild()/@ViewChildren()), contentChild()/contentChildren() (not @ContentChild()/@ContentChildren()), and model() for two-way binding when appropriate; in templates use the new control flow (@if, @for, @switch) instead of *ngIf/*ngFor/*ngSwitch, and prefer signals with computed()/effect() for local state over manual subscription patterns unless RxJS interop is clearly needed.
  • CSS variables (design tokens) first: use the tokens defined in src/styles.scss for colors, spacing, radius, shadows, motion, typography, and layout (e.g. var(--c-), var(--sp-), var(--radius-), var(--shadow-), var(--motion-*), var(--ff-base), var(--container), var(--gutter)). Don’t introduce hard-coded hex values or ad-hoc pixel spacing in component SCSS unless there’s no suitable token; if you must, add/extend a token in :root (and ensure it behaves correctly across modes data-mode, density data-density, and radius data-radius). Prefer customizing Bootstrap through variables/mappings driven by these tokens (e.g., CSS custom props or theme variables) instead of scattering direct overrides across components; keep framework-level overrides in the global styles and component-level styles minimal and token-based.