Commit fcf3901
FIX: Add overloads for DataArray.argmin and DataArray.argmax on dim parameter (pydata#11233)
* Fix mypy overload-overlap error for argmin and argmax
- Move `# type: ignore[overload-overlap]` to the @overload decorator
- Add whats-new entry
* Fix placement type: ignore comments for argmin and argmax
* Fix indentation in whats-new.rst
---------
Co-authored-by: Michael Niklas <mick.niklas@gmail.com>1 parent 8ac5ca0 commit fcf3901
2 files changed
Lines changed: 45 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
138 | 142 | | |
139 | 143 | | |
140 | 144 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
6187 | 6188 | | |
6188 | 6189 | | |
6189 | 6190 | | |
| 6191 | + | |
| 6192 | + | |
| 6193 | + | |
| 6194 | + | |
| 6195 | + | |
| 6196 | + | |
| 6197 | + | |
| 6198 | + | |
| 6199 | + | |
| 6200 | + | |
| 6201 | + | |
| 6202 | + | |
| 6203 | + | |
| 6204 | + | |
| 6205 | + | |
| 6206 | + | |
| 6207 | + | |
| 6208 | + | |
| 6209 | + | |
| 6210 | + | |
6190 | 6211 | | |
6191 | 6212 | | |
6192 | 6213 | | |
| |||
6288 | 6309 | | |
6289 | 6310 | | |
6290 | 6311 | | |
| 6312 | + | |
| 6313 | + | |
| 6314 | + | |
| 6315 | + | |
| 6316 | + | |
| 6317 | + | |
| 6318 | + | |
| 6319 | + | |
| 6320 | + | |
| 6321 | + | |
| 6322 | + | |
| 6323 | + | |
| 6324 | + | |
| 6325 | + | |
| 6326 | + | |
| 6327 | + | |
| 6328 | + | |
| 6329 | + | |
| 6330 | + | |
| 6331 | + | |
6291 | 6332 | | |
6292 | 6333 | | |
6293 | 6334 | | |
| |||
0 commit comments