You can assign a wrong player to a grouph phase (phase de poule)

[superboum]

This bug has been encountered during the live event.
The user was not able to see his matches.

I just investigated the problem. You can find the user inside the insalan.fr database.
I will use its internal id instead of his username to preserve his privacy.

So, the User ID is: 3416
This user has 2 identical players name:

• One for Hearthstone, with ID: 3531, validated, and indeed was part of this tournament (the correct player in our investigation)
• One for Overwatch, with ID: 3532, not validated, doesn't participate to this tournament (the incorrect player in our investigation)

Now, we will get a look at the tournament administration page, which show the Player ids in its source code. You can access the hearthstone page at this URL:
https://www.insalan.fr/tournament/27/admin

If you inspect the row in the table corresponding to the username, you will see:

<span class="arrived_status_3531">
    <button class="arrived" data-url="/tournament/27/admin/player/3531/toogleArrived/0" data-id="3531" onclick="changeArrivedStatus(this)">OUI</button>
    <button class="not_arrived" data-url="/tournament/27/admin/player/3531/toogleArrived/1" data-id="3531" onclick="changeArrivedStatus(this)" style="display:none">NON</button>
</span>

So we clearly see that the correct Player is displayed (with the id 3531) in the tournament admin page.

Now, we will get a look to generated matches in Sonata Admin for both Player IDs.
So, we will have 4 URLs to test:

1. part1.value=3531 -> returns nothing
2. part2.value=3531 -> returns nothing
3. part1.value=3532 -> returns 3 matches
4. part2.value=3532 -> returns nothing

We expect that the 1st or 2nd link returns the player's matches (corresponding to the ID of the Hearthstone Player).
Instead, the only one that returns something is the third one, so when we filter with the ID of the Overwatch Player.

So, the correct Player is linked to the tournament, but not the Group Phase.

• It should be impossible to link an Overwatch Player to an Hearthstone Group Phase.
• It should also be impossible to put a Player in a Group Phase of a Tournament, if the player is not already registered in this tournament.

[AntoineBvn]

Partially fixed by 3a7d5ff