fix: Preserve tombstones during L0 compaction#43
Merged
Conversation
…cCheng9/kv-engine into fix-tombstone-drop-in-l0-compaction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compact_sstablesdropped tombstones during L0→L1 compaction, letting deleted keys resurfacevalue.has_value(), so tombstones (nullopt values) were never written to the output filewrote_live_entrytowrote_any_entryto matchTombstoneSurvivesL0ToL1Compactionreproducing the bug via two consecutive L0 -> L1 compactions with the tombstone landing in the secondNewSSTableDeletesKeys->NewSSTableTombstonesShadowOlderValues: asserts the tombstone is preserved in the output (key present as a tombstone) rather than absentCompactionThatDeletesAllKeysDoesNotPublishEmptyLevelOneFile->CompactionWithOnlyTombstonesPublishesL1File: tombstone-only compactions now publish an L1 file (the tombstones are load-bearing); the engine still returns nullopt because the tombstone shadows correctly on readRationale