fix(cli): custom stage + isaacScriptCommonDev

Author: Zamiell

packages/isaacscript-cli/scripts/build.ts

@@ -90,7 +90,7 @@ function copyITDEnums(packageRoot: string) {
 
 function copyITDEnumsFlag(packageRoot: string) {
   const sourcePackage = "isaac-typescript-definitions";
-  const sourceDirectoryPath = path.join(
+  const sourceDirectoryPath = path.resolve(
     packageRoot,
     "..",
     sourcePackage,
@@ -132,7 +132,7 @@ function copyITDEnumsFlag(packageRoot: string) {
 
 function copyISCInterfaces(packageRoot: string) {
   const sourcePackage = "isaacscript-common";
-  const sourceDirectoryPath = path.join(
+  const sourceDirectoryPath = path.resolve(
     packageRoot,
     "..",
     sourcePackage,
@@ -176,7 +176,7 @@ function copyISCInterfaces(packageRoot: string) {
 
 function copyISCObjects(packageRoot: string) {
   const sourcePackage = "isaacscript-common";
-  const sourceDirectoryPath = path.join(
+  const sourceDirectoryPath = path.resolve(
     packageRoot,
     "..",
     sourcePackage,

packages/isaacscript-cli/src/commands/check/check.ts

@@ -130,7 +130,7 @@ function checkTemplateDirectory(
       }
 
       case "_gitattributes": {
-        projectFilePath = path.join(projectFilePath, "..", ".gitattributes");
+        projectFilePath = path.resolve(projectFilePath, "..", ".gitattributes");
         break;
       }
 

packages/isaacscript-cli/src/commands/copy/copy.ts

@@ -35,16 +35,23 @@ async function copy(options: CopyOptions) {
   const modTargetDirectoryName = getModTargetDirectoryName(config);
   const modTargetPath = path.join(config.modsDirectory, modTargetDirectoryName);
 
-  await compileAndCopy(MOD_SOURCE_PATH, modTargetPath, packageManager, verbose);
+  await compileAndCopy(
+    MOD_SOURCE_PATH,
+    modTargetPath,
+    packageManager,
+    config.isaacScriptCommonDev,
+    verbose,
+  );
 }
 
 export async function compileAndCopy(
   modSourcePath: string,
   modTargetPath: string,
   packageManager: PackageManager,
+  isaacScriptCommonDev: boolean | undefined,
   verbose: boolean,
 ): Promise<void> {
-  await prepareCustomStages(packageManager, verbose);
+  await prepareCustomStages(packageManager, isaacScriptCommonDev, verbose);
   compile(packageManager, verbose);
   copyMod(modSourcePath, modTargetPath);
 }

packages/isaacscript-cli/src/commands/monitor/monitor.ts

@@ -84,7 +84,11 @@ async function monitor(options: MonitorOptions) {
   }
 
   // Prepare the custom stages feature, if necessary.
-  await prepareCustomStages(packageManager, verbose);
+  await prepareCustomStages(
+    packageManager,
+    config.isaacScriptCommonDev,
+    verbose,
+  );
 
   // Delete and re-copy the mod every time IsaacScript starts. This ensures that it is always the
   // latest version.

packages/isaacscript-cli/src/commands/publish/isaacscriptMod.ts

@@ -33,7 +33,13 @@ export async function publishIsaacScriptMod(
   const version = await getPackageJSONVersion(undefined);
 
   runReleaseScriptPreCopy(verbose);
-  await compileAndCopy(MOD_SOURCE_PATH, modTargetPath, packageManager, verbose);
+  await compileAndCopy(
+    MOD_SOURCE_PATH,
+    modTargetPath,
+    packageManager,
+    config.isaacScriptCommonDev,
+    verbose,
+  );
   purgeRoomXMLs(modTargetPath);
   runReleaseScriptPostCopy(verbose);
 

packages/isaacscript-cli/src/customStage.ts

@@ -53,6 +53,7 @@ const EMPTY_SHADER_NAME = "IsaacScript-RenderAboveHUD";
 
 export async function prepareCustomStages(
   packageManager: PackageManager,
+  isaacScriptCommonDev: boolean | undefined,
   verbose: boolean,
 ): Promise<void> {
   const customStagesTSConfig = await getCustomStagesFromTSConfig();
@@ -64,7 +65,11 @@ export async function prepareCustomStages(
 
   copyCustomStageFilesToProject();
   await insertEmptyShader();
-  await fillCustomStageMetadata(customStagesTSConfig, packageManager);
+  await fillCustomStageMetadata(
+    customStagesTSConfig,
+    packageManager,
+    isaacScriptCommonDev,
+  );
   combineCustomStageXMLs(customStagesTSConfig, verbose);
 }
 
@@ -215,13 +220,31 @@ async function insertEmptyShader() {
 async function fillCustomStageMetadata(
   customStagesTSConfig: readonly CustomStageTSConfig[],
   packageManager: PackageManager,
+  isaacScriptCommonDev: boolean | undefined,
 ) {
   validateMetadataLuaFileExists(packageManager);
 
   const customStages = await getCustomStagesWithMetadata(customStagesTSConfig);
   const customStagesLua = await convertCustomStagesToLua(customStages);
   writeFile(METADATA_LUA_PATH, customStagesLua);
   console.log(`Wrote custom stage metadata to: ${METADATA_LUA_PATH}`);
+
+  // In development, the "isaacscript-common" directory will be linked to the "isaacscript"
+  // repository. However, even though the directory is soft-linked, writing to the above path will
+  // not propagate it correctly. Thus, we must also explicitly write it to the development path.
+  if (isaacScriptCommonDev === true) {
+    const METADATA_LUA_PATH_DEV = path.resolve(
+      CWD,
+      "..",
+      "isaacscript",
+      "packages",
+      "isaacscript-common",
+      "dist",
+      "customStageMetadata.lua",
+    );
+    writeFile(METADATA_LUA_PATH_DEV, customStagesLua);
+    console.log(`Wrote custom stage metadata to: ${METADATA_LUA_PATH_DEV}`);
+  }
 }
 
 function validateMetadataLuaFileExists(packageManager: PackageManager) {