refactor: path.join --> path.resolve

Author: Zamiell

packages/docs/scripts/build.mts

@@ -23,7 +23,7 @@ await buildScript(async (packageRoot) => {
   );
   rm(...generatedDocPaths);
 
-  const repoRoot = path.join(packageRoot, "..", "..");
+  const repoRoot = path.resolve(packageRoot, "..", "..");
 
   await Promise.all([makeITDDocs(repoRoot), makeISCDocs(repoRoot)]);
 

packages/docs/scripts/deploy.mts

@@ -18,9 +18,9 @@ const DOCS_REPO_NAME = "isaacscript.github.io";
 const GITHUB_PAGES_URL = `https://${DOCS_REPO_NAME}/isaacscript-common/core/constants/index.html`;
 const SECONDS_TO_SLEEP = 10;
 
-const PACKAGE_ROOT = path.join(import.meta.dirname, "..");
+const PACKAGE_ROOT = path.resolve(import.meta.dirname, "..");
 const BUILD_DIRECTORY_PATH = path.join(PACKAGE_ROOT, "build");
-const REPO_ROOT = path.join(PACKAGE_ROOT, "..", "..");
+const REPO_ROOT = path.resolve(PACKAGE_ROOT, "..", "..");
 const DOCS_REPO = path.join(REPO_ROOT, DOCS_REPO_NAME);
 const DOCS_REPO_GIT = path.join(DOCS_REPO, ".git");
 const DOCS_REPO_GIT_BACKUP = `/tmp/${DOCS_REPO_NAME}.git`;

packages/docs/scripts/fixIsaacScriptCommon.mts

@@ -58,7 +58,7 @@ import path from "node:path";
 
 const DEBUG = false as boolean;
 const PACKAGE_NAME = "isaacscript-common";
-const PACKAGE_ROOT = path.join(import.meta.dirname, "..");
+const PACKAGE_ROOT = path.resolve(import.meta.dirname, "..");
 const MARKDOWN_DOCS_DIR = path.join(PACKAGE_ROOT, "docs");
 const PACKAGE_DOCS_DIR = path.join(MARKDOWN_DOCS_DIR, PACKAGE_NAME);
 const MODULES_DIR = path.join(PACKAGE_DOCS_DIR, "modules");

packages/docs/scripts/fixIsaacTypeScriptDefinitions.mts

@@ -17,7 +17,7 @@ import fs from "node:fs";
 import path from "node:path";
 
 const PACKAGE_NAME = "isaac-typescript-definitions";
-const PACKAGE_ROOT = path.join(import.meta.dirname, "..");
+const PACKAGE_ROOT = path.resolve(import.meta.dirname, "..");
 const MARKDOWN_DOCS_DIR = path.join(PACKAGE_ROOT, "docs");
 const PACKAGE_DOCS_DIR = path.join(MARKDOWN_DOCS_DIR, PACKAGE_NAME);
 const MODULES_DIR = path.join(PACKAGE_DOCS_DIR, "modules");

packages/eslint-plugin-isaacscript/scripts/constants.ts

@@ -10,5 +10,5 @@ if (pluginName === undefined || pluginName === "") {
 }
 
 export const PLUGIN_NAME = pluginName;
-export const PACKAGE_ROOT = path.join(import.meta.dirname, "..");
-export const REPO_ROOT = path.join(PACKAGE_ROOT, "..", "..");
+export const PACKAGE_ROOT = path.resolve(import.meta.dirname, "..");
+export const REPO_ROOT = path.resolve(PACKAGE_ROOT, "..", "..");

packages/eslint-plugin-isaacscript/src/index.ts

@@ -26,7 +26,7 @@ export default plugin;
  * We parse the package JSON manually since importing JSON files directly in Node is experimental.
  */
 function getPackageJSON(): Record<string, unknown> {
-  const packageRoot = path.join(import.meta.dirname, "..");
+  const packageRoot = path.resolve(import.meta.dirname, "..");
   const packageJSONPath = path.join(packageRoot, "package.json");
   try {
     const packageJSONString = fs.readFileSync(packageJSONPath, "utf8");

packages/isaacscript-cli/scripts/build.ts

@@ -47,7 +47,7 @@ function copyIsaacScriptCommonFiles(packageRoot: string) {
 
 function copyITDEnums(packageRoot: string) {
   const sourcePackage = "isaac-typescript-definitions";
-  const sourceDirectoryPath = path.join(
+  const sourceDirectoryPath = path.resolve(
     packageRoot,
     "..",
     sourcePackage,

packages/isaacscript-cli/scripts/lint.ts

@@ -2,9 +2,9 @@ import chalk from "chalk";
 import { $, $s, diff, echo, exit, lintScript, readFile } from "complete-node";
 import path from "node:path";
 
-const REPO_ROOT = path.join(import.meta.dirname, "..");
+const PACKAGE_ROOT = path.resolve(import.meta.dirname, "..");
 const LOCAL_GITIGNORE_PATH = path.join(
-  REPO_ROOT,
+  PACKAGE_ROOT,
   "file-templates",
   "dynamic",
   "Node.gitignore",

packages/isaacscript-cli/src/commands/check/check.ts

@@ -146,7 +146,7 @@ function checkTemplateDirectory(
     let projectFilePath = path.join(CWD, relativeTemplateFilePath);
     switch (templateFileName) {
       case "_cspell.config.jsonc": {
-        projectFilePath = path.join(
+        projectFilePath = path.resolve(
           projectFilePath,
           "..",
           "cspell.config.jsonc",

packages/isaacscript-cli/src/commands/monitor/spawnSaveDatWriter.ts

@@ -17,7 +17,7 @@ export function spawnSaveDatWriter(config: ValidatedConfig): void {
     SUBPROCESS_NAME,
     SUBPROCESS_NAME,
   );
-  const modsDataPath = path.join(config.modsDirectory, "..", "data");
+  const modsDataPath = path.resolve(config.modsDirectory, "..", "data");
   const watcherModDataPath = path.join(modsDataPath, WATCHER_MOD_NAME);
   const saveDatFileName = `save${config.saveSlot}.dat`;
   const saveDatPath = path.join(watcherModDataPath, saveDatFileName);