fix: lint

Author: Zamiell

.vscode/settings.json

@@ -50,6 +50,10 @@
   // Use Prettier to format "cspell.config.jsonc".
   "cSpell.autoFormatConfigFile": true,
 
+  // Change all ESLint errors to have yellow squigglies instead of red squigglies.
+  // https://www.joshuakgoldberg.com/blog/if-i-wrote-a-linter-part-2-developer-experience/#only-errors
+  "eslint.rules.customizations": [{ "rule": "*", "severity": "warn" }],
+
   // -----------------
   // Language settings
   // -----------------

packages/isaac-typescript-definitions-repentogon/src/types/classes/PocketItem.d.ts

@@ -35,7 +35,7 @@ declare global {
      * }
      * ```
      */
-    GetSlot: () => CardType | PillColor | ActiveSlot | 0;
+    GetSlot: () => CardType | PillColor | ActiveSlot;
 
     /**
      * Returns the pocket item's `PocketItemType`.

packages/isaac-typescript-definitions-repentogon/src/types/classes/entity/EntityPlayer.d.ts

@@ -975,7 +975,7 @@ declare global {
      * consumable, its sub type is returned. If the player used the Question Mark card, 1 is
      * returned. Otherwise, 0 is returned.
      */
-    GetWildCardItem: () => CollectibleType | CardType | PillEffect | 0;
+    GetWildCardItem: () => CollectibleType | CardType | PillEffect;
 
     /**
      * Returns the type of item that was last used by the player and would be used again upon using

packages/isaac-typescript-definitions/src/types/mods/EID.d.ts

@@ -333,7 +333,7 @@ declare interface EIDInterface {
     Type: int,
     Variant: int,
     SubType: int,
-  ) => ["", "", string] | ["", string, string] | undefined;
+  ) => ["", string, string] | undefined;
 
   /** Get `KColor` object of "Entity Name" texts. */
   getNameColor: () => KColor;

packages/isaacscript-common/src/classes/ModFeature.ts

@@ -63,6 +63,8 @@ type ModFeatureConstructor = TSTLClassMetatable["constructor"] & {
  * upon first construction.)
  */
 export class ModFeature {
+  // Other features will extend from this feature and they might need access to the underlying mod.
+  // eslint-disable-next-line @typescript-eslint/no-unused-private-class-members
   private readonly mod: ModUpgraded;
 
   /**

packages/isaacscript-common/src/classes/ModUpgraded.ts

@@ -410,6 +410,7 @@ export class ModUpgraded implements Mod {
    * called from the "upgradeMod" function, but we want to mark it as private so that end-users
    * don't have access to it.
    */
+  // eslint-disable-next-line @typescript-eslint/no-unused-private-class-members
   private initOptionalFeature(feature: ISCFeature): readonly FunctionTuple[] {
     const featureClass = this.features[feature];
     this.initFeature(featureClass);

packages/isaacscript-common/src/classes/features/other/saveDataManager/restoreDefaults.ts

@@ -80,7 +80,7 @@ export function restoreDefaultForFeatureKey(
   const childTableDefaults = saveDataDefaults[saveDataKey];
   if (childTableDefaults === undefined) {
     logError(
-      `Failed to find the default copy of the child table "${saveDataKey}" for subscriber "${subscriberName}". This error usually means that your mod-specific save data is out of date. You can try purging all of your mod-specific save data by deleting the following directory: C:\\Program Files (x86)\\Steam\\steamapps\\common\\The Binding of Isaac Rebirth\\data`,
+      String.raw`Failed to find the default copy of the child table "${saveDataKey}" for subscriber "${subscriberName}". This error usually means that your mod-specific save data is out of date. You can try purging all of your mod-specific save data by deleting the following directory: C:\Program Files (x86)\Steam\steamapps\common\The Binding of Isaac Rebirth\data`,
     );
     return;
   }

packages/isaacscript-common/src/functions/deepCopyTests.ts

@@ -262,8 +262,7 @@ function copiedObjectHasChildObject() {
 function copiedMapIsMap() {
   const keyToLookFor = "abc";
   const valueToLookFor = "def";
-  const oldMap = new Map<string, string>();
-  oldMap.set(keyToLookFor, valueToLookFor);
+  const oldMap = new Map<string, string>([[keyToLookFor, valueToLookFor]]);
 
   const newMap = deepCopy(oldMap, SerializationType.NONE, "copiedMapIsMap");
 
@@ -275,8 +274,7 @@ function copiedMapIsMap() {
 function copiedMapHasValue() {
   const keyToLookFor = "abc";
   const valueToLookFor = "def";
-  const oldMap = new Map<string, string>();
-  oldMap.set(keyToLookFor, valueToLookFor);
+  const oldMap = new Map<string, string>([[keyToLookFor, valueToLookFor]]);
 
   const newMap = deepCopy(oldMap, SerializationType.NONE, "copiedMapHasValue");
 
@@ -295,8 +293,7 @@ function copiedMapHasValue() {
 
 function copiedSetIsSet() {
   const valueToLookFor = "abc";
-  const oldSet = new Set<string>();
-  oldSet.add(valueToLookFor);
+  const oldSet = new Set<string>([valueToLookFor]);
 
   const newSet = deepCopy(oldSet, SerializationType.NONE, "copiedSetIsSet");
 
@@ -307,8 +304,7 @@ function copiedSetIsSet() {
 
 function copiedSetHasValue() {
   const valueToLookFor = "abc";
-  const oldSet = new Set<string>();
-  oldSet.add(valueToLookFor);
+  const oldSet = new Set<string>([valueToLookFor]);
 
   const newSet = deepCopy(oldSet, SerializationType.NONE, "copiedSetHasValue");
 
@@ -325,12 +321,12 @@ function copiedSetHasValue() {
 function copiedMapHasChildMap() {
   const childMapKey = 123;
   const childMapValue = 456;
-  const oldChildMap = new Map<number, number>();
-  oldChildMap.set(childMapKey, childMapValue);
+  const oldChildMap = new Map<number, number>([[childMapKey, childMapValue]]);
 
   const keyToLookFor = "childMap";
-  const oldMap = new Map<string, Map<number, number>>();
-  oldMap.set(keyToLookFor, oldChildMap);
+  const oldMap = new Map<string, Map<number, number>>([
+    [keyToLookFor, oldChildMap],
+  ]);
 
   const newMap = deepCopy(
     oldMap,
@@ -446,8 +442,7 @@ function copiedDefaultMapHasBrand() {
 function copiedSerializedMapHasStringKey() {
   const mapKey = "123";
   const mapValue = 456;
-  const oldMap = new Map<string, number>();
-  oldMap.set(mapKey, mapValue);
+  const oldMap = new Map<string, number>([[mapKey, mapValue]]);
 
   const serializedOldMap = deepCopy(
     oldMap,
@@ -473,8 +468,7 @@ function copiedSerializedMapHasStringKey() {
 function copiedSerializedMapHasNumberKey() {
   const mapKey = 123;
   const mapValue = 456;
-  const oldMap = new Map<number, number>();
-  oldMap.set(mapKey, mapValue);
+  const oldMap = new Map<number, number>([[mapKey, mapValue]]);
 
   const serializedOldMap = deepCopy(
     oldMap,