Skip to content

Commit 723f837

Browse files
committed
fix google oauth error
1 parent 1287ad4 commit 723f837

4 files changed

Lines changed: 15 additions & 12 deletions

File tree

.env.example

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
# General
22
INTERFACE_EDITOR_URL=http://localhost:3000
33
ACCESS_CONTROL_ALLOW_ORIGIN=http://localhost:3000
4-
PUBLIC_FILE_PATH=http://localhost:9200/private/files/
54
JSONMS_CYPHER_KEY=urjMdK071cL935eKdczjEQ==
65

76
# Database

.github/workflows/deploy-dev.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
echo "JSONMS_CYPHER_KEY=${{ secrets.JSONMS_CYPHER_KEY }}" >> .env
5050
echo "GOOGLE_OAUTH_CLIENT_ID=637442439591-qrrpb3v9d3n5m8b8gheorfa1fbi5o6qc.apps.googleusercontent.com" >> .env
5151
echo "GOOGLE_OAUTH_CLIENT_SECRET=${{ secrets.GOOGLE_OAUTH_CLIENT_SECRET }}" >> .env
52-
echo "GOOGLE_OAUTH_CALLBACK_URL=637442439591-qrrpb3v9d3n5m8b8gheorfa1fbi5o6qc.apps.googleusercontent.com" >> .env
52+
echo "GOOGLE_OAUTH_CALLBACK_URL=https://server.dev.json.ms/google/callback" >> .env
5353
echo "DATABASE_HOST=${{ secrets.DATABASE_HOST }}" >> .env
5454
echo "DATABASE_DBNAME=${{ secrets.DATABASE_DEV_DBNAME }}" >> .env
5555
echo "DATABASE_USERNAME=${{ secrets.DATABASE_USERNAME }}" >> .env

.github/workflows/deploy-prod.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
echo "JSONMS_CYPHER_KEY=${{ secrets.JSONMS_CYPHER_KEY }}" >> .env
5050
echo "GOOGLE_OAUTH_CLIENT_ID=637442439591-qrrpb3v9d3n5m8b8gheorfa1fbi5o6qc.apps.googleusercontent.com" >> .env
5151
echo "GOOGLE_OAUTH_CLIENT_SECRET=${{ secrets.GOOGLE_OAUTH_CLIENT_SECRET }}" >> .env
52-
echo "GOOGLE_OAUTH_CALLBACK_URL=637442439591-qrrpb3v9d3n5m8b8gheorfa1fbi5o6qc.apps.googleusercontent.com" >> .env
52+
echo "GOOGLE_OAUTH_CALLBACK_URL=https://server.json.ms/google/callback" >> .env
5353
echo "DATABASE_HOST=${{ secrets.DATABASE_HOST }}" >> .env
5454
echo "DATABASE_DBNAME=${{ secrets.DATABASE_PROD_DBNAME }}" >> .env
5555
echo "DATABASE_USERNAME=${{ secrets.DATABASE_USERNAME }}" >> .env

src/controllers/SessionController.php

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -40,22 +40,26 @@ public function indexAction() {
4040
}
4141
else {
4242

43-
// Google Client Configuration
44-
$client = new Google_Client();
45-
$client->setClientId($_ENV['GOOGLE_OAUTH_CLIENT_ID']);
46-
$client->setClientSecret($_ENV['GOOGLE_OAUTH_CLIENT_SECRET']);
47-
$client->setRedirectUri($_ENV['GOOGLE_OAUTH_CALLBACK_URL']);
48-
$client->addScope('email');
49-
$client->addScope('profile');
50-
51-
$loginUrl = $client->createAuthUrl();
43+
try {
44+
// Google Client Configuration
45+
$client = new Google_Client();
46+
$client->setClientId($_ENV['GOOGLE_OAUTH_CLIENT_ID']);
47+
$client->setClientSecret($_ENV['GOOGLE_OAUTH_CLIENT_SECRET']);
48+
$client->setRedirectUri($_ENV['GOOGLE_OAUTH_CALLBACK_URL']);
49+
$client->addScope('email');
50+
$client->addScope('profile');
51+
$loginUrl = $client->createAuthUrl();
52+
} catch(\Exception $e) {
53+
throwError(500, $e->getMessage());
54+
}
5255

5356
try {
5457
$oauth2 = new Google_Service_Oauth2($client);
5558
$oauth2->userinfo->get();
5659
$loggedIn = true;
5760
} catch(\Exception $e) {
5861
$this->responseJson([
62+
'error' => $e->getMessage(),
5963
'loggedIn' => false,
6064
'user' => $user,
6165
'googleOAuthSignInUrl' => $loginUrl,

0 commit comments

Comments
 (0)