From 7ce373e770cea1d12fc110cec1f4044d8ab208a2 Mon Sep 17 00:00:00 2001 From: JSONbored <49853598+JSONbored@users.noreply.github.com> Date: Fri, 31 Jul 2026 00:32:17 -0700 Subject: [PATCH] =?UTF-8?q?fix(ci):=20unbreak=20main=20=E2=80=94=20drop=20?= =?UTF-8?q?the=20orphaned=20AUTOMATION=5FCOUNTED=5FACTIONS=20export?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Closes #10109 --- src/review/automation-rate.ts | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/review/automation-rate.ts b/src/review/automation-rate.ts index 99e63f39a..dd4fed63d 100644 --- a/src/review/automation-rate.ts +++ b/src/review/automation-rate.ts @@ -47,13 +47,14 @@ export const AUTOMATION_RATE_PROVENANCE_HORIZON_ISO = "2026-07-29T00:00:00.000Z" const AUTOMATION_ENACTING_ACTIONS = ["merge", "close"] as const; /** The action recording that the gate declined to decide and handed the PR to a person. Module-private for - * the same reason as the set above. */ + * the same reason as the set above. + * + * Together with the enacting set, this is what DECIDES a PR -- the published set the fold keys `decided` on. + * There is deliberately no exported union of the two: #10013 removed the `action IN (...)` SQL filter that + * was its only consumer, and an exported constant naming a set nothing selects on invites a reader to + * believe the read still restricts by it. The fold tests each half directly instead. */ const AUTOMATION_HOLD_ACTION = "hold"; -/** Every action that DECIDES a PR -- an enacted decision, or a hold. This is the published set the fold - * keys `decided` on; the read no longer restricts by it (#10013), so it does not gate what rows are seen. */ -export const AUTOMATION_COUNTED_ACTIONS: readonly string[] = [...AUTOMATION_ENACTING_ACTIONS, AUTOMATION_HOLD_ACTION]; - /** How completely a week could be measured. `full` weeks see every manual signal; `holds_only` weeks predate * the provenance fields and can only under-count manual work. */ export type AutomationWeekBasis = "full" | "holds_only";