From 9970c1bec930c2d2e02bf4b8b1d35768e4bc047a Mon Sep 17 00:00:00 2001 From: RealDiligent Date: Mon, 27 Jul 2026 21:24:13 +0800 Subject: [PATCH] fix(queue): correct maybeApplyManifestPolicyGate's "three"->"two" enforceable-findings comments maybeApplyManifestPolicyGate's JSDoc and inline comment both said it pushes "three enforceable policy findings", but its policyCodes set (and resolveConfiguredGateMode in advisory.ts) only has two. Update both comments to "two enforceable policy findings" to match the actual code. Comment-only; no logic changed. Closes #9295 Co-Authored-By: Claude Opus 4.8 --- src/queue/processors.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/queue/processors.ts b/src/queue/processors.ts index 897e0f7a15..7c14efa488 100644 --- a/src/queue/processors.ts +++ b/src/queue/processors.ts @@ -9315,7 +9315,7 @@ export function reviewDurationMsSince(startedAt: string | null, nowMs: number): /** * Focus-manifest policy gate (#555, opt-in via `manifestPolicyGateMode`). Reloads the CACHED manifest (the * settings resolver discards the raw manifest, but loadRepoFocusManifest is cached so this is cheap), - * recomputes the guidance over the PR's changed files, and pushes ONLY the three enforceable policy findings + * recomputes the guidance over the PR's changed files, and pushes ONLY the two enforceable policy findings * onto the advisory so isConfiguredGateBlocker can block under `manifestPolicy: block`. Also runs the E2E * test-generation auto-trigger (#4196, part of the #4189 epic) — see the inline comments below for the full * rationale of each step. `manifestPolicyGateMode: "off"` (the default) is a no-op, so the advisory/gate @@ -9338,7 +9338,7 @@ async function maybeApplyManifestPolicyGate( ): Promise { // Focus-manifest policy (#555, opt-in via manifestPolicyGateMode). Reload the CACHED manifest (the // settings resolver discards the raw manifest, but loadRepoFocusManifest is cached so this is cheap), - // recompute the guidance over the PR's changed files, and push ONLY the three enforceable policy + // recompute the guidance over the PR's changed files, and push ONLY the two enforceable policy // findings into the advisory so isConfiguredGateBlocker can block under manifestPolicy: block. if (args.settings.manifestPolicyGateMode !== "off") { // `gateFiles` is threaded in by the ONLY caller (maybePublishPrPublicSurface) already resolved via